From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH] cpufreq: acpi_cpufreq: base frequency attribute support
Date: Fri, 26 Feb 2016 12:21:38 -0800 [thread overview]
Message-ID: <1456518098.17628.92.camel@linux.intel.com> (raw)
In-Reply-To: <20160226015718.GA2639@vireshk-i7>
On Fri, 2016-02-26 at 07:27 +0530, Viresh Kumar wrote:
> On 25-02-16, 10:07, Srinivas Pandruvada wrote:
> > If I use cpufreq_driver.attr, then it will create sysfs attribute
> > for
> > every system using acpi-cpufreq, whether they can support it or
> > not.
> > This change is only needed for the later generation of Intel CPUs
> > (IvyBridge and later).
> > There is no standard ACPI way to know the base frequency if we add
> > attribute for all systems using acpi-cpufreq.
>
> Why can't you set cpufreq_driver.attr selectively from probe()?
>
We are setting a cpufreq global variable in cpufreq_driver->attr with
this for each cpu. This feature can be absent in certain cpus. So
unlike boost it is not system wide, so I have to reset the attr to NULL
for some cpus.
Can we assume that cpufreq_driver->init(policy) calls are always
serialized from cpu online/offline and subsys_interface callback path?
Thanks,
Srinivas
> See below for reference.
>
> commit 21c36d35711d ("cpufreq-dt: make scaling_boost_freqs sysfs attr
> available
> when boost is enabled")
>
next prev parent reply other threads:[~2016-02-26 20:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 22:25 [PATCH] cpufreq: acpi_cpufreq: base frequency attribute support Srinivas Pandruvada
2015-10-07 17:23 ` Viresh Kumar
2015-10-09 15:34 ` Srinivas Pandruvada
2015-10-15 22:45 ` Rafael J. Wysocki
2015-10-16 5:42 ` Viresh Kumar
2016-02-24 20:00 ` Srinivas Pandruvada
2016-02-24 20:05 ` Rafael J. Wysocki
2016-02-24 23:37 ` Srinivas Pandruvada
2016-02-25 3:27 ` Viresh Kumar
2016-02-25 18:07 ` Srinivas Pandruvada
2016-02-26 1:10 ` Pandruvada, Srinivas
2016-02-26 1:57 ` Viresh Kumar
2016-02-26 20:21 ` Srinivas Pandruvada [this message]
2016-02-29 3:16 ` Viresh Kumar
2016-02-29 17:11 ` Srinivas Pandruvada
2016-03-01 2:16 ` Viresh Kumar
-- strict thread matches above, loose matches on Subject: below --
2016-02-29 20:36 Srinivas Pandruvada
2016-03-01 2:28 ` Viresh Kumar
2016-03-01 18:10 ` Srinivas Pandruvada
2016-03-02 2:38 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456518098.17628.92.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.