From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Tom Yan <tom.ty89@gmail.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/2] sd: disable write same for SAT as per the comment
Date: Fri, 26 Feb 2016 12:57:30 -0800 [thread overview]
Message-ID: <1456520250.2369.45.camel@HansenPartnership.com> (raw)
In-Reply-To: <CAGnHSE=8d2=b3nN=0f14t_5Nf_GLsb0HXYeajZtz5As8SophsA@mail.gmail.com>
On Sat, 2016-02-27 at 04:32 +0800, Tom Yan wrote:
> Oh I made a mistake on this one then.
>
> Since I send it with another patch, should I resend that alone?
Yes, that's fine. but you need to explain as part of the changelog why
this condition needs inverting because your Subject just says "as per
the comment" which makes no sense if you're changing the comment.
James
next prev parent reply other threads:[~2016-02-26 20:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1456517250-2713-1-git-send-email-me>
2016-02-26 20:07 ` [PATCH 2/2] sd: disable write same for SAT as per the comment tom.ty89
2016-02-26 20:16 ` James Bottomley
2016-02-26 20:32 ` Tom Yan
2016-02-26 20:57 ` James Bottomley [this message]
2016-02-26 21:07 ` Tom Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456520250.2369.45.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=tom.ty89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.