From: Joe Perches <joe@perches.com>
To: Edward Lipinsky <ellipinsky@gmail.com>,
Larry.Finger@lwfinger.net, Jes.Sorensen@redhat.com,
gregkh@linuxfoundation.org
Cc: linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723au: Fix line longer than 80 columns.
Date: Sat, 27 Feb 2016 10:48:56 -0800 [thread overview]
Message-ID: <1456598936.4436.6.camel@perches.com> (raw)
In-Reply-To: <20160227182841.GA3387@gmail.com>
On Sat, 2016-02-27 at 10:28 -0800, Edward Lipinsky wrote:
> This patch fixes the checkpatch.pl warning:
> WARNING: line over 80 characters
[]
> diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
[]
> @@ -1834,7 +1834,8 @@ void stop_ap_mode23a(struct rtw_adapter *padapter)
> }
> spin_unlock_bh(&pacl_node_q->lock);
>
> - DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__, pacl_list->num);
> + DBG_8723A("%s, free acl_node_queue, num =%d\n", __func__,
> + pacl_list->num);
It's generally nicer to break the line at the end
of the format sting like:
DBG_8723A("%s, free acl_node_queue, num =%d\n",
__func__, pacl_list->num);
though it'd be even better to convert all of these
DBG_8723A uses to pr_debug
$ git ls-files drivers/staging/rtl8723au/ | \
xargs sed -r -i \
-e 's/\bDBG_8723A\b/pr_debug/g' \
-e 's/\bMSG|8723A\b/pr_debug/g'
next prev parent reply other threads:[~2016-02-27 18:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-27 18:28 [PATCH] staging: rtl8723au: Fix line longer than 80 columns Edward Lipinsky
2016-02-27 18:48 ` Joe Perches [this message]
2016-03-01 16:54 ` Edward Lipinsky
2016-03-12 19:45 ` [PATCHv2] " Edward Lipinsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456598936.4436.6.camel@perches.com \
--to=joe@perches.com \
--cc=Jes.Sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=ellipinsky@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.