From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tien Hock Loh <thloh@altera.com>
Subject: Re: gpio-altera OF binding discrepancy
Date: Mon, 29 Feb 2016 07:15:24 -0800
Message-ID: <1456758924.1035.4.camel@ubuntu>
References: <56D1059C.6090701@denx.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Return-path: <linux-gpio-owner@vger.kernel.org>
Received: from mail-bl2on0081.outbound.protection.outlook.com ([65.55.169.81]:40576
	"EHLO na01-bl2-obe.outbound.protection.outlook.com"
	rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
	id S1751038AbcB2Qrk convert rfc822-to-8bit (ORCPT
	<rfc822;linux-gpio@vger.kernel.org>); Mon, 29 Feb 2016 11:47:40 -0500
In-Reply-To: <56D1059C.6090701@denx.de>
Sender: linux-gpio-owner@vger.kernel.org
List-Id: linux-gpio@vger.kernel.org
To: "marex@denx.de" <marex@denx.de>
Cc: linux-gpio@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>, "thloh85@gmail.com" <thloh85@gmail.com>

Hi Marex

Yeah, it must've been a typo when I wrote the document, good catch
there. Can you help submit a patch to this?

Thanks

On Sat, 2016-02-27 at 03:10 +0100, marex@denx.de wrote:
> Hi!
> 
> I've just checked linux-4.4 and linux-next and discovered the following
> issue.
> 
> The Documentation/devicetree/bindings/gpio/gpio-altera.txt lists OF
> property altr,interrupt-trigger , which is not used anywhere in the
> kernel tree.
> 
> The drivers/gpio/gpio-altera.c on the other hand checks for a mandatory
> OF property altr,interrupt-type and assigns it into variable
> altera_gc->interrupt_trigger . Note that if this property is not in the
> DT, the driver will fail to probe.
> 
> Clearly, there is a typo between altr,interrupt-trigger and
> altr,interrupt-type . Since the driver fails to probe if altr,...-type
> property is not present, there must be users of this variant in the
> wild. I believe the Documentation/devicetree is a part of DT ABI, so the
> bindings there should not be randomly changed.
> 
> In this case, I would propose to change the Documentation though, since
> any users who try to use altr,...-trigger will have probe failures and
> fix their DT anyway.
> 
> Does this make sense ? If so, I will submit a patch .
> 
> Thanks!
>