From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 2/4] drm/i915/gen9: Sanitize handling of allowed DC states Date: Mon, 29 Feb 2016 20:04:58 +0200 Message-ID: <1456769098.18663.56.camel@intel.com> References: <1456336666-1184-1-git-send-email-imre.deak@intel.com> <1456336666-1184-3-git-send-email-imre.deak@intel.com> <20160229130234.GB21228@patrik-desktop.isw.intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id C728589FDE for ; Mon, 29 Feb 2016 18:05:21 +0000 (UTC) In-Reply-To: <20160229130234.GB21228@patrik-desktop.isw.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Patrik Jakobsson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gbWEsIDIwMTYtMDItMjkgYXQgMTQ6MDIgKzAxMDAsIFBhdHJpayBKYWtvYnNzb24gd3JvdGU6 Cj4gT24gV2VkLCBGZWIgMjQsIDIwMTYgYXQgMDc6NTc6NDRQTSArMDIwMCwgSW1yZSBEZWFrIHdy b3RlOgo+ID4gV2UgY2FuIHNpbXBsaWZ5IHRoZSBjb25kaXRpb25zIHNlbGVjdGluZyB0aGUgdGFy Z2V0IERDIHN0YXRlIGR1cmluZwo+ID4gcnVudGltZSBieSBjYWxjdWxhdGluZyB0aGUgYWxsb3dl ZCBEQyBzdGF0ZXMgaW4gYWR2YW5jZSBkdXJpbmcKPiA+IGRyaXZlcgo+ID4gbG9hZGluZy4gVGhp cyBhbHNvIG1ha2VzIGl0IGVhc2llciB0byBkaXNhYmxlIERDIHN0YXRlcyBkZXBlbmRpbmcKPiA+ IG9uIHRoZQo+ID4gaTkxNS5kaXNhYmxlX3Bvd2VyX3dlbGwgbW9kdWxlIG9wdGlvbiwgYWRkZWQg aW4gdGhlIG5leHQgcGF0Y2guCj4gPiAKPiA+IENDOiBQYXRyaWsgSmFrb2Jzc29uIDxwYXRyaWsu amFrb2Jzc29uQGxpbnV4LmludGVsLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IEltcmUgRGVhayA8 aW1yZS5kZWFrQGludGVsLmNvbT4KPiA+IC0tLQo+ID4gwqBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2Rydi5owqDCoMKgwqDCoMKgwqDCoMKgfMKgwqAxICsKPiA+IMKgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfcnVudGltZV9wbS5jIHwgNzQKPiA+ICsrKysrKysrKysrKysrKysrKysrKysr LS0tLS0tLS0tLQo+ID4gwqAyIGZpbGVzIGNoYW5nZWQsIDU0IGluc2VydGlvbnMoKyksIDIxIGRl bGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9kcnYuaAo+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gPiBpbmRleCA5 ZTc2YmZjLi5iNTYzZGU1IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9kcnYuaAo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ID4gQEAg LTc1MCw2ICs3NTAsNyBAQCBzdHJ1Y3QgaW50ZWxfY3NyIHsKPiA+IMKgCWk5MTVfcmVnX3QgbW1p b2FkZHJbOF07Cj4gPiDCoAl1aW50MzJfdCBtbWlvZGF0YVs4XTsKPiA+IMKgCXVpbnQzMl90IGRj X3N0YXRlOwo+ID4gKwl1aW50MzJfdCBhbGxvd2VkX2RjX21hc2s7Cj4gPiDCoH07Cj4gPiDCoAo+ ID4gwqAjZGVmaW5lIERFVl9JTkZPX0ZPUl9FQUNIX0ZMQUcoZnVuYywgc2VwKSBcCj4gPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVudGltZV9wbS5jCj4gPiBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3J1bnRpbWVfcG0uYwo+ID4gaW5kZXggODI3NmRjMi4u ODhkZjk5ZSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3J1bnRp bWVfcG0uYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVudGltZV9wbS5j Cj4gPiBAQCAtNTM4LDEyICs1MzgsOCBAQCBzdGF0aWMgdm9pZCBnZW45X3NldF9kY19zdGF0ZShz dHJ1Y3QKPiA+IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCB1aW50MzJfdCBzdGF0ZSkKPiA+ IMKgCWVsc2UKPiA+IMKgCQltYXNrIHw9IERDX1NUQVRFX0VOX1VQVE9fREM2Owo+ID4gwqAKPiA+ IC0JV0FSTl9PTl9PTkNFKHN0YXRlICYgfm1hc2spOwo+ID4gLQo+ID4gLQlpZiAoaTkxNS5lbmFi bGVfZGMgPT0gMCkKPiA+IC0JCXN0YXRlID0gRENfU1RBVEVfRElTQUJMRTsKPiA+IC0JZWxzZSBp ZiAoaTkxNS5lbmFibGVfZGMgPT0gMSAmJiBzdGF0ZSA+Cj4gPiBEQ19TVEFURV9FTl9VUFRPX0RD NSkKPiA+IC0JCXN0YXRlID0gRENfU1RBVEVfRU5fVVBUT19EQzU7Cj4gPiArCWlmIChXQVJOX09O X09OQ0Uoc3RhdGUgJiB+ZGV2X3ByaXYtPmNzci5hbGxvd2VkX2RjX21hc2spKQo+ID4gKwkJc3Rh dGUgJj0gZGV2X3ByaXYtPmNzci5hbGxvd2VkX2RjX21hc2s7Cj4gPiDCoAo+ID4gwqAJdmFsID0g STkxNV9SRUFEKERDX1NUQVRFX0VOKTsKPiA+IMKgCURSTV9ERUJVR19LTVMoIlNldHRpbmcgREMg c3RhdGUgZnJvbSAlMDJ4IHRvICUwMnhcbiIsCj4gPiBAQCAtNjU5LDggKzY1NSw3IEBAIHN0YXRp YyB2b2lkIGdlbjlfZGlzYWJsZV9kYzVfZGM2KHN0cnVjdAo+ID4gZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYpCj4gPiDCoHsKPiA+IMKgCWFzc2VydF9jYW5fZGlzYWJsZV9kYzUoZGV2X3ByaXYp Owo+ID4gwqAKPiA+IC0JaWYgKChJU19TS1lMQUtFKGRldl9wcml2KSB8fCBJU19LQUJZTEFLRShk ZXZfcHJpdikpICYmCj4gPiAtCcKgwqDCoMKgaTkxNS5lbmFibGVfZGMgIT0gMCAmJiBpOTE1LmVu YWJsZV9kYyAhPSAxKQo+ID4gKwlpZiAoZGV2X3ByaXYtPmNzci5hbGxvd2VkX2RjX21hc2sgJiBE Q19TVEFURV9FTl9VUFRPX0RDNikKPiA+IMKgCQlhc3NlcnRfY2FuX2Rpc2FibGVfZGM2KGRldl9w cml2KTsKPiA+IMKgCj4gPiDCoAlnZW45X3NldF9kY19zdGF0ZShkZXZfcHJpdiwgRENfU1RBVEVf RElTQUJMRSk7Cj4gPiBAQCAtODM5LDI2ICs4MzQsMTkgQEAgc3RhdGljIHZvaWQKPiA+IGdlbjlf ZGNfb2ZmX3Bvd2VyX3dlbGxfZW5hYmxlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diwKPiA+IMKgc3RhdGljIHZvaWQgZ2VuOV9kY19vZmZfcG93ZXJfd2VsbF9kaXNhYmxlKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlCj4gPiAqZGV2X3ByaXYsCj4gPiDCoAkJCQkJwqDCoMKgc3RydWN0 IGk5MTVfcG93ZXJfd2VsbAo+ID4gKnBvd2VyX3dlbGwpCj4gPiDCoHsKPiA+IC0JaWYgKChJU19T S1lMQUtFKGRldl9wcml2KSB8fCBJU19LQUJZTEFLRShkZXZfcHJpdikpICYmCj4gPiAtCcKgwqDC oMKgaTkxNS5lbmFibGVfZGMgIT0gMCAmJiBpOTE1LmVuYWJsZV9kYyAhPSAxKQo+ID4gKwlpZiAo ZGV2X3ByaXYtPmNzci5hbGxvd2VkX2RjX21hc2sgJiBEQ19TVEFURV9FTl9VUFRPX0RDNikKPiA+ IMKgCQlza2xfZW5hYmxlX2RjNihkZXZfcHJpdik7Cj4gPiAtCWVsc2UKPiA+ICsJZWxzZSBpZiAo ZGV2X3ByaXYtPmNzci5hbGxvd2VkX2RjX21hc2sgJgo+ID4gRENfU1RBVEVfRU5fVVBUT19EQzUp Cj4gPiDCoAkJZ2VuOV9lbmFibGVfZGM1KGRldl9wcml2KTsKPiA+IMKgfQo+ID4gwqAKPiA+IMKg c3RhdGljIHZvaWQgZ2VuOV9kY19vZmZfcG93ZXJfd2VsbF9zeW5jX2h3KHN0cnVjdCBkcm1faTkx NV9wcml2YXRlCj4gPiAqZGV2X3ByaXYsCj4gPiDCoAkJCQkJwqDCoMKgc3RydWN0IGk5MTVfcG93 ZXJfd2VsbAo+ID4gKnBvd2VyX3dlbGwpCj4gPiDCoHsKPiA+IC0JaWYgKHBvd2VyX3dlbGwtPmNv dW50ID4gMCkgewo+ID4gLQkJZ2VuOV9zZXRfZGNfc3RhdGUoZGV2X3ByaXYsIERDX1NUQVRFX0RJ U0FCTEUpOwo+ID4gLQl9IGVsc2Ugewo+ID4gLQkJaWYgKChJU19TS1lMQUtFKGRldl9wcml2KSB8 fAo+ID4gSVNfS0FCWUxBS0UoZGV2X3ByaXYpKSAmJgo+ID4gLQkJwqDCoMKgwqBpOTE1LmVuYWJs ZV9kYyAhPSAwICYmCj4gPiAtCQnCoMKgwqDCoGk5MTUuZW5hYmxlX2RjICE9IDEpCj4gPiAtCQkJ Z2VuOV9zZXRfZGNfc3RhdGUoZGV2X3ByaXYsCj4gPiBEQ19TVEFURV9FTl9VUFRPX0RDNik7Cj4g PiAtCQllbHNlCj4gPiAtCQkJZ2VuOV9zZXRfZGNfc3RhdGUoZGV2X3ByaXYsCj4gPiBEQ19TVEFU RV9FTl9VUFRPX0RDNSk7Cj4gPiAtCX0KPiA+ICsJaWYgKHBvd2VyX3dlbGwtPmNvdW50ID4gMCkK PiA+ICsJCWdlbjlfZGNfb2ZmX3Bvd2VyX3dlbGxfZW5hYmxlKGRldl9wcml2LAo+ID4gcG93ZXJf d2VsbCk7Cj4gPiArCWVsc2UKPiA+ICsJCWdlbjlfZGNfb2ZmX3Bvd2VyX3dlbGxfZGlzYWJsZShk ZXZfcHJpdiwKPiA+IHBvd2VyX3dlbGwpOwo+ID4gwqB9Cj4gPiDCoAo+ID4gwqBzdGF0aWMgdm9p ZCBpOXh4X2Fsd2F5c19vbl9wb3dlcl93ZWxsX25vb3Aoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUK PiA+ICpkZXZfcHJpdiwKPiA+IEBAIC0yMDIzLDYgKzIwMTEsNDggQEAgc2FuaXRpemVfZGlzYWJs ZV9wb3dlcl93ZWxsX29wdGlvbihjb25zdAo+ID4gc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2LAo+ID4gwqAJcmV0dXJuIDE7Cj4gPiDCoH0KPiA+IMKgCj4gPiArc3RhdGljIHVpbnQz Ml90IGdldF9hbGxvd2VkX2RjX21hc2soY29uc3Qgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUKPiA+ ICpkZXZfcHJpdiwKPiA+ICsJCQkJwqDCoMKgwqBpbnQgZW5hYmxlX2RjKQo+ID4gK3sKPiA+ICsJ dWludDMyX3QgbWFzayA9IDA7Cj4gPiArCj4gPiArCS8qCj4gPiArCcKgKiBEQzkgaGFzIGEgc2Vw YXJhdGUgSFcgZmxvdyBmcm9tIHRoZSByZXN0IG9mIHRoZSBEQwo+ID4gc3RhdGVzLCBub3QKPiA+ ICsJwqAqIGRlcGVuZGluZyBvbiB0aGUgRE1DIGZpcm13YXJlLiBJdCdzIG5lZWRlZCBieSBzeXN0 ZW0KPiA+ICsJwqAqIHN1c3BlbmQvcmVzdW1lLCBzbyBhbGxvdyBpdCB1bmNvbmRpdGlvbmFsbHku Cj4gPiArCcKgKi8KPiA+ICsJaWYgKElTX0JST1hUT04oZGV2X3ByaXYpKQo+ID4gKwkJbWFzayB8 PSBEQ19TVEFURV9FTl9EQzk7Cj4gPiArCj4gPiArCWlmICghZW5hYmxlX2RjKQo+ID4gKwkJcmV0 dXJuIG1hc2s7Cj4gPiArCj4gPiArCWlmICghSEFTX0NTUihkZXZfcHJpdikpCj4gPiArCQlyZXR1 cm4gbWFzazsKPiA+ICsKPiA+ICsJbWFzayB8PSBEQ19TVEFURV9FTl9VUFRPX0RDNTsKPiA+ICsJ aWYgKElTX1NLWUxBS0UoZGV2X3ByaXYpIHx8IElTX0tBQllMQUtFKGRldl9wcml2KSkgewo+ID4g KwkJbWFzayB8PSBEQ19TVEFURV9FTl9VUFRPX0RDNjsKPiA+ICsJfSBlbHNlIGlmICghSVNfQlJP WFRPTihkZXZfcHJpdikpIHsKPiA+ICsJCU1JU1NJTkdfQ0FTRShJTlRFTF9ERVZJRChkZXZfcHJp dikpOwo+ID4gKwkJbWFzayA9IDA7Cj4gPiArCX0KPiA+ICsKPiA+ICsJc3dpdGNoIChlbmFibGVf ZGMpIHsKPiA+ICsJY2FzZSAxOgo+ID4gKwkJbWFzayAmPSB+RENfU1RBVEVfRU5fVVBUT19EQzY7 Cj4gPiArCQlicmVhazsKPiA+ICsJY2FzZSAyOgo+IAo+IFNob3VsZCB3ZSBtYWtlIHNvbWUgbm9p c2UgaGVyZSBvbiBCWFQ/IEp1c3QgYSB0aG91Z2h0LCBub3Qgc3VyZSBpdCdzCj4gdXNlZnVsLgoK WWVzLCBJIGFkZGVkIHRoaXMgbm93LiBJJ2xsIHJlc2VuZCB0aGUgd2hvbGUgcGF0Y2hzZXQgd2l0 aCB0aGlzIGNoYW5nZQpzaW5jZSBwYXRjaHdvcmsgZGlkbid0IHBpY2sgdXAgdGhlIGZpcnN0IHZl cnNpb24gZm9yIHRlc3RpbmcuCgotLUltcmUKCj4gCj4gPiArCWNhc2UgLTE6Cj4gPiArCQlicmVh azsKPiA+ICsJZGVmYXVsdDoKPiA+ICsJCURSTV9FUlJPUigiVW5leHBlY3RlZCB2YWx1ZSBmb3Ig ZW5hYmxlX2RjICglZClcbiIsCj4gPiBlbmFibGVfZGMpOwo+ID4gKwkJYnJlYWs7Cj4gPiArCX0K PiA+ICsKPiA+ICsJcmV0dXJuIG1hc2s7Cj4gPiArfQo+ID4gKwo+ID4gwqAjZGVmaW5lIHNldF9w b3dlcl93ZWxscyhwb3dlcl9kb21haW5zLCBfX3Bvd2VyX3dlbGxzKSAoewkJCj4gPiBcCj4gPiDC oAkocG93ZXJfZG9tYWlucyktPnBvd2VyX3dlbGxzID0gKF9fcG93ZXJfd2VsbHMpOwkJCj4gPiAJ XAo+ID4gwqAJKHBvd2VyX2RvbWFpbnMpLT5wb3dlcl93ZWxsX2NvdW50ID0KPiA+IEFSUkFZX1NJ WkUoX19wb3dlcl93ZWxscyk7CVwKPiA+IEBAIC0yMDQxLDYgKzIwNzEsOCBAQCBpbnQgaW50ZWxf cG93ZXJfZG9tYWluc19pbml0KHN0cnVjdAo+ID4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp Cj4gPiDCoAo+ID4gwqAJaTkxNS5kaXNhYmxlX3Bvd2VyX3dlbGwgPQo+ID4gc2FuaXRpemVfZGlz YWJsZV9wb3dlcl93ZWxsX29wdGlvbihkZXZfcHJpdiwKPiA+IMKgCQkJCQkJwqDCoMKgwqDCoGk5 MTUuZGlzYWJsZV8KPiA+IHBvd2VyX3dlbGwpOwo+ID4gKwlkZXZfcHJpdi0+Y3NyLmFsbG93ZWRf ZGNfbWFzayA9Cj4gPiBnZXRfYWxsb3dlZF9kY19tYXNrKGRldl9wcml2LAo+ID4gKwkJCQkJCQnC oMKgwqDCoGk5MTUuZQo+ID4gbmFibGVfZGMpOwo+ID4gwqAKPiA+IMKgCUJVSUxEX0JVR19PTihQ T1dFUl9ET01BSU5fTlVNID4gMzEpOwo+ID4gwqAKPiA+IC0tIAo+ID4gMi41LjAKPiA+IAo+IApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK