From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32978) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aakiG-00075M-HB for qemu-devel@nongnu.org; Tue, 01 Mar 2016 08:51:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aakiB-0008JT-ID for qemu-devel@nongnu.org; Tue, 01 Mar 2016 08:51:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44182) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aakiB-0008JK-DL for qemu-devel@nongnu.org; Tue, 01 Mar 2016 08:51:39 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 0621AC00071A for ; Tue, 1 Mar 2016 13:51:39 +0000 (UTC) Message-ID: <1456840294.23994.89.camel@redhat.com> From: Gerd Hoffmann Date: Tue, 01 Mar 2016 14:51:34 +0100 In-Reply-To: <1456833053-8896-1-git-send-email-pbonzini@redhat.com> References: <1456833053-8896-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] log: do not log if QEMU is daemonized but without -D List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: jtomko@redhat.com, qemu-devel@nongnu.org On Di, 2016-03-01 at 12:50 +0100, Paolo Bonzini wrote: > Commit 96c33a4 ("log: Redirect stderr to logfile if deamonized", > 2016-02-22) wanted to move stderr of a daemonized QEMU to the file > specified with -D. >=20 > However, if -D was not passed, the patch had the side effect of not > redirecting stderr to /dev/null. This happened because qemu_logfile > was set to stderr rather than the expected value of NULL. The fix > is simply in the "if" condition of do_qemu_set_log; the "if" for > closing the file is also changed to match. Tested-by: Gerd Hoffmann cheers, Gerd