All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <jouni@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Fix Public Action frame RX in AP mode
Date: Tue, 01 Mar 2016 15:45:21 +0100	[thread overview]
Message-ID: <1456843521.3926.30.camel@sipsolutions.net> (raw)
In-Reply-To: <1456784940-32328-1-git-send-email-jouni@qca.qualcomm.com>

On Tue, 2016-03-01 at 00:29 +0200, Jouni Malinen wrote:
> Public Action frames use special rules for how the BSSID field
> (Address
> 3) is set. A wildcard BSSID is used in cases where the transmitter
> and
> recipient are not members of the same BSS. As such, we need to accept
> Public Action frames with wildcard BSSID.
> 
> Commit db8e17324553 ("mac80211: ignore frames between TDLS peers when
> operating as AP") added a rule that drops Action frames to TDLS-peers
> based on an Action frame having different DA (Address 1) and BSSID
> (Address 3) values. This is not correct since it misses the
> possibility
> of BSSID being a wildcard BSSID in which case the Address 1 would not
> necessarily match.
> 
> Fix this by allowing mac80211 to accept wildcard BSSID in an Action
> frame when in AP mode.
> 
Applied, thanks.

johannes

      parent reply	other threads:[~2016-03-01 14:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-29 22:29 [PATCH] mac80211: Fix Public Action frame RX in AP mode Jouni Malinen
2016-03-01 14:05 ` Arik Nemtsov
2016-03-01 14:45 ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456843521.3926.30.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=jouni@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.