From: Johannes Berg <johannes@sipsolutions.net>
To: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: check PN correctly for GCMP-encrypted fragmented MPDUs
Date: Tue, 01 Mar 2016 15:45:43 +0100 [thread overview]
Message-ID: <1456843543.3926.31.camel@sipsolutions.net> (raw)
In-Reply-To: <1456521407-19915-1-git-send-email-johannes@sipsolutions.net> (sfid-20160226_221658_536889_F86C99E6)
On Fri, 2016-02-26 at 22:16 +0100, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> Just like for CCMP we need to check that for GCMP the fragments
> have PNs that increment by one; the spec was updated to fix this
> security issue and now has the following text:
>
> The receiver shall discard MSDUs and MMPDUs whose constituent
> MPDU PN values are not incrementing in steps of 1.
>
> Adapt the code for CCMP to work for GCMP as well, luckily the
> relevant fields already alias each other so no code duplication
> is needed (just check the aliasing with BUILD_BUG_ON.)
>
Applied.
johannes
prev parent reply other threads:[~2016-03-01 14:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 21:16 [PATCH] mac80211: check PN correctly for GCMP-encrypted fragmented MPDUs Johannes Berg
2016-03-01 14:45 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456843543.3926.31.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.