From: Scott Wood <oss@buserror.net>
To: Alessio Igor Bogani <alessio.bogani@elettra.eu>
Cc: Kumar Gala <galak@kernel.crashing.org>,
linuxppc-dev@lists.ozlabs.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v1 2/2] powerpc/86xx: Introduce and use common dtsi
Date: Tue, 01 Mar 2016 08:57:20 -0600 [thread overview]
Message-ID: <1456844240.5360.65.camel@buserror.net> (raw)
In-Reply-To: <CAPk1OjG8hFAtJM1wLFcTHCD1Ld9fKuvcZgKpuDZ1=o-_RQGXOw@mail.gmail.com>
On Tue, 2016-03-01 at 15:55 +0100, Alessio Igor Bogani wrote:
> Scott,
>
> On 29 February 2016 at 23:38, Scott Wood <oss@buserror.net> wrote:
> [...]
> >
> > > +&pci0 {
> > > + compatible = "fsl,mpc8641-pcie";
> > > + device_type = "pci";
> > > + #size-cells = <2>;
> > > + #address-cells = <3>;
> > > + bus-range = <0x0 0xff>;
> > > + clock-frequency = <33333333>;
> >
> > The clock frequency of PCI Express is not 33 MHz.
>
> A lot of dtsi files into fsl directory have got that value!
Well, they shouldn't. :-P
This isn't the first time I've told someone to take that out.
-Scott
prev parent reply other threads:[~2016-03-01 14:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 10:57 [RFC PATCH v1 1/2] powerpc/86xx: Move dts files to fsl directory Alessio Igor Bogani
2016-02-25 10:57 ` [RFC PATCH v1 2/2] powerpc/86xx: Introduce and use common dtsi Alessio Igor Bogani
2016-02-29 10:33 ` Alessio Igor Bogani
2016-02-29 22:38 ` Scott Wood
2016-03-01 14:55 ` Alessio Igor Bogani
2016-03-01 14:57 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456844240.5360.65.camel@buserror.net \
--to=oss@buserror.net \
--cc=alessio.bogani@elettra.eu \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.