From: Joe Perches <joe@perches.com>
To: "Pottratz, Dwane" <dwane.pottratz@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH] checkpatch.pl: add switch to turn off check for Change-Id
Date: Tue, 01 Mar 2016 15:21:48 -0800 [thread overview]
Message-ID: <1456874508.4436.39.camel@perches.com> (raw)
In-Reply-To: <575E9C847DA64B429BF50A3C5F8CA3CCA3C3B13C@ORSMSX112.amr.corp.intel.com>
On Tue, 2016-03-01 at 21:49 +0000, Pottratz, Dwane wrote:
> Good to know. Thx.
Andrew picked this up, but it might be better to remove your
patch and just use the --ignore option as --ignore is generic
and your patch just duplicates the capability.
>
> -----Original Message-----
> From: Joe Perches [mailto:joe@perches.com]
> Sent: Tuesday, March 1, 2016 1:41 PM
> To: Pottratz, Dwane <dwane.pottratz@intel.com>; apw@canonical.com; li
> nux-kernel@vger.kernel.org; 'akpm@linux-foundation.org' <akpm@linux-f
> oundation.org>
> Subject: Re: [PATCH] checkpatch.pl: add switch to turn off check for
> Change-Id
>
> On Tue, 2016-03-01 at 18:37 +0000, Pottratz, Dwane wrote:
> >
> > A commit hook for the Gerrit code review servers inserts change
> > identifiers. These identifiers are noise in the context of the
> > upstream kernel. However, they are needed in most development
> > environments and the error needs to be ignored for static analysis
> > tools.
> btw: another way to do this is to use the --ignore <foo-list> option.
>
> $ ./scripts/checkpatch.pl --ignore gerrit_change_id <patch>
>
next prev parent reply other threads:[~2016-03-01 23:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 18:37 [PATCH] checkpatch.pl: add switch to turn off check for Change-Id Pottratz, Dwane
2016-03-01 21:41 ` Joe Perches
[not found] ` <575E9C847DA64B429BF50A3C5F8CA3CCA3C3B13C@ORSMSX112.amr.corp.intel.com>
2016-03-01 23:21 ` Joe Perches [this message]
2016-03-02 19:15 ` Pottratz, Dwane
2016-03-02 19:19 ` Joe Perches
[not found] <575E9C847DA64B429BF50A3C5F8CA3CCA3C3AD05@ORSMSX112.amr.corp.intel.com>
2016-03-01 18:31 ` Joe Perches
2016-03-01 18:38 ` Pottratz, Dwane
[not found] <1456247448-23968-1-git-send-email-dwane.pottratz@intel.com>
2016-03-01 16:49 ` Pottratz, Dwane
2016-03-01 17:45 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456874508.4436.39.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=dwane.pottratz@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.