From: David Turner <dturner@twopensource.com>
To: Jeff King <peff@peff.net>, git@vger.kernel.org
Cc: mhagger@alum.mit.edu, pclouds@gmail.com
Subject: Re: [PATCH 0/10] cleaning up check_repository_format_gently
Date: Tue, 01 Mar 2016 19:42:51 -0500 [thread overview]
Message-ID: <1456879371.5981.11.camel@twopensource.com> (raw)
In-Reply-To: <20160301143546.GA30806@sigill.intra.peff.net>
On Tue, 2016-03-01 at 09:35 -0500, Jeff King wrote:
> After the discussion in:
>
> http://thread.gmane.org/gmane.comp.version-control.git/287949/focus
> =288002
>
> I came up with this series to try to address some of the warts in
> check_repository_format_gently().
>
> I had hoped to come up with something very small that could go at the
> front of the refs-backend series, but as with any time I look at the
> setup code, it managed to snowball into a potpourri of hidden
> assumptions.
>
> So I hope David isn't _too_ irritated to see this in his inbox.
I commented on two of the patches; the rest look good to me.
I rebased on these (minus the repo_version_string change from 10/10). Wasn't too bad. And it did clean up the submodule check.
I will wait to resend my series until I hear back about your shortlog/mailmap fix and your suggestion on a better archive --remote fix.
prev parent reply other threads:[~2016-03-02 0:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 14:35 [PATCH 0/10] cleaning up check_repository_format_gently Jeff King
2016-03-01 14:37 ` [PATCH 01/10] setup: document check_repository_format() Jeff King
2016-03-01 14:38 ` [PATCH 02/10] wrap shared_repository global in get/set accessors Jeff King
2016-03-01 14:39 ` [PATCH 03/10] lazily load core.sharedrepository Jeff King
2016-03-03 13:00 ` Duy Nguyen
2016-03-03 18:23 ` Jeff King
2016-03-01 14:40 ` [PATCH 04/10] check_repository_format_gently: stop using git_config_early Jeff King
2016-03-03 13:08 ` Duy Nguyen
2016-03-03 18:27 ` Jeff King
2016-03-01 14:40 ` [PATCH 05/10] config: drop git_config_early Jeff King
2016-03-01 14:42 ` [PATCH 06/10] setup: refactor repo format reading and verification Jeff King
2016-03-01 21:20 ` David Turner
2016-03-02 2:51 ` Jeff King
2016-03-03 13:19 ` Duy Nguyen
2016-03-03 18:28 ` Jeff King
2016-03-01 14:43 ` [PATCH 07/10] init: use setup.c's repo version verification Jeff King
2016-03-01 14:45 ` [PATCH 08/10] setup: unify repository version callbacks Jeff King
2016-03-01 14:45 ` [PATCH 09/10] setup: drop repository_format_version global Jeff King
2016-03-01 14:45 ` [PATCH 10/10] setup: drop GIT_REPO_VERSION constants Jeff King
2016-03-02 0:13 ` David Turner
2016-03-02 2:52 ` Jeff King
2016-03-02 0:42 ` David Turner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456879371.5981.11.camel@twopensource.com \
--to=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.