All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: aicasm: fix kbuild for separated build directories
Date: Wed, 02 Mar 2016 08:17:23 -0800	[thread overview]
Message-ID: <1456935443.2406.31.camel@HansenPartnership.com> (raw)
In-Reply-To: <20160217234604.GA16500@pobox.suse.cz>

On Thu, 2016-02-18 at 00:46 +0100, Michal Marek wrote:
> On Fri, Feb 12, 2016 at 02:42:26PM -0800, James Bottomley wrote:
> > I've recently been experimenting with building in emulated 
> > architecture containers which allow me to build natively on my 
> > laptop a kernel for any architecture which qemu will emulate.  To 
> > do this, I've been building into build/$(uname -m) and this caused 
> > the aicasm stuff to fail to build (using CONFIG_AIC7XXX_BUILD_FIRMW
> > ARE=y).  I think this patch corrects the problem, but I'm not 
> > hugely familiar with the kbuild infrastructure so I cc'd an expert
> > for a second opinion.
> 
> Hi James,
> 
> Sorry for the late reply. Letting kbuild handle the aicasm directory 
> is a step in the right direction. However, it still failed for me and
> instead of trying to understand how the rules work, I removed them 
> and used the existing kbuild infrastructure. Please try the patch 
> below on top of yours.

Sorry for the late testing.  This patch causes the build to fail again
for me:

make[5]: *** No rule to make target
'drivers/scsi/aic7xxx/aicasm/aicasm_scan.lex.c', needed by
'drivers/scsi/aic7xxx/aicasm/aicasm_scan.lex.o'.  Stop.
/home/jejb/git/scsi-misc/drivers/scsi/aic7xxx/Makefile:85: recipe for
target 'drivers/scsi/aic7xxx/aicasm/aicasm' failed
make[4]: *** [drivers/scsi/aic7xxx/aicasm/aicasm] Error 2
/home/jejb/git/scsi-misc/scripts/Makefile.build:407: recipe for target
'drivers/scsi/aic7xxx' failed
make[3]: *** [drivers/scsi/aic7xxx] Error 2
make[3]: *** Waiting for unfinished jobs....
/home/jejb/git/scsi-misc/scripts/Makefile.build:407: recipe for target
'drivers/scsi' failed

I think the problem is simply that we now have two separate options for
building the firmware: REGENERATE_PARSERS and
 CONFIG_AIC7XXX_BUILD_FIRMWARE and the latter needs to be eliminated. 
 I'll see if I can work out what's missing.

James


  parent reply	other threads:[~2016-03-02 16:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-12 22:42 aicasm: fix kbuild for separated build directories James Bottomley
2016-02-17 23:46 ` Michal Marek
2016-02-24  1:54   ` Martin K. Petersen
2016-03-02 16:17   ` James Bottomley [this message]
2016-03-02 16:25     ` Michal Marek
2016-03-02 19:11       ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456935443.2406.31.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mmarek@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.