All of lore.kernel.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	David Weinehall <david.weinehall@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t v4] tests/pm_rpm: Fix CRASH on machines that lack LLC
Date: Wed, 02 Mar 2016 19:32:42 +0200	[thread overview]
Message-ID: <1456939962.16838.32.camel@intel.com> (raw)
In-Reply-To: <20160302172024.GN30782@nuc-i3427.alporthouse.com>

On ke, 2016-03-02 at 17:20 +0000, Chris Wilson wrote:
> On Wed, Mar 02, 2016 at 07:01:28PM +0200, David Weinehall wrote:
> > On machines that lack an LLC the pm-caching subtest will
> > terminate with sigbus and thus CRASH during the
> > I915_CACHING_CACHED iteration. To work around this we reset
> > the caching to I915_CACHING_NONE before doing memory access.
> > 
> > v2: Various improvements based on feedback from Chris Wilson
> > 
> > v3: Fix incorrect Signed-off-by: line
> > 
> > v4: Further improvements based on feedback from Chris Wilson
> > 
> > Signed-off-by: David Weinehall <david.weinehall@linux.intel.com>
> 
> Looks good to me, I'll let Imre double check if I haven't broke
> something subtle in the test setup.

It looks ok to me, so:
Reviewed-by: Imre Deak <imre.deak@intel.com>

> -Chris
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      reply	other threads:[~2016-03-02 17:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-02 13:11 [PATCH i-g-t] tests/pm_rpm: Fix CRASH on machines that lack LLC David Weinehall
2016-03-02 13:27 ` Chris Wilson
2016-03-02 13:55   ` David Weinehall
2016-03-02 14:04     ` Chris Wilson
2016-03-02 14:32       ` Imre Deak
2016-03-02 14:37         ` Chris Wilson
2016-03-02 14:41           ` Imre Deak
2016-03-02 14:49             ` Chris Wilson
2016-03-02 15:01               ` Imre Deak
2016-03-02 15:28                 ` Chris Wilson
2016-03-02 16:23                   ` Imre Deak
2016-03-02 14:38       ` David Weinehall
2016-03-02 15:50 ` [PATCH i-g-t v2] " David Weinehall
2016-03-02 16:06   ` Chris Wilson
2016-03-02 16:02 ` [PATCH i-g-t v3] " David Weinehall
2016-03-02 17:01 ` [PATCH i-g-t v4] " David Weinehall
2016-03-02 17:20   ` Chris Wilson
2016-03-02 17:32     ` Imre Deak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456939962.16838.32.camel@intel.com \
    --to=imre.deak@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=david.weinehall@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.