All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@linux.intel.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Jin Qian <jinqian@android.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Greg Hackmann <ghackmann@google.com>,
	Miodrag Dinic <miodrag.dinic@imgtec.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] goldfish: Fix build error of missing ioremap on UM
Date: Fri, 04 Mar 2016 15:48:50 +0000	[thread overview]
Message-ID: <1457106530.7064.52.camel@linux.intel.com> (raw)
In-Reply-To: <1456992829-23300-1-git-send-email-k.kozlowski@samsung.com>

On Thu, 2016-03-03 at 17:13 +0900, Krzysztof Kozlowski wrote:
> Add missing HAS_IOMEM dependency to fix the allyesconfig build error
> on
> ARCH=um (for x86_64):
> 
> drivers/platform/goldfish/pdev_bus.c: In function
> ‘goldfish_pdev_bus_probe’:
> drivers/platform/goldfish/pdev_bus.c:191:18: error: implicit
> declaration of function ‘ioremap’ [-Werror=implicit-function
> -declaration]
>   pdev_bus_base = ioremap(pdev_bus_addr, pdev_bus_len);
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Reviewed-by: Alan Cox <alan@linux.intel.com>

Thanks for that - I was trying to work out where that weird 0day
complaint was coming from.

Alan

      reply	other threads:[~2016-03-04 15:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-03  8:13 [PATCH] goldfish: Fix build error of missing ioremap on UM Krzysztof Kozlowski
2016-03-04 15:48 ` Alan Cox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1457106530.7064.52.camel@linux.intel.com \
    --to=alan@linux.intel.com \
    --cc=ghackmann@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jinqian@android.com \
    --cc=k.kozlowski@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miodrag.dinic@imgtec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.