From: Imre Deak <imre.deak@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Jani Nikula <jani.nikula@intel.com>,
intel-gfx@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm/i915/csr: Allow matching unknown HW steppings with generic firmware
Date: Mon, 07 Mar 2016 17:56:15 +0200 [thread overview]
Message-ID: <1457366175.26928.52.camel@intel.com> (raw)
In-Reply-To: <20160307133938.GA1405@nuc-i3427.alporthouse.com>
On ma, 2016-03-07 at 13:39 +0000, Chris Wilson wrote:
> On Mon, Mar 07, 2016 at 03:12:40PM +0200, Imre Deak wrote:
> > On ma, 2016-03-07 at 12:05 +0000, Chris Wilson wrote:
> > > If the firmware is generic and has a run-anywhere mode, enable it
> > > rather
> > > than completely failing on unknown HW revisions.
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Damien Lespiau <damien.lespiau@intel.com>
> > > Cc: Imre Deak <imre.deak@intel.com>
> > > Cc: Sunil Kamath <sunil.kamath@intel.com>
> > > Cc: Daniel Vetter <daniel.vetter@intel.com>
> > > Cc: Animesh Manna <animesh.manna@intel.com>
> > > Cc: Jani Nikula <jani.nikula@intel.com>
> >
> > Looks ok:
> > Reviewed-by: Imre Deak <imre.deak@intel.com>
> >
> > > ---
> > > This is probably stable@ material since it could allow future hw
> > > to
> > > just work.
> >
> > Existing platforms will select the generic firmware version already if
> > one is provided in the image, this change will just allow us not to
> > provide a stepping info table for new platforms. So not sure why it's
> > @stable material.
>
> Because we are already hitting the scenario where there are new
> platforms that do not match the hardcoded set of steppings and error out
> i.e. we have failed to futureproof the code.
Ok, I missed the part that this also fixes the fw version selection for
existing platforms with a new stepping. So yes, agreed we need this for
@stable.
--Imre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-03-07 15:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 12:05 [PATCH] drm/i915/csr: Allow matching unknown HW steppings with generic firmware Chris Wilson
2016-03-07 13:12 ` Imre Deak
2016-03-07 13:39 ` Chris Wilson
2016-03-07 15:56 ` Imre Deak [this message]
2016-03-07 16:24 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-03-16 15:45 ` Imre Deak
2016-03-16 16:05 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457366175.26928.52.camel@intel.com \
--to=imre.deak@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.