From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lisheng011 <lisheng011@huawei.com>, davem@davemloft.net
Cc: yisen.zhuang@huawei.com, yankejian@huawei.com,
xieqianqian@huawei.com, huangdaode@hisilicon.com,
salil.mehta@huawei.com, netdev@vger.kernel.org,
haifeng.wei@huawei.com, charles.chenxin@huawei.com,
linuxarm@huawei.com
Subject: Re: [PATCH net 4/4] net: hns: remove useless head=ring->next_to_clean
Date: Tue, 08 Mar 2016 10:12:34 +0200 [thread overview]
Message-ID: <1457424754.1347.10.camel@linux.intel.com> (raw)
In-Reply-To: <56DE86FC.8000408@huawei.com>
On Tue, 2016-03-08 at 16:02 +0800, Lisheng011 wrote:
>
> 在 2016/3/8 15:18, Andy Shevchenko 写道:
> >
> > On Tue, 2016-03-08 at 11:52 +0800, Lisheng wrote:
> > >
> > > From: Qianqian Xie <xieqianqian@huawei.com>
> > >
> > > The variable head in hns_nic_tx_fini_pro has read a value,
> > > but the value is not used. The patch will solve it.
> - /* for hardware bug fixed */
> > This is not good. Explanation is needed why you removed this
> > comment.
> This bug-fixed comment is for the function pointer
> ring_data->fini_process,that is called in function
> hns_nic_common_poll.
> The comment should not be here, so remove it.
Please, add above paragraph to the commit message.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
prev parent reply other threads:[~2016-03-08 8:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 3:52 [PATCH net 0/4] net: hns: bugs fix about hns driver Lisheng
2016-03-08 3:52 ` [PATCH net 1/4] net: hns: fix a bug for cycle index Lisheng
2016-03-08 3:52 ` [PATCH net 2/4] net: hns: bug fix for format string Lisheng
2016-03-08 3:52 ` [PATCH net 3/4] net: hns: bug fix for return values Lisheng
2016-03-08 3:52 ` [PATCH net 4/4] net: hns: remove useless head=ring->next_to_clean Lisheng
2016-03-08 7:18 ` Andy Shevchenko
2016-03-08 8:02 ` Lisheng011
2016-03-08 8:12 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457424754.1347.10.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=charles.chenxin@huawei.com \
--cc=davem@davemloft.net \
--cc=haifeng.wei@huawei.com \
--cc=huangdaode@hisilicon.com \
--cc=linuxarm@huawei.com \
--cc=lisheng011@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=xieqianqian@huawei.com \
--cc=yankejian@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.