Re: [PATCH v2] bb/fetch2: fixes copying of file://dir; subdir=foo, bug 6128 and bug 6129

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2016-03-09 at 18:54 +0200, Sasha Shashkevich wrote:
> > On Mar 9, 2016, at 18:15, Alexander Shashkevich <alex@stunpix.com>
> > wrote:
> > 
> > When in SRC_URI appears file://dir;subdir=foo unpacker copies 'dir'
> > to ${WORKDIR}, not
> > ${WORKDIR}/foo as it should be.
> > 
> > These changes are fixing following bugs as well:
> > Bug 6128 - Incorrect wildcard unpack behaviour in fetcher
> > Bug 6129 - Local directories unpack to a different location than
> > local files
> > 
> > Signed-off-by: Alexander Shashkevich <alex@stunpix.com>
> > --
> 
> Changes were tested on 1.8 and 2.0 branches for core-image-sato and
> meta-sdk images.
> 
> Additional changes since last sent patch:
> 
>  - New test cases were added to cover absolute paths in SRC_URI for
> local files.
>  - Fixed recipe nativesdk-qemu-helper_1.0.bb: it was based on
> incorrect copying behavior which had been changed by this patch.
> 
> Please review my changes.

Could you have a look at master please? I already took one of your
earlier patches which I followed with a changes to correctly handle
absolute paths:

http://git.yoctoproject.org/cgit.cgi/poky/commit/bitbake/lib?id=2a73181
33bbd64f5dcb2ddf400229d4627925580

I wasn't convinced the behaviour in the qemu-helper recipe was
incorrect. If you still believe it is, I'm happy to consider that.

I'm also very interested in getting some updated test cases in.

Cheers,

Richard