From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Verma, Vishal L" Subject: Re: [PATCH 1/3] nfit, libnvdimm: clear poison command support Date: Wed, 9 Mar 2016 23:03:59 +0000 Message-ID: <1457564634.4525.32.camel@intel.com> References: <20160308224713.16298.33547.stgit@dwillia2-desk3.jf.intel.com> <20160308224718.16298.47066.stgit@dwillia2-desk3.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com ([134.134.136.20]:43209 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752167AbcCIXEP (ORCPT ); Wed, 9 Mar 2016 18:04:15 -0500 In-Reply-To: <20160308224718.16298.47066.stgit@dwillia2-desk3.jf.intel.com> Content-Language: en-US Content-ID: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Williams, Dan J" , "linux-nvdimm@lists.01.org" Cc: "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" T24gVHVlLCAyMDE2LTAzLTA4IGF0IDE0OjQ3IC0wODAwLCBEYW4gV2lsbGlhbXMgd3JvdGU6DQo+ IEFkZCB0aGUgYm9pbGVyLXBsYXRlIGZvciBhICdjbGVhciBlcnJvcicgY29tbWFuZCBiYXNlZCBv biBzZWN0aW9uDQo+IDkuMjAuNy42ICJGdW5jdGlvbiBJbmRleCA0IC0gQ2xlYXIgVW5jb3JyZWN0 YWJsZSBFcnJvciIgZnJvbSB0aGUgQUNQSQ0KPiA2LjEgc3BlY2lmaWNhdGlvbiwgYW5kIGFkZCBh IHJlZmVyZW5jZSBpbXBsZW1lbnRhdGlvbiBpbiBuZml0X3Rlc3QuDQo+IA0KPiBDYzogVmlzaGFs IFZlcm1hIDx2aXNoYWwubC52ZXJtYUBpbnRlbC5jb20+DQo+IFNpZ25lZC1vZmYtYnk6IERhbiBX aWxsaWFtcyA8ZGFuLmoud2lsbGlhbXNAaW50ZWwuY29tPg0KPiAtLS0NCj4gwqBkcml2ZXJzL2Fj cGkvbmZpdC5jwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHzCoMKgwqAxMiArKysrKysrKysr Ky0NCj4gwqBkcml2ZXJzL252ZGltbS9idXMuY8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgfMKg wqDCoDE5ICsrKysrKysrKysrKysrKysrKysNCj4gwqBpbmNsdWRlL3VhcGkvbGludXgvbmRjdGwu aMKgwqDCoMKgwqDCoMKgfMKgwqDCoDEzICsrKysrKysrKysrKysNCj4gwqB0b29scy90ZXN0aW5n L252ZGltbS90ZXN0L25maXQuYyB8wqDCoMKgMjkgKysrKysrKysrKysrKysrKysrKysrKysrKysr KysNCj4gwqA0IGZpbGVzIGNoYW5nZWQsIDcyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkN Cj4gDQoNCjxzbmlwPg0KDQo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL3VhcGkvbGludXgvbmRjdGwu aCBiL2luY2x1ZGUvdWFwaS9saW51eC9uZGN0bC5oDQo+IGluZGV4IGNjNjhiOTIxMjRkNC4uMGYw MDFjNTcxY2RkIDEwMDY0NA0KPiAtLS0gYS9pbmNsdWRlL3VhcGkvbGludXgvbmRjdGwuaA0KPiAr KysgYi9pbmNsdWRlL3VhcGkvbGludXgvbmRjdGwuaA0KPiBAQCAtOTgsNiArOTgsMTQgQEAgc3Ry dWN0IG5kX2NtZF9hcnNfc3RhdHVzIHsNCj4gwqAJfSBfX3BhY2tlZCByZWNvcmRzWzBdOw0KPiDC oH0gX19wYWNrZWQ7DQo+IMKgDQo+ICtzdHJ1Y3QgbmRfY21kX2NsZWFyX2Vycm9yIHsNCj4gKwlf X3U2NCBhZGRyZXNzOw0KPiArCV9fdTY0IGxlbmd0aDsNCj4gKwlfX3UzMiBzdGF0dXM7DQo+ICsJ X191OCByZXNlcnZlZFs0XTsNCj4gKwlfX3U2NCBjbGVhcmVkOw0KPiArfSBfX3BhY2tlZDsNCj4g Kw0KPiDCoGVudW0gew0KPiDCoAlORF9DTURfSU1QTEVNRU5URUQgPSAwLA0KPiDCoA0KPiBAQCAt MTA1LDYgKzExMyw3IEBAIGVudW0gew0KPiDCoAlORF9DTURfQVJTX0NBUCA9IDEsDQo+IMKgCU5E X0NNRF9BUlNfU1RBUlQgPSAyLA0KPiDCoAlORF9DTURfQVJTX1NUQVRVUyA9IDMsDQo+ICsJTkRf Q01EX0NMRUFSX0VSUk9SID0gNCwNCj4gwqANCj4gwqAJLyogcGVyLWRpbW0gY29tbWFuZHMgKi8N Cj4gwqAJTkRfQ01EX1NNQVJUID0gMSwNCj4gQEAgLTEyOSw2ICsxMzgsNyBAQCBzdGF0aWMgaW5s aW5lIGNvbnN0IGNoYXINCj4gKm52ZGltbV9idXNfY21kX25hbWUodW5zaWduZWQgY21kKQ0KPiDC oAkJW05EX0NNRF9BUlNfQ0FQXSA9ICJhcnNfY2FwIiwNCj4gwqAJCVtORF9DTURfQVJTX1NUQVJU XSA9ICJhcnNfc3RhcnQiLA0KPiDCoAkJW05EX0NNRF9BUlNfU1RBVFVTXSA9ICJhcnNfc3RhdHVz IiwNCj4gKwkJW05EX0NNRF9DTEVBUl9FUlJPUl0gPSAiY2xlYXJfZXJyb3IiLA0KPiDCoAl9Ow0K PiDCoA0KPiDCoAlpZiAoY21kIDwgQVJSQVlfU0laRShuYW1lcykgJiYgbmFtZXNbY21kXSkNCj4g QEAgLTE4Nyw2ICsxOTcsOSBAQCBzdGF0aWMgaW5saW5lIGNvbnN0IGNoYXIgKm52ZGltbV9jbWRf bmFtZSh1bnNpZ25lZA0KPiBjbWQpDQo+IMKgI2RlZmluZSBORF9JT0NUTF9BUlNfU1RBVFVTCQlf SU9XUihORF9JT0NUTCwNCj4gTkRfQ01EX0FSU19TVEFUVVMsXA0KPiDCoAkJCQkJc3RydWN0IG5k X2NtZF9hcnNfc3RhdHVzKQ0KPiDCoA0KPiArI2RlZmluZSBORF9JT0NUTF9DTEVBUl9FUlJPUgkJ X0lPV1IoTkRfSU9DVEwsDQo+IE5EX0NNRF9DTEVBUl9FUlJPUixcDQo+ICsJCQkJCXN0cnVjdCBu ZF9jbWRfYXJzX3N0YXR1cykNCj4gKw0KDQpUeXBvIGhlcmU/IFNob3VsZCBiZSBzdHJ1Y3TCoG5k X2NtZF9jbGVhcl9lcnJvci4NCg0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by ml01.01.org (Postfix) with ESMTP id C59821A1EDB for ; Wed, 9 Mar 2016 15:04:18 -0800 (PST) From: "Verma, Vishal L" Subject: Re: [PATCH 1/3] nfit, libnvdimm: clear poison command support Date: Wed, 9 Mar 2016 23:03:59 +0000 Message-ID: <1457564634.4525.32.camel@intel.com> References: <20160308224713.16298.33547.stgit@dwillia2-desk3.jf.intel.com> <20160308224718.16298.47066.stgit@dwillia2-desk3.jf.intel.com> In-Reply-To: <20160308224718.16298.47066.stgit@dwillia2-desk3.jf.intel.com> Content-Language: en-US Content-ID: MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Williams, Dan J" , "linux-nvdimm@lists.01.org" Cc: "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-ID: T24gVHVlLCAyMDE2LTAzLTA4IGF0IDE0OjQ3IC0wODAwLCBEYW4gV2lsbGlhbXMgd3JvdGU6DQo+ IEFkZCB0aGUgYm9pbGVyLXBsYXRlIGZvciBhICdjbGVhciBlcnJvcicgY29tbWFuZCBiYXNlZCBv biBzZWN0aW9uDQo+IDkuMjAuNy42ICJGdW5jdGlvbiBJbmRleCA0IC0gQ2xlYXIgVW5jb3JyZWN0 YWJsZSBFcnJvciIgZnJvbSB0aGUgQUNQSQ0KPiA2LjEgc3BlY2lmaWNhdGlvbiwgYW5kIGFkZCBh IHJlZmVyZW5jZSBpbXBsZW1lbnRhdGlvbiBpbiBuZml0X3Rlc3QuDQo+IA0KPiBDYzogVmlzaGFs IFZlcm1hIDx2aXNoYWwubC52ZXJtYUBpbnRlbC5jb20+DQo+IFNpZ25lZC1vZmYtYnk6IERhbiBX aWxsaWFtcyA8ZGFuLmoud2lsbGlhbXNAaW50ZWwuY29tPg0KPiAtLS0NCj4gwqBkcml2ZXJzL2Fj cGkvbmZpdC5jwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHzCoMKgwqAxMiArKysrKysrKysr Ky0NCj4gwqBkcml2ZXJzL252ZGltbS9idXMuY8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgfMKg wqDCoDE5ICsrKysrKysrKysrKysrKysrKysNCj4gwqBpbmNsdWRlL3VhcGkvbGludXgvbmRjdGwu aMKgwqDCoMKgwqDCoMKgfMKgwqDCoDEzICsrKysrKysrKysrKysNCj4gwqB0b29scy90ZXN0aW5n L252ZGltbS90ZXN0L25maXQuYyB8wqDCoMKgMjkgKysrKysrKysrKysrKysrKysrKysrKysrKysr KysNCj4gwqA0IGZpbGVzIGNoYW5nZWQsIDcyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkN Cj4gDQoNCjxzbmlwPg0KDQo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL3VhcGkvbGludXgvbmRjdGwu aCBiL2luY2x1ZGUvdWFwaS9saW51eC9uZGN0bC5oDQo+IGluZGV4IGNjNjhiOTIxMjRkNC4uMGYw MDFjNTcxY2RkIDEwMDY0NA0KPiAtLS0gYS9pbmNsdWRlL3VhcGkvbGludXgvbmRjdGwuaA0KPiAr KysgYi9pbmNsdWRlL3VhcGkvbGludXgvbmRjdGwuaA0KPiBAQCAtOTgsNiArOTgsMTQgQEAgc3Ry dWN0IG5kX2NtZF9hcnNfc3RhdHVzIHsNCj4gwqAJfSBfX3BhY2tlZCByZWNvcmRzWzBdOw0KPiDC oH0gX19wYWNrZWQ7DQo+IMKgDQo+ICtzdHJ1Y3QgbmRfY21kX2NsZWFyX2Vycm9yIHsNCj4gKwlf X3U2NCBhZGRyZXNzOw0KPiArCV9fdTY0IGxlbmd0aDsNCj4gKwlfX3UzMiBzdGF0dXM7DQo+ICsJ X191OCByZXNlcnZlZFs0XTsNCj4gKwlfX3U2NCBjbGVhcmVkOw0KPiArfSBfX3BhY2tlZDsNCj4g Kw0KPiDCoGVudW0gew0KPiDCoAlORF9DTURfSU1QTEVNRU5URUQgPSAwLA0KPiDCoA0KPiBAQCAt MTA1LDYgKzExMyw3IEBAIGVudW0gew0KPiDCoAlORF9DTURfQVJTX0NBUCA9IDEsDQo+IMKgCU5E X0NNRF9BUlNfU1RBUlQgPSAyLA0KPiDCoAlORF9DTURfQVJTX1NUQVRVUyA9IDMsDQo+ICsJTkRf Q01EX0NMRUFSX0VSUk9SID0gNCwNCj4gwqANCj4gwqAJLyogcGVyLWRpbW0gY29tbWFuZHMgKi8N Cj4gwqAJTkRfQ01EX1NNQVJUID0gMSwNCj4gQEAgLTEyOSw2ICsxMzgsNyBAQCBzdGF0aWMgaW5s aW5lIGNvbnN0IGNoYXINCj4gKm52ZGltbV9idXNfY21kX25hbWUodW5zaWduZWQgY21kKQ0KPiDC oAkJW05EX0NNRF9BUlNfQ0FQXSA9ICJhcnNfY2FwIiwNCj4gwqAJCVtORF9DTURfQVJTX1NUQVJU XSA9ICJhcnNfc3RhcnQiLA0KPiDCoAkJW05EX0NNRF9BUlNfU1RBVFVTXSA9ICJhcnNfc3RhdHVz IiwNCj4gKwkJW05EX0NNRF9DTEVBUl9FUlJPUl0gPSAiY2xlYXJfZXJyb3IiLA0KPiDCoAl9Ow0K PiDCoA0KPiDCoAlpZiAoY21kIDwgQVJSQVlfU0laRShuYW1lcykgJiYgbmFtZXNbY21kXSkNCj4g QEAgLTE4Nyw2ICsxOTcsOSBAQCBzdGF0aWMgaW5saW5lIGNvbnN0IGNoYXIgKm52ZGltbV9jbWRf bmFtZSh1bnNpZ25lZA0KPiBjbWQpDQo+IMKgI2RlZmluZSBORF9JT0NUTF9BUlNfU1RBVFVTCQlf SU9XUihORF9JT0NUTCwNCj4gTkRfQ01EX0FSU19TVEFUVVMsXA0KPiDCoAkJCQkJc3RydWN0IG5k X2NtZF9hcnNfc3RhdHVzKQ0KPiDCoA0KPiArI2RlZmluZSBORF9JT0NUTF9DTEVBUl9FUlJPUgkJ X0lPV1IoTkRfSU9DVEwsDQo+IE5EX0NNRF9DTEVBUl9FUlJPUixcDQo+ICsJCQkJCXN0cnVjdCBu ZF9jbWRfYXJzX3N0YXR1cykNCj4gKw0KDQpUeXBvIGhlcmU/IFNob3VsZCBiZSBzdHJ1Y3TCoG5k X2NtZF9jbGVhcl9lcnJvci4NCg0KDQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpMaW51eC1udmRpbW0gbWFpbGluZyBsaXN0CkxpbnV4LW52ZGltbUBsaXN0 cy4wMS5vcmcKaHR0cHM6Ly9saXN0cy4wMS5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1udmRp bW0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754280AbcCIXER (ORCPT ); Wed, 9 Mar 2016 18:04:17 -0500 Received: from mga02.intel.com ([134.134.136.20]:43209 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752167AbcCIXEP (ORCPT ); Wed, 9 Mar 2016 18:04:15 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,313,1455004800"; d="scan'208";a="930514860" From: "Verma, Vishal L" To: "Williams, Dan J" , "linux-nvdimm@lists.01.org" CC: "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" Subject: Re: [PATCH 1/3] nfit, libnvdimm: clear poison command support Thread-Topic: [PATCH 1/3] nfit, libnvdimm: clear poison command support Thread-Index: AQHReYyU42iSgLdqSEuG472fWq2ntJ9SQuoA Date: Wed, 9 Mar 2016 23:03:59 +0000 Message-ID: <1457564634.4525.32.camel@intel.com> References: <20160308224713.16298.33547.stgit@dwillia2-desk3.jf.intel.com> <20160308224718.16298.47066.stgit@dwillia2-desk3.jf.intel.com> In-Reply-To: <20160308224718.16298.47066.stgit@dwillia2-desk3.jf.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.232.112.171] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u29N4Oa4003844 On Tue, 2016-03-08 at 14:47 -0800, Dan Williams wrote: > Add the boiler-plate for a 'clear error' command based on section > 9.20.7.6 "Function Index 4 - Clear Uncorrectable Error" from the ACPI > 6.1 specification, and add a reference implementation in nfit_test. > > Cc: Vishal Verma > Signed-off-by: Dan Williams > --- >  drivers/acpi/nfit.c              |   12 +++++++++++- >  drivers/nvdimm/bus.c             |   19 +++++++++++++++++++ >  include/uapi/linux/ndctl.h       |   13 +++++++++++++ >  tools/testing/nvdimm/test/nfit.c |   29 +++++++++++++++++++++++++++++ >  4 files changed, 72 insertions(+), 1 deletion(-) > > diff --git a/include/uapi/linux/ndctl.h b/include/uapi/linux/ndctl.h > index cc68b92124d4..0f001c571cdd 100644 > --- a/include/uapi/linux/ndctl.h > +++ b/include/uapi/linux/ndctl.h > @@ -98,6 +98,14 @@ struct nd_cmd_ars_status { >   } __packed records[0]; >  } __packed; >   > +struct nd_cmd_clear_error { > + __u64 address; > + __u64 length; > + __u32 status; > + __u8 reserved[4]; > + __u64 cleared; > +} __packed; > + >  enum { >   ND_CMD_IMPLEMENTED = 0, >   > @@ -105,6 +113,7 @@ enum { >   ND_CMD_ARS_CAP = 1, >   ND_CMD_ARS_START = 2, >   ND_CMD_ARS_STATUS = 3, > + ND_CMD_CLEAR_ERROR = 4, >   >   /* per-dimm commands */ >   ND_CMD_SMART = 1, > @@ -129,6 +138,7 @@ static inline const char > *nvdimm_bus_cmd_name(unsigned cmd) >   [ND_CMD_ARS_CAP] = "ars_cap", >   [ND_CMD_ARS_START] = "ars_start", >   [ND_CMD_ARS_STATUS] = "ars_status", > + [ND_CMD_CLEAR_ERROR] = "clear_error", >   }; >   >   if (cmd < ARRAY_SIZE(names) && names[cmd]) > @@ -187,6 +197,9 @@ static inline const char *nvdimm_cmd_name(unsigned > cmd) >  #define ND_IOCTL_ARS_STATUS _IOWR(ND_IOCTL, > ND_CMD_ARS_STATUS,\ >   struct nd_cmd_ars_status) >   > +#define ND_IOCTL_CLEAR_ERROR _IOWR(ND_IOCTL, > ND_CMD_CLEAR_ERROR,\ > + struct nd_cmd_ars_status) > + Typo here? Should be struct nd_cmd_clear_error.