From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Verma, Vishal L" Subject: Re: [PATCH 0/3] nfit, libnvdimm, pmem: clear poison support Date: Wed, 9 Mar 2016 23:05:03 +0000 Message-ID: <1457564698.4525.33.camel@intel.com> References: <20160308224713.16298.33547.stgit@dwillia2-desk3.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com ([192.55.52.120]:6475 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752693AbcCIXFF (ORCPT ); Wed, 9 Mar 2016 18:05:05 -0500 In-Reply-To: <20160308224713.16298.33547.stgit@dwillia2-desk3.jf.intel.com> Content-Language: en-US Content-ID: <61A8C159E16CCA4189856919446AA353@intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Williams, Dan J" , "linux-nvdimm@lists.01.org" Cc: "linux-kernel@vger.kernel.org" , "ross.zwisler@linux.intel.com" , "stable@vger.kernel.org" , "x86@kernel.org" , "linux-acpi@vger.kernel.org" T24gVHVlLCAyMDE2LTAzLTA4IGF0IDE0OjQ3IC0wODAwLCBEYW4gV2lsbGlhbXMgd3JvdGU6DQo+ IEFDUEkgNi4xIGludHJvZHVjZXMgdGhlIGFiaWxpdHkgdG8gc2VuZCAiY2xlYXIgZXJyb3IiIGNv bW1hbmRzIHRvIHRoZQ0KPiBBQ1BJMDAxMjowMCBkZXZpY2UgcmVwcmVzZW50aW5nIHRoZSByb290 IG9mIGFuICJudmRpbW0gYnVzIi4NCj4gDQo+IFNpbWlsYXIgdG8gcmVsb2NhdGluZyBhIGJhZCBi bG9jayBvbiBhIGRpc2ssIHRoaXMgc3VwcG9ydCBjbGVhcnMNCj4gbWVkaWEgZXJyb3JzIGluIHJl c3BvbnNlIHRvIGEgd3JpdGUuDQo+IA0KPiAtLS0NCj4gDQo+IERhbiBXaWxsaWFtcyAoMyk6DQo+ IMKgwqDCoMKgwqDCoG5maXQsIGxpYm52ZGltbTogY2xlYXIgcG9pc29uIGNvbW1hbmQgc3VwcG9y dA0KPiDCoMKgwqDCoMKgwqBsaWJudmRpbW0sIHBtZW06IGZpeCBrbWFwX2F0b21pYygpIGxlYWsg aW4gZXJyb3IgcGF0aA0KPiDCoMKgwqDCoMKgwqBsaWJudmRpbW0sIHBtZW06IGNsZWFyIHBvaXNv biBvbiB3cml0ZQ0KPiANCj4gDQo+IMKgYXJjaC94ODYvaW5jbHVkZS9hc20vcG1lbS5owqDCoMKg wqDCoMKgfMKgwqDCoMKgNSArKysNCj4gwqBkcml2ZXJzL2FjcGkvbmZpdC5jwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoHzCoMKgwqAxMiArKysrKystDQo+IMKgZHJpdmVycy9udmRpbW0vYnVz LmPCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHzCoMKgwqA2NQ0KPiArKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKw0KPiDCoGRyaXZlcnMvbnZkaW1tL25kLmjCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgfMKgwqDCoMKgMiArDQo+IMKgZHJpdmVycy9udmRpbW0vcG1lbS5j wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgfMKgwqDCoDQwICsrKysrKysrKysrKysrKysrKysrLS0t DQo+IMKgaW5jbHVkZS9saW51eC9wbWVtLmjCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHzCoMKg wqAxOSArKysrKysrKysrKw0KPiDCoGluY2x1ZGUvdWFwaS9saW51eC9uZGN0bC5owqDCoMKgwqDC oMKgwqB8wqDCoMKgMTMgKysrKysrKysNCj4gwqB0b29scy90ZXN0aW5nL252ZGltbS90ZXN0L25m aXQuYyB8wqDCoMKgMjkgKysrKysrKysrKysrKysrKysNCj4gwqA4IGZpbGVzIGNoYW5nZWQsIDE3 OSBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQ0KDQpFeGNlcHQgZm9yIHRoZSBvbmUgY29t bWVudCBpbiBwYXRjaCAxLCB0aGlzIGxvb2tzIGdvb2QgdG8gbWUhDQoNCkZvciB0aGUgc2VyaWVz LA0KUmV2aWV3ZWQtYnk6IFZpc2hhbCBWZXJtYSA8dmlzaGFsLmwudmVybWFAaW50ZWwuY29tPg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by ml01.01.org (Postfix) with ESMTP id 059E81A1E5E for ; Wed, 9 Mar 2016 15:05:19 -0800 (PST) From: "Verma, Vishal L" Subject: Re: [PATCH 0/3] nfit, libnvdimm, pmem: clear poison support Date: Wed, 9 Mar 2016 23:05:03 +0000 Message-ID: <1457564698.4525.33.camel@intel.com> References: <20160308224713.16298.33547.stgit@dwillia2-desk3.jf.intel.com> In-Reply-To: <20160308224713.16298.33547.stgit@dwillia2-desk3.jf.intel.com> Content-Language: en-US Content-ID: <61A8C159E16CCA4189856919446AA353@intel.com> MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Williams, Dan J" , "linux-nvdimm@lists.01.org" Cc: "linux-acpi@vger.kernel.org" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" List-ID: T24gVHVlLCAyMDE2LTAzLTA4IGF0IDE0OjQ3IC0wODAwLCBEYW4gV2lsbGlhbXMgd3JvdGU6DQo+ IEFDUEkgNi4xIGludHJvZHVjZXMgdGhlIGFiaWxpdHkgdG8gc2VuZCAiY2xlYXIgZXJyb3IiIGNv bW1hbmRzIHRvIHRoZQ0KPiBBQ1BJMDAxMjowMCBkZXZpY2UgcmVwcmVzZW50aW5nIHRoZSByb290 IG9mIGFuICJudmRpbW0gYnVzIi4NCj4gDQo+IFNpbWlsYXIgdG8gcmVsb2NhdGluZyBhIGJhZCBi bG9jayBvbiBhIGRpc2ssIHRoaXMgc3VwcG9ydCBjbGVhcnMNCj4gbWVkaWEgZXJyb3JzIGluIHJl c3BvbnNlIHRvIGEgd3JpdGUuDQo+IA0KPiAtLS0NCj4gDQo+IERhbiBXaWxsaWFtcyAoMyk6DQo+ IMKgwqDCoMKgwqDCoG5maXQsIGxpYm52ZGltbTogY2xlYXIgcG9pc29uIGNvbW1hbmQgc3VwcG9y dA0KPiDCoMKgwqDCoMKgwqBsaWJudmRpbW0sIHBtZW06IGZpeCBrbWFwX2F0b21pYygpIGxlYWsg aW4gZXJyb3IgcGF0aA0KPiDCoMKgwqDCoMKgwqBsaWJudmRpbW0sIHBtZW06IGNsZWFyIHBvaXNv biBvbiB3cml0ZQ0KPiANCj4gDQo+IMKgYXJjaC94ODYvaW5jbHVkZS9hc20vcG1lbS5owqDCoMKg wqDCoMKgfMKgwqDCoMKgNSArKysNCj4gwqBkcml2ZXJzL2FjcGkvbmZpdC5jwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoHzCoMKgwqAxMiArKysrKystDQo+IMKgZHJpdmVycy9udmRpbW0vYnVz LmPCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHzCoMKgwqA2NQ0KPiArKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKw0KPiDCoGRyaXZlcnMvbnZkaW1tL25kLmjCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgfMKgwqDCoMKgMiArDQo+IMKgZHJpdmVycy9udmRpbW0vcG1lbS5j wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgfMKgwqDCoDQwICsrKysrKysrKysrKysrKysrKysrLS0t DQo+IMKgaW5jbHVkZS9saW51eC9wbWVtLmjCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHzCoMKg wqAxOSArKysrKysrKysrKw0KPiDCoGluY2x1ZGUvdWFwaS9saW51eC9uZGN0bC5owqDCoMKgwqDC oMKgwqB8wqDCoMKgMTMgKysrKysrKysNCj4gwqB0b29scy90ZXN0aW5nL252ZGltbS90ZXN0L25m aXQuYyB8wqDCoMKgMjkgKysrKysrKysrKysrKysrKysNCj4gwqA4IGZpbGVzIGNoYW5nZWQsIDE3 OSBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQ0KDQpFeGNlcHQgZm9yIHRoZSBvbmUgY29t bWVudCBpbiBwYXRjaCAxLCB0aGlzIGxvb2tzIGdvb2QgdG8gbWUhDQoNCkZvciB0aGUgc2VyaWVz LA0KUmV2aWV3ZWQtYnk6IFZpc2hhbCBWZXJtYSA8dmlzaGFsLmwudmVybWFAaW50ZWwuY29tPgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1udmRp bW0gbWFpbGluZyBsaXN0CkxpbnV4LW52ZGltbUBsaXN0cy4wMS5vcmcKaHR0cHM6Ly9saXN0cy4w MS5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1udmRpbW0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934362AbcCIXFH (ORCPT ); Wed, 9 Mar 2016 18:05:07 -0500 Received: from mga04.intel.com ([192.55.52.120]:6475 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752693AbcCIXFF (ORCPT ); Wed, 9 Mar 2016 18:05:05 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,313,1455004800"; d="scan'208";a="920518772" From: "Verma, Vishal L" To: "Williams, Dan J" , "linux-nvdimm@lists.01.org" CC: "linux-kernel@vger.kernel.org" , "ross.zwisler@linux.intel.com" , "stable@vger.kernel.org" , "x86@kernel.org" , "linux-acpi@vger.kernel.org" Subject: Re: [PATCH 0/3] nfit, libnvdimm, pmem: clear poison support Thread-Topic: [PATCH 0/3] nfit, libnvdimm, pmem: clear poison support Thread-Index: AQHReYyHzyFVC+FrAkijyw7pgQVXH59SQzYA Date: Wed, 9 Mar 2016 23:05:03 +0000 Message-ID: <1457564698.4525.33.camel@intel.com> References: <20160308224713.16298.33547.stgit@dwillia2-desk3.jf.intel.com> In-Reply-To: <20160308224713.16298.33547.stgit@dwillia2-desk3.jf.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.232.112.171] Content-Type: text/plain; charset="utf-8" Content-ID: <61A8C159E16CCA4189856919446AA353@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u29N5CtW003853 On Tue, 2016-03-08 at 14:47 -0800, Dan Williams wrote: > ACPI 6.1 introduces the ability to send "clear error" commands to the > ACPI0012:00 device representing the root of an "nvdimm bus". > > Similar to relocating a bad block on a disk, this support clears > media errors in response to a write. > > --- > > Dan Williams (3): >       nfit, libnvdimm: clear poison command support >       libnvdimm, pmem: fix kmap_atomic() leak in error path >       libnvdimm, pmem: clear poison on write > > >  arch/x86/include/asm/pmem.h      |    5 +++ >  drivers/acpi/nfit.c              |   12 ++++++- >  drivers/nvdimm/bus.c             |   65 > ++++++++++++++++++++++++++++++++++++++ >  drivers/nvdimm/nd.h              |    2 + >  drivers/nvdimm/pmem.c            |   40 ++++++++++++++++++++--- >  include/linux/pmem.h             |   19 +++++++++++ >  include/uapi/linux/ndctl.h       |   13 ++++++++ >  tools/testing/nvdimm/test/nfit.c |   29 +++++++++++++++++ >  8 files changed, 179 insertions(+), 6 deletions(-) Except for the one comment in patch 1, this looks good to me! For the series, Reviewed-by: Vishal Verma