From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3 1/2] IOMMU/spinlock: Fix a bug found in AMD IOMMU initialization Date: Fri, 11 Mar 2016 16:55:53 +0100 Message-ID: <1457711753.3102.597.camel@citrix.com> References: <1457529455-38314-1-git-send-email-quan.xu@intel.com> <1457529455-38314-2-git-send-email-quan.xu@intel.com> <945CA011AD5F084CBEA3E851C0AB28894B861913@SHSMSX101.ccr.corp.intel.com> <1457692537.3102.563.camel@citrix.com> <945CA011AD5F084CBEA3E851C0AB28894B861C07@SHSMSX101.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7851903496874821202==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Meng Xu , "Xu, Quan" Cc: Suravee Suthikulpanit , Jan Beulich , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org --===============7851903496874821202== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-wJ35MjHr7Pr5+FD59rO3" --=-wJ35MjHr7Pr5+FD59rO3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 T24gRnJpLCAyMDE2LTAzLTExIGF0IDA5OjQ5IC0wNTAwLCBNZW5nIFh1IHdyb3RlOgo+ID4gWWVz Lgo+ID4gQ29uc2lzdGVuY3kgbWF5IGJlIGhlbHBmdWwgdG8gYXZvaWQgc29tZSBlYXN5LXRvLWF2 b2lkIGxvY2sgZXJyb3JzLgo+ID4gTW9yZW92ZXIsIHdpdGhvdXQgbXkgZml4LCBJIHRoaW5rIGl0 IHdvdWxkIG5vdCBsZWFkIGRlYWQgbG9jaywgYXMKPiA+IHRoZSBwY2lkZXZzX2xvY2sgaXMgbm90 IGJlaW5nIHRha2VuCj4gPiBJbiBJUlEgY29udGV4dC4gUmlnaHQ/Cj4gSSB0aGluayB3aXRob3V0 IHlvdXIgZml4LCB0aGUgZGVhZGxvY2sgbWF5IHN0aWxsIGhhcHBlbiBkdWUgdG8gdGhlCj4gcmVu ZGV6dm91cyBjb25kaXRpb24uCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoENQVSBBwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHzC oMKgwqDCoENQVSBCCj4gwqDCoMKgwqDCoHwgQ1BVIEMKPiBTdGVwIDF8IHNwaW5fbG9ja8KgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHwKPiBTdGVw IDJ8wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqB8Cj4gc3Bpbl9sb2NrX2lyccKgwqDCoMKg wqDCoMKgwqDCoMKgwqB8Cj4gU3RlcCAzfMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqB8 IHdhaXQgZm9yIEEgdG8KPiB1bmxvY2sgfAo+IFN0ZXAgNHwKPiDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgfCBzZW5kIHJlbmRlenZvdXMgSVBJIHRvIEEgYW5kIEIKPiBTdGVwIDV8IHJlY2Vp dmUgSVBJwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoHwgd2FpdCBmb3IgQSB0bwo+IHVubG9jayB8Cj4gU3RlcCA2fCB3YWl0IGZvciBCIHRv IGhhbmRsZSB0aGUgSVBJwqDCoMKgwqB8IHdhaXQgZm9yIEEgdG8gdW5sb2NrIHwKPiBTdGVwIDd8 IHNwaW5fdW5sb2NrCj4gCj4gCj4gRGVhZGxvY2sgb2NjdXJzIGF0IFN0ZXAgNiwgSU1PLgo+IAo+ IFVubGVzcyB3ZSBjYW4gcHJvdmUgdGhhdCByZW5kZXp2b3VzIHdvbid0IGhhcHBlbiB3aGlsZQo+ IHNwaW5fbG9ja19pcnFzYXZlIGlzIHRha2VuLCB3ZSBoYXZlIHRoZSBkZWFkbG9jayBoYXphcmQu Cj4gClllcy4gQnV0LCBpbiB0aGUgY2FzZSBvZiBRdWFuJ3MgcGF0Y2ggKHdpdGhvdXQgaXQsIEkg bWVhbiksIGhhdmUgeW91CnNlZW4gd2hlcmUgaW4gdGhlIGNvZGUgaXQgaXMgdGhhdCB3ZSB1c2Ug c3Bpbl9sb2NrX2lycXNhdmUoKT8KCkl0J3MgaW5zaWRlIGEgZnVuY3Rpb24gdGhhdCBpcyBjYWxs ZWQgZHVyaW5nIFhlbiBib290LCB3aG9zZSBjYWxsY2hhaW4Kc3RhcnRzIHdpdGggaW9tbXVfc2V0 dXAoKSwgZnJvbSBfX3N0YXJ0X3hlbigpLiBIZXJlJ3MgYSAoYmlnLCBzb3JyeSkKY29kZSBzbmlw cGV0IG9mIHdoYXQgaXMgYXJvdW5kIGlvbW11X3NldHVwKCk6CgrCoCDCoCAuLi4KwqDCoMKgwqBp bml0X2lkbGVfZG9tYWluKCk7CgrCoMKgwqDCoHRoaXNfY3B1KHN0dWJzLmFkZHIpID0gYWxsb2Nf c3R1Yl9wYWdlKHNtcF9wcm9jZXNzb3JfaWQoKSwKwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAmdGhpc19jcHUoc3R1YnMpLm1mbik7CsKgwqDCoMKgQlVHX09OKCF0aGlzX2NwdShzdHVicy5h ZGRyKSk7CgrCoMKgwqDCoHRyYXBfaW5pdCgpOwrCoMKgwqDCoHJjdV9pbml0KCk7CgrCoMKgwqDC oGVhcmx5X3RpbWVfaW5pdCgpOwoKwqDCoMKgwqBhcmNoX2luaXRfbWVtb3J5KCk7CgrCoMKgwqDC oGFsdGVybmF0aXZlX2luc3RydWN0aW9ucygpOwoKwqDCoMKgwqBsb2NhbF9pcnFfZW5hYmxlKCk7 CgrCoMKgwqDCoHB0X3BjaV9pbml0KCk7CgrCoMKgwqDCoHZlc2FfbXRycl9pbml0KCk7CgrCoMKg wqDCoGFjcGlfbW1jZmdfaW5pdCgpOwoKwqDCoMKgwqBlYXJseV9tc2lfaW5pdCgpOwoKwqDCoMKg wqBpb21tdV9zZXR1cCgpO8KgwqDCoMKgLyogc2V0dXAgaW9tbXUgaWYgYXZhaWxhYmxlICovCgrC oMKgwqDCoHNtcF9wcmVwYXJlX2NwdXMobWF4X2NwdXMpOwoKwqDCoMKgwqBzcGluX2RlYnVnX2Vu YWJsZSgpOwoKwqDCoMKgwqAvKgrCoMKgwqDCoMKgKiBJbml0aWFsaXNlIGhpZ2hlci1sZXZlbCB0 aW1lciBmdW5jdGlvbnMuIFdlIGRvIHRoaXMgZmFpcmx5IGxhdGUKwqDCoMKgwqDCoCogKGFmdGVy IGludGVycnVwdHMgZ290IGVuYWJsZWQpIGJlY2F1c2UgdGhlIHRpbWUgYmFzZXMgYW5kIHNjYWxl CsKgwqDCoMKgwqAqIGZhY3RvcnMgbmVlZCB0byBiZSB1cGRhdGVkIHJlZ3VsYXJseS4KwqDCoMKg wqDCoCovCsKgwqDCoMKgaW5pdF94ZW5fdGltZSgpOwrCoMKgwqDCoGluaXRpYWxpemVfa2V5dGFi bGUoKTsKwqDCoMKgwqBjb25zb2xlX2luaXRfcG9zdGlycSgpOwoKwqDCoMKgwqBzeXN0ZW1fc3Rh dGUgPSBTWVNfU1RBVEVfc21wX2Jvb3Q7CsKgwqDCoMKgZG9fcHJlc21wX2luaXRjYWxscygpOwrC oMKgwqDCoGZvcl9lYWNoX3ByZXNlbnRfY3B1ICggaSApCsKgwqDCoMKgewrCoMKgwqDCoMKgwqDC oMKgLyogU2V0IHVwIGNwdV90b19ub2RlW10uICovCsKgwqDCoMKgwqDCoMKgwqBzcmF0X2RldGVj dF9ub2RlKGkpOwrCoMKgwqDCoMKgwqDCoMKgLyogU2V0IHVwIG5vZGVfdG9fY3B1bWFzayBiYXNl ZCBvbiBjcHVfdG9fbm9kZVtdLiAqLwrCoMKgwqDCoMKgwqDCoMKgbnVtYV9hZGRfY3B1KGkpOwoK wqDCoMKgwqDCoMKgwqDCoGlmICggKG51bV9vbmxpbmVfY3B1cygpIDwgbWF4X2NwdXMpICYmICFj cHVfb25saW5lKGkpICkKwqDCoMKgwqDCoMKgwqDCoHsKwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg aW50IHJldCA9IGNwdV91cChpKTsKwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgaWYgKCByZXQgIT0g MCApCsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgcHJpbnRrKCJGYWlsZWQgdG8gYnJp bmcgdXAgQ1BVICV1IChlcnJvciAlZClcbiIsIGksIHJldCk7CsKgwqDCoMKgwqDCoMKgwqB9CsKg wqDCoMKgfQrCoMKgwqDCoHByaW50aygiQnJvdWdodCB1cCAlbGQgQ1BVc1xuIiwgKGxvbmcpbnVt X29ubGluZV9jcHVzKCkpOwogICAgLi4uCgpBcyB5b3UgY2FuIHNlZSwgaXQgaXMgb25seSAqYWZ0 ZXIqIGlvbW11X3NldHVwKCkgdGhhdCB3ZSBjYWxsIGZ1bmN0aW9ucwpsaWtlIHNtcF9wcmVwYXJl X2NwdXMoKSwgZG9fcHJlc21wX2luaXRjYWxscygpLCBhbmQgdGhlbiB0aGUgbG9vcCB0aGF0Cndh aXRzIGZvciBhbGwgdGhlIHByZXNlbnQgQ1BVcyB0byBjb21lIG9ubGluZS4KCldoYXQgdGhhdCBt ZWFucyBpcyB0aGF0LCBhdCBpb21tdV9zZXR1cCgpIHRpbWUsIHRoZXJlIHN0aWxsIGlzIG9ubHkg b25lCkNQVSBvbmxpbmUsIGFuZCB0aGVyZSBpcyBub3QgbXVjaCBjaGFuY2VzIHRoYXQgb25lIHNp bmdsZSBDUFUgZGVhZGxvY2tzCmluIGEgcmVuZGV6dm91cyEKCkhvbmVzdGx5LCB0aGUgYmlnZ2Vz dCBpc3N1ZSB0aGF0IEkgdGhpbmsgUXVhbidzIHBhdGNoIHNvbHZlcywgaXMgdGhhdAppZiB3ZSBl dmVyIHdhbnQvbWFuYWdlIHRvIG1vdmUgc3Bpbl9kZWJ1Z19lbmFibGUoKSB1cCBhYm92ZSBpdCwg dGhlbgp0aGUgQlVHX09OIGluIGNoZWNrX2xvY2soKSB3b3VsZCB0cmlnZ2VyIHRoZSBmaXJzdCB0 aW1lIHRoYXQKcGNpZGV2c19sb2NrIHdvdWxkIGJlIHRha2VuIHdpdGggaW50ZXJydXB0cyBlbmFi bGVkLgoKVW50aWwgdGhlbiwgY29kZSBpcyB0ZWNobmljYWxseSBmaW5lLCBhbmQsIGFzIGEgbWF0 dGVyIG9mIGZhY3QsIEkgdGhpbmsKdGhhdCByZW1vdmluZyB0aGUgbG9ja2luZyBmcm9tIHRoYXQg cGFydGljdWxhciBpbnN0YW5jZSB3b3VsZCBiZSBhbgplcXVhbGx5IGVmZmVjdGl2ZSBmaXghCgpB bGwgdGhhdCBiZWluZyBzYWlkLCBjb25zaXN0ZW5jeSBpcyBpbmRlZWQgaW1wb3J0YW50LCBhbmQg Zm9yIHRoZSBzYWtlCm9mIGl0IGFuZCBmb3Igb3RoZXIgcmVhc29ucyB0b28sIGV2ZW4gaWYsIHN0 cmljdGx5IHNwZWFraW5nLCB0aGVyZQppc24ndCBhbnkgYWN0dWFsIGJ1Z2d5IGJlaGF2aW9yIHRv IGJlIGZpeGVkIGhlcmUsIGFuZCBpdCBpcyB3b3J0aHdoaWxlCmNvbmZvcm1pbmcgdG8gYSBsb2Nr aW5nIHBhdHRlcm4gdGhhdCBpcyBjb25zaXN0ZW50IHdpdGggdGhlIHJ1bGVzIHRoYXQKd2Ugc2F0 IG91cnNlbHZlcywgdW5sZXNzIHRoZXJlJ3Mgc3BlY2lmaWMgcmVhc29ucyBub3QgdG8uCgpSZWdh cmRzLApEYXJpbwotLSAKPDxUaGlzIGhhcHBlbnMgYmVjYXVzZSBJIGNob29zZSBpdCB0byBoYXBw ZW4hPj4gKFJhaXN0bGluIE1hamVyZSkKLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KRGFyaW8gRmFnZ2lvbGksIFBoLkQsIGh0 dHA6Ly9hYm91dC5tZS9kYXJpby5mYWdnaW9saQpTZW5pb3IgU29mdHdhcmUgRW5naW5lZXIsIENp dHJpeCBTeXN0ZW1zIFImRCBMdGQuLCBDYW1icmlkZ2UgKFVLKQoK --=-wJ35MjHr7Pr5+FD59rO3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlbi6okACgkQk4XaBE3IOsRkawCfcPht2IvquvAEigulQD1t5D2f hsIAn2lAixR32wus/fxxc6PXhJW4u0aO =LCxu -----END PGP SIGNATURE----- --=-wJ35MjHr7Pr5+FD59rO3-- --===============7851903496874821202== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============7851903496874821202==--