[U-Boot] [PATCH 1/4] arm: iproc: add NAND driver

[Scott Wood <oss@buserror.net>]

On Thu, 2016-03-10 at 14:26 -0800, Steve Rae wrote:
> From: Jiandong Zheng <jdzheng@broadcom.com>
> 
> Add support for the iproc NAND, and enable on Cygnus and NSP boards.
> 
> Signed-off-by: Jiandong Zheng <jdzheng@broadcom.com>
> Signed-off-by: Steve Rae <srae@broadcom.com>
> ---
> There was a previous attempt to implement this "iproc NAND"
> (see: http://patchwork.ozlabs.org/patch/505399), however, due to the
> amount of changes required, it seemed better to implement the code
> in a series of steps. This is the first step, where the "iproc_nand.c"
> is essentially an empty file (with one function required to allow this
> commit to build successfully).

I don't see the value of applying a such a do-nothing patch.  It's fine to
leave out unnecessary features, things that improve performance, etc. but to
be applied a patchset should accomplish something useful and correct, not just
be a staging area for future patches.

> diff --git a/arch/arm/include/asm/arch-bcmcygnus/configs.h
> b/arch/arm/include/asm/arch-bcmcygnus/configs.h
> index 3c07160..3bf7395 100644
> --- a/arch/arm/include/asm/arch-bcmcygnus/configs.h
> +++ b/arch/arm/include/asm/arch-bcmcygnus/configs.h
> @@ -10,6 +10,7 @@
>  #include <asm/iproc-common/configs.h>
>  
>  /* uArchitecture specifics */
> +#include <../../../drivers/mtd/nand/iproc_nand_cygnus.h>

No.

-Scott