From: Matthias Brugger <mbrugger@suse.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>,
Quan Nguyen <qnguyen@apm.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller
Date: Fri, 11 Mar 2016 21:03:04 +0100 [thread overview]
Message-ID: <1457726584.587.5.camel@suse.com> (raw)
In-Reply-To: <CACRpkdbtRAC4pUQP29SAmL-ge6uJefMt5Cda6dYCR2kZ8u18og@mail.gmail.com>
On Fri, 2016-03-11 at 23:01 +0700, Linus Walleij wrote:
> On Fri, Mar 4, 2016 at 5:59 PM, Matthias Brugger <mbrugger@suse.com>
> wrote:
>
> > The standby GPIO controller can be used as a interrupt controller.
> > Select GPIOLIB_IRQCHIP when compiling this driver. Otherwise we get
> > a compilation error:
> >
> > drivers/gpio/gpio-xgene-sb.c: In function 'xgene_gpio_sb_probe':
> > drivers/gpio/gpio-xgene-sb.c:312:10: error: 'struct gpio_chip' has
> > no member named 'irqdomain'
> > priv->gc.irqdomain = priv->irq_domain;
> > ^
> > scripts/Makefile.build:295: recipe for target 'drivers/gpio/gpio
> > -xgene-sb.o' failed
> > make[2]: *** [drivers/gpio/gpio-xgene-sb.o] Error 1
> >
> > Fixes: 1013fc41 "gpio: xgene: Enable X-Gene standby GPIO as
> > interrupt controller"
> > Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>
> Quan's patch exporting the symbols has been merged by tglx
> so dropping this.
>
Thanks for the info.
Actually this is v1 [1] of the patch, which just addresses the
GPIOLIB_IRQCHIP problem?
With Quan's patch this should still be present.
[1] https://patchwork.kernel.org/patch/8502401/
next prev parent reply other threads:[~2016-03-11 20:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 10:59 [PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller Matthias Brugger
2016-03-08 4:29 ` Quan Nguyen
2016-03-11 16:01 ` Linus Walleij
2016-03-11 20:03 ` Matthias Brugger [this message]
2016-03-16 12:00 ` Linus Walleij
-- strict thread matches above, loose matches on Subject: below --
2016-03-04 11:42 Matthias Brugger
2016-03-07 7:41 ` Linus Walleij
2016-03-07 10:47 ` Matthias Brugger
2016-03-08 4:43 ` Quan Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457726584.587.5.camel@suse.com \
--to=mbrugger@suse.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qnguyen@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.