From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simo Subject: Re: [PATCH v18 00/22] Richacls (Core and Ext4) Date: Sat, 12 Mar 2016 16:12:27 -0500 Message-ID: <1457817147.3540.28.camel@samba.org> References: <1456733847-17982-1-git-send-email-agruenba@redhat.com> <20160311140134.GA14808@infradead.org> <20160311140757.GB13178@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20160311140757.GB13178-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "J. Bruce Fields" , Christoph Hellwig Cc: Andreas Gruenbacher , Alexander Viro , linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Theodore Ts'o , linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Trond Myklebust , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, xfs-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org, Andreas Dilger , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jeff Layton , linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Anna Schumaker List-Id: linux-api@vger.kernel.org On Fri, 2016-03-11 at 09:07 -0500, J. Bruce Fields wrote: > On Fri, Mar 11, 2016 at 06:01:34AM -0800, Christoph Hellwig wrote: > >=20 > > On Mon, Feb 29, 2016 at 09:17:05AM +0100, Andreas Gruenbacher > > wrote: > > >=20 > > > Al, > > >=20 > > > could you please make sure you are happy with the current version > > > of the > > > richacl patch queue for the next merge window? > > I'm still not happy. > >=20 > > For one I still see no reason to merge this broken ACL model at > > all. > > It provides our actualy Linux users no benefit at all, while > > breaking > > a lot of assumptions, especially by adding allow and deny ACE at > > the > > same sime. > Could you explain what you mean by "adding allow and deny ACE at the > same time"? >=20 > >=20 > > It also doesn't help with the issue that the main thing it's trying > > to be compatible with (Windows) actually uses a fundamentally > > different > > identifier to apply the ACLs to - as long as you're still limited > > to users and groups and not guids we'll still have that mapping > > problem > > anyway. > Agreed, but, one step at a time?=C2=A0=C2=A0My impression is that the= Samba > people > still consider this a step forward for Linux compatibility. It is a step forward, but being able to store SIDs in the ACL, would be a much better one. Simo. > --b. >=20 > >=20 > >=20 > > But besides that fundamental question on the purpose of it I also > > don't think the code is suitable, more in the individual patches. > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs"= =20 > in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at=C2=A0=C2=A0http://vger.kernel.org/majordomo-in= fo.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hr2.samba.org ([144.76.82.148]:34492 "EHLO hr2.samba.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752185AbcCLVNL (ORCPT ); Sat, 12 Mar 2016 16:13:11 -0500 Message-ID: <1457817147.3540.28.camel@samba.org> Subject: Re: [PATCH v18 00/22] Richacls (Core and Ext4) From: Simo To: "J. Bruce Fields" , Christoph Hellwig Cc: Andreas Gruenbacher , Alexander Viro , linux-nfs@vger.kernel.org, "Theodore Ts'o" , linux-cifs@vger.kernel.org, linux-api@vger.kernel.org, Trond Myklebust , linux-kernel@vger.kernel.org, xfs@oss.sgi.com, Andreas Dilger , linux-fsdevel@vger.kernel.org, Jeff Layton , linux-ext4@vger.kernel.org, Anna Schumaker Date: Sat, 12 Mar 2016 16:12:27 -0500 In-Reply-To: <20160311140757.GB13178@fieldses.org> References: <1456733847-17982-1-git-send-email-agruenba@redhat.com> <20160311140134.GA14808@infradead.org> <20160311140757.GB13178@fieldses.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org List-ID: On Fri, 2016-03-11 at 09:07 -0500, J. Bruce Fields wrote: > On Fri, Mar 11, 2016 at 06:01:34AM -0800, Christoph Hellwig wrote: > > > > On Mon, Feb 29, 2016 at 09:17:05AM +0100, Andreas Gruenbacher > > wrote: > > > > > > Al, > > > > > > could you please make sure you are happy with the current version > > > of the > > > richacl patch queue for the next merge window? > > I'm still not happy. > > > > For one I still see no reason to merge this broken ACL model at > > all. > > It provides our actualy Linux users no benefit at all, while > > breaking > > a lot of assumptions, especially by adding allow and deny ACE at > > the > > same sime. > Could you explain what you mean by "adding allow and deny ACE at the > same time"? > > > > > It also doesn't help with the issue that the main thing it's trying > > to be compatible with (Windows) actually uses a fundamentally > > different > > identifier to apply the ACLs to - as long as you're still limited > > to users and groups and not guids we'll still have that mapping > > problem > > anyway. > Agreed, but, one step at a time?  My impression is that the Samba > people > still consider this a step forward for Linux compatibility. It is a step forward, but being able to store SIDs in the ACL, would be a much better one. Simo. > --b. > > > > > > > But besides that fundamental question on the purpose of it I also > > don't think the code is suitable, more in the individual patches. > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs" > in > the body of a message to majordomo@vger.kernel.org > More majordomo info at  http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id E3CD97CA1 for ; Sat, 12 Mar 2016 15:13:22 -0600 (CST) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay3.corp.sgi.com (Postfix) with ESMTP id 4AA81AC002 for ; Sat, 12 Mar 2016 13:13:19 -0800 (PST) Received: from hr2.samba.org (hr2.samba.org [144.76.82.148]) by cuda.sgi.com with ESMTP id UXXlwzNH2x8f1kH0 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Sat, 12 Mar 2016 13:13:16 -0800 (PST) Message-ID: <1457817147.3540.28.camel@samba.org> Subject: Re: [PATCH v18 00/22] Richacls (Core and Ext4) From: Simo Date: Sat, 12 Mar 2016 16:12:27 -0500 In-Reply-To: <20160311140757.GB13178@fieldses.org> References: <1456733847-17982-1-git-send-email-agruenba@redhat.com> <20160311140134.GA14808@infradead.org> <20160311140757.GB13178@fieldses.org> Mime-Version: 1.0 List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: "J. Bruce Fields" , Christoph Hellwig Cc: linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, Theodore Ts'o , Andreas Gruenbacher , linux-api@vger.kernel.org, Trond Myklebust , linux-kernel@vger.kernel.org, xfs@oss.sgi.com, Andreas Dilger , Alexander Viro , linux-fsdevel@vger.kernel.org, Jeff Layton , linux-ext4@vger.kernel.org, Anna Schumaker T24gRnJpLCAyMDE2LTAzLTExIGF0IDA5OjA3IC0wNTAwLCBKLiBCcnVjZSBGaWVsZHMgd3JvdGU6 Cj4gT24gRnJpLCBNYXIgMTEsIDIwMTYgYXQgMDY6MDE6MzRBTSAtMDgwMCwgQ2hyaXN0b3BoIEhl bGx3aWcgd3JvdGU6Cj4gPiAKPiA+IE9uIE1vbiwgRmViIDI5LCAyMDE2IGF0IDA5OjE3OjA1QU0g KzAxMDAsIEFuZHJlYXMgR3J1ZW5iYWNoZXIKPiA+IHdyb3RlOgo+ID4gPiAKPiA+ID4gQWwsCj4g PiA+IAo+ID4gPiBjb3VsZCB5b3UgcGxlYXNlIG1ha2Ugc3VyZSB5b3UgYXJlIGhhcHB5IHdpdGgg dGhlIGN1cnJlbnQgdmVyc2lvbgo+ID4gPiBvZiB0aGUKPiA+ID4gcmljaGFjbCBwYXRjaCBxdWV1 ZSBmb3IgdGhlIG5leHQgbWVyZ2Ugd2luZG93Pwo+ID4gSSdtIHN0aWxsIG5vdCBoYXBweS4KPiA+ IAo+ID4gRm9yIG9uZSBJIHN0aWxsIHNlZSBubyByZWFzb24gdG8gbWVyZ2UgdGhpcyBicm9rZW4g QUNMIG1vZGVsIGF0Cj4gPiBhbGwuCj4gPiBJdCBwcm92aWRlcyBvdXIgYWN0dWFseSBMaW51eCB1 c2VycyBubyBiZW5lZml0IGF0IGFsbCwgd2hpbGUKPiA+IGJyZWFraW5nCj4gPiBhIGxvdCBvZiBh c3N1bXB0aW9ucywgZXNwZWNpYWxseSBieSBhZGRpbmcgYWxsb3cgYW5kIGRlbnkgQUNFIGF0Cj4g PiB0aGUKPiA+IHNhbWUgc2ltZS4KPiBDb3VsZCB5b3UgZXhwbGFpbiB3aGF0IHlvdSBtZWFuIGJ5 ICJhZGRpbmcgYWxsb3cgYW5kIGRlbnkgQUNFIGF0IHRoZQo+IHNhbWUgdGltZSI/Cj4gCj4gPiAK PiA+IEl0IGFsc28gZG9lc24ndCBoZWxwIHdpdGggdGhlIGlzc3VlIHRoYXQgdGhlIG1haW4gdGhp bmcgaXQncyB0cnlpbmcKPiA+IHRvIGJlIGNvbXBhdGlibGUgd2l0aCAoV2luZG93cykgYWN0dWFs bHkgdXNlcyBhIGZ1bmRhbWVudGFsbHkKPiA+IGRpZmZlcmVudAo+ID4gaWRlbnRpZmllciB0byBh cHBseSB0aGUgQUNMcyB0byAtIGFzIGxvbmcgYXMgeW91J3JlIHN0aWxsIGxpbWl0ZWQKPiA+IHRv IHVzZXJzIGFuZCBncm91cHMgYW5kIG5vdCBndWlkcyB3ZSdsbCBzdGlsbCBoYXZlIHRoYXQgbWFw cGluZwo+ID4gcHJvYmxlbQo+ID4gYW55d2F5Lgo+IEFncmVlZCwgYnV0LCBvbmUgc3RlcCBhdCBh IHRpbWU/wqDCoE15IGltcHJlc3Npb24gaXMgdGhhdCB0aGUgU2FtYmEKPiBwZW9wbGUKPiBzdGls bCBjb25zaWRlciB0aGlzIGEgc3RlcCBmb3J3YXJkIGZvciBMaW51eCBjb21wYXRpYmlsaXR5LgoK SXQgaXMgYSBzdGVwIGZvcndhcmQsIGJ1dCBiZWluZyBhYmxlIHRvIHN0b3JlIFNJRHMgaW4gdGhl IEFDTCwgd291bGQgYmUKYSBtdWNoIGJldHRlciBvbmUuCgpTaW1vLgoKPiAtLWIuCj4gCj4gPiAK PiA+IAo+ID4gQnV0IGJlc2lkZXMgdGhhdCBmdW5kYW1lbnRhbCBxdWVzdGlvbiBvbiB0aGUgcHVy cG9zZSBvZiBpdCBJIGFsc28KPiA+IGRvbid0IHRoaW5rIHRoZSBjb2RlIGlzIHN1aXRhYmxlLCBt b3JlIGluIHRoZSBpbmRpdmlkdWFsIHBhdGNoZXMuCj4gLS0KPiBUbyB1bnN1YnNjcmliZSBmcm9t IHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgbGludXgtY2lmcyIgCj4gaW4K PiB0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwo+IE1v cmUgbWFqb3Jkb21vIGluZm8gYXTCoMKgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8t aW5mby5odG1sCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Xwp4ZnMgbWFpbGluZyBsaXN0Cnhmc0Bvc3Muc2dpLmNvbQpodHRwOi8vb3NzLnNnaS5jb20vbWFp bG1hbi9saXN0aW5mby94ZnMK