Re: [Outreachy kernel] [PATCH] staging: dgnc: replaced udelay with usleep_range in dgnc_cls.c

[Juliana Rodrigues <juliana.orod@gmail.com>]

Em Sáb, 2016-03-12 às 18:57 -0800, Greg KH escreveu:
> On Sat, Mar 12, 2016 at 10:13:23PM -0300, Juliana Rodrigues wrote:
> > 
> > This patch replaces udelay with usleep_range fixing a checkpatch.pl
> > issue:
> > 
> > CHECK: usleep_range is preferred over udelay; see
> > Documentation/timers/timers-howto.txt
> > +       udelay(10);
> > 
> > Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
> > ---
> >  drivers/staging/dgnc/dgnc_cls.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/dgnc/dgnc_cls.c
> > b/drivers/staging/dgnc/dgnc_cls.c
> > index 72f0aaa..51db98b 100644
> > --- a/drivers/staging/dgnc/dgnc_cls.c
> > +++ b/drivers/staging/dgnc/dgnc_cls.c
> > @@ -956,7 +956,7 @@ static void cls_flush_uart_read(struct
> > channel_t *ch)
> >  	 * Presumably, this is a bug in this UART.
> >  	 */
> >  
> > -	udelay(10);
> > +	usleep_range(10000, 11000);
> How do you know this range is ok?

Probably it isnt. I thought that usleep_range were 
in microseconds while udelay in miliseconds. I'll 
make a patch to fix this. 

Thanks, Greg. :)
>