From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:42720 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751941AbcCNRYr (ORCPT ); Mon, 14 Mar 2016 13:24:47 -0400 Subject: Patch "block: don't optimize for non-cloned bio in bio_get_last_bvec()" has been added to the 4.4-stable tree To: ming.lei@canonical.com, axboe@fb.com, gregkh@linuxfoundation.org, kent.overstreet@gmail.com Cc: , From: Date: Mon, 14 Mar 2016 10:24:46 -0700 Message-ID: <1457976286171223@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled block: don't optimize for non-cloned bio in bio_get_last_bvec() to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: block-don-t-optimize-for-non-cloned-bio-in-bio_get_last_bvec.patch and it can be found in the queue-4.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From 90d0f0f11588ec692c12f9009089b398be395184 Mon Sep 17 00:00:00 2001 From: Ming Lei Date: Sat, 12 Mar 2016 22:56:19 +0800 Subject: block: don't optimize for non-cloned bio in bio_get_last_bvec() From: Ming Lei commit 90d0f0f11588ec692c12f9009089b398be395184 upstream. For !BIO_CLONED bio, we can use .bi_vcnt safely, but it doesn't mean we can just simply return .bi_io_vec[.bi_vcnt - 1] because the start postion may have been moved in the middle of the bvec, such as splitting in the middle of bvec. Fixes: 7bcd79ac50d9(block: bio: introduce helpers to get the 1st and last bvec) Reported-by: Kent Overstreet Signed-off-by: Ming Lei Signed-off-by: Jens Axboe Signed-off-by: Greg Kroah-Hartman --- include/linux/bio.h | 5 ----- 1 file changed, 5 deletions(-) --- a/include/linux/bio.h +++ b/include/linux/bio.h @@ -320,11 +320,6 @@ static inline void bio_get_last_bvec(str struct bvec_iter iter = bio->bi_iter; int idx; - if (!bio_flagged(bio, BIO_CLONED)) { - *bv = bio->bi_io_vec[bio->bi_vcnt - 1]; - return; - } - if (unlikely(!bio_multiple_segments(bio))) { *bv = bio_iovec(bio); return; Patches currently in stable-queue which might be from ming.lei@canonical.com are queue-4.4/block-don-t-optimize-for-non-cloned-bio-in-bio_get_last_bvec.patch