From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from russell.cc (russell.cc [IPv6:2404:9400:2:0:216:3eff:fee0:3370]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3qPNl12Zs3zDqGh for ; Tue, 15 Mar 2016 16:41:01 +1100 (AEDT) Message-ID: <1458020454.30802.5.camel@russell.cc> Subject: Re: [PATCH] powernv/hmi: Use the "unknown" checkstop type as a fallback From: Russell Currey To: Andrew Donnellan , linuxppc-dev@lists.ozlabs.org Date: Tue, 15 Mar 2016 16:40:54 +1100 In-Reply-To: <56E79F56.6050006@au1.ibm.com> References: <1458012409-32448-1-git-send-email-ruscur@russell.cc> <56E787FE.1060104@au1.ibm.com> <1458018919.30802.4.camel@russell.cc> <56E79F56.6050006@au1.ibm.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2016-03-15 at 16:36 +1100, Andrew Donnellan wrote: > On 15/03/16 16:15, Russell Currey wrote: > > > > > > > > Would it be useful to print xstop_type in the unknown case? > > I don't think so - if there's a new checkstop type, specific handling > > for > > it should be implemented in the kernel, and if you're getting unknown > > checkstops that are bringing down your machine you should be looking at > > the > > OPAL firmware log anyway, which would contain details if there was > > something "new". > That's fair, would primarily help debugging in the rather corner case of  > new skiboot, old kernel, and no access to the OPAL log... > I think if you don't have access to the OPAL log, finding out what number OPAL sent isn't going to help you.