From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Tue, 15 Mar 2016 08:33:29 +0000 Subject: Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND Message-Id: <1458030809.11972.178.camel@perches.com> List-Id: References: <20160315071140.GF13560@mwanda> In-Reply-To: <20160315071140.GF13560@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Dan Carpenter , Dmitry Torokhov , Andrew Duggan Cc: Henrik Rydberg , Christopher Heiny , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Tue, 2016-03-15 at 10:11 +0300, Dan Carpenter wrote: > There is a typo so we have && instead of &. >=20 > Fixes: ff8f83708b3e ('Input: synaptics-rmi4 - add support for 2D sensors = and F11') > Signed-off-by: Dan Carpenter >=20 > diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c [] > @@ -775,7 +775,7 @@ static int rmi_f11_get_query_parameters(struct rmi_de= vice *rmi_dev, > =A0 sensor_query->has_abs =3D !!(query_buf[0] & RMI_F11_HAS_ABS); > =A0 sensor_query->has_gestures =3D !!(query_buf[0] & RMI_F11_HAS_GESTURES= ); > =A0 sensor_query->has_sensitivity_adjust > - !!(query_buf[0] && RMI_F11_= HAS_SENSITIVITY_ADJ); > + !!(query_buf[0] & RMI_F11_HAS_SENSITIVITY_ADJ); > =A0 sensor_query->configurable =3D !!(query_buf[0] & RMI_F11_CONFIGURABLE= ); > =A0 > =A0 sensor_query->nr_x_electrodes > @@ -803,7 +803,7 @@ static int rmi_f1= 1_get_query_parameters(struct rmi_device *rmi_dev, > =A0 sensor_query->has_bending_correction > =A0 !!(query_buf[0] & RMI_F= 11_HAS_BENDING_CORRECTION); > =A0 sensor_query->has_large_object_suppression > - !!(query_buf[0] && R= MI_F11_HAS_LARGE_OBJECT_SUPPRESSION); > + !!(query_buf[0] & RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION); > =A0 sensor_query->has_jitter_filter > =A0 !!(query_buf[0] & RMI_F11_HA= S_JITTER_FILTER); > =A0 query_size++; Right and as well these are bool so the !! isn't necessary. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND Date: Tue, 15 Mar 2016 01:33:29 -0700 Message-ID: <1458030809.11972.178.camel@perches.com> References: <20160315071140.GF13560@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20160315071140.GF13560@mwanda> Sender: kernel-janitors-owner@vger.kernel.org To: Dan Carpenter , Dmitry Torokhov , Andrew Duggan Cc: Henrik Rydberg , Christopher Heiny , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org List-Id: linux-input@vger.kernel.org On Tue, 2016-03-15 at 10:11 +0300, Dan Carpenter wrote: > There is a typo so we have && instead of &. >=20 > Fixes: ff8f83708b3e ('Input: synaptics-rmi4 - add support for 2D sens= ors and F11') > Signed-off-by: Dan Carpenter >=20 > diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f1= 1.c [] > @@ -775,7 +775,7 @@ static int rmi_f11_get_query_parameters(struct rm= i_device *rmi_dev, > =A0 sensor_query->has_abs =3D !!(query_buf[0] & RMI_F11_HAS_ABS); > =A0 sensor_query->has_gestures =3D !!(query_buf[0] & RMI_F11_HAS_GEST= URES); > =A0 sensor_query->has_sensitivity_adjust =3D > - !!(query_buf[0] && RMI_F11_HAS_SENSITIVITY_ADJ); > + !!(query_buf[0] & RMI_F11_HAS_SENSITIVITY_ADJ); > =A0 sensor_query->configurable =3D !!(query_buf[0] & RMI_F11_CONFIGUR= ABLE); > =A0 > =A0 sensor_query->nr_x_electrodes =3D > @@ -803,7 +803,7 @@ static int rmi_f11_get_query_parameters(struct rm= i_device *rmi_dev, > =A0 sensor_query->has_bending_correction =3D > =A0 !!(query_buf[0] & RMI_F11_HAS_BENDING_CORRECTION); > =A0 sensor_query->has_large_object_suppression =3D > - !!(query_buf[0] && RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION); > + !!(query_buf[0] & RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION); > =A0 sensor_query->has_jitter_filter =3D > =A0 !!(query_buf[0] & RMI_F11_HAS_JITTER_FILTER); > =A0 query_size++; Right and as well these are bool so the !! isn't necessary. -- To unsubscribe from this list: send the line "unsubscribe kernel-janito= rs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964943AbcCOIdl (ORCPT ); Tue, 15 Mar 2016 04:33:41 -0400 Received: from smtprelay0081.hostedemail.com ([216.40.44.81]:36075 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933849AbcCOIdd (ORCPT ); Tue, 15 Mar 2016 04:33:33 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3868:3871:4321:5007:6261:10004:10400:10848:11026:11232:11473:11658:11914:12043:12296:12438:12517:12519:12555:12740:13069:13311:13357:13439:13894:14659:14721:21080:30054:30064:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: bag39_75f43b2fa0a3c X-Filterd-Recvd-Size: 2373 Message-ID: <1458030809.11972.178.camel@perches.com> Subject: Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND From: Joe Perches To: Dan Carpenter , Dmitry Torokhov , Andrew Duggan Cc: Henrik Rydberg , Christopher Heiny , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Date: Tue, 15 Mar 2016 01:33:29 -0700 In-Reply-To: <20160315071140.GF13560@mwanda> References: <20160315071140.GF13560@mwanda> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-03-15 at 10:11 +0300, Dan Carpenter wrote: > There is a typo so we have && instead of &. > > Fixes: ff8f83708b3e ('Input: synaptics-rmi4 - add support for 2D sensors and F11') > Signed-off-by: Dan Carpenter > > diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c [] > @@ -775,7 +775,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev, >   sensor_query->has_abs = !!(query_buf[0] & RMI_F11_HAS_ABS); >   sensor_query->has_gestures = !!(query_buf[0] & RMI_F11_HAS_GESTURES); >   sensor_query->has_sensitivity_adjust = > - !!(query_buf[0] && RMI_F11_HAS_SENSITIVITY_ADJ); > + !!(query_buf[0] & RMI_F11_HAS_SENSITIVITY_ADJ); >   sensor_query->configurable = !!(query_buf[0] & RMI_F11_CONFIGURABLE); >   >   sensor_query->nr_x_electrodes = > @@ -803,7 +803,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev, >   sensor_query->has_bending_correction = >   !!(query_buf[0] & RMI_F11_HAS_BENDING_CORRECTION); >   sensor_query->has_large_object_suppression = > - !!(query_buf[0] && RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION); > + !!(query_buf[0] & RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION); >   sensor_query->has_jitter_filter = >   !!(query_buf[0] & RMI_F11_HAS_JITTER_FILTER); >   query_size++; Right and as well these are bool so the !! isn't necessary.