From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from [125.16.236.7] ([125.16.236.7]:43552 "EHLO e28smtp07.in.ibm.com"
	rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP
	id S1753680AbcCOQ10 (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 15 Mar 2016 12:27:26 -0400
Received: from localhost
	by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted
	for <linux-fsdevel@vger.kernel.org> from <zohar@linux.vnet.ibm.com>;
	Tue, 15 Mar 2016 21:56:43 +0530
Message-ID: <1458059196.2662.4.camel@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 2/2] ima: add support for creating files using the
 mknodat syscall
From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-security-module <linux-security-module@vger.kernel.org>,
	linux-fsdevel@vger.kernel.org
Date: Tue, 15 Mar 2016 12:26:36 -0400
In-Reply-To: <20160315143601.GI17997@ZenIV.linux.org.uk>
References: <1458049391-26620-1-git-send-email-zohar@linux.vnet.ibm.com>
	 <1458049391-26620-3-git-send-email-zohar@linux.vnet.ibm.com>
	 <20160315143601.GI17997@ZenIV.linux.org.uk>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, 2016-03-15 at 14:36 +0000, Al Viro wrote:
> On Tue, Mar 15, 2016 at 09:43:11AM -0400, Mimi Zohar wrote:
> > +void ima_post_path_mknod(struct dentry *dentry)
> > +{
> > +	struct integrity_iint_cache *iint;
> > +	struct inode *inode;
> > +	int must_appraise;
> > +
> > +	if (!dentry || !dentry->d_inode)
> 
> In which situations is that condition supposed to be true?

Never, removing tests.

Mimi