From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v4 04/14] firmware/makefile: install BIOS
 blob ...
Date: Wed, 16 Mar 2016 09:54:44 +0100
Message-ID: <1458118484.3102.790.camel@citrix.com>
References: <1457978150-27201-1-git-send-email-anthony.perard@citrix.com>
 <1457978150-27201-5-git-send-email-anthony.perard@citrix.com>
 <20160316002601.GA29696@char.us.oracle.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0918283116469904119=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20160316002601.GA29696@char.us.oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Anthony PERARD <anthony.perard@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, xen-devel@lists.xen.org, Ian Jackson <ian.jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

--===============0918283116469904119==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-E0X4sEOPK7/KzjcJv90b"

--=-E0X4sEOPK7/KzjcJv90b
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2016-03-15 at 20:26 -0400, Konrad Rzeszutek Wilk wrote:
> On Mon, Mar 14, 2016 at 05:55:39PM +0000, Anthony PERARD wrote:
> >=C2=A0
> > diff --git a/tools/firmware/Makefile b/tools/firmware/Makefile
> > index 6cc86ce..6a37758 100644
> > --- a/tools/firmware/Makefile
> > +++ b/tools/firmware/Makefile
> > @@ -19,6 +19,9 @@ SUBDIRS-y +=3D hvmloader
> > =C2=A0
> > =C2=A0LD32BIT-$(CONFIG_FreeBSD) :=3D LD32BIT_FLAG=3D-melf_i386_fbsd
> > =C2=A0
> > +SEABIOS_ROM :=3D seabios-dir/out/bios.bin
> > +OVMF_ROM :=3D ovmf-dir/ovmf.bin
> These will set the variables..
> >=20
> > +
> > =C2=A0ovmf-dir:
> > =C2=A0	GIT=3D$(GIT) $(XEN_ROOT)/scripts/git-checkout.sh
> > $(OVMF_UPSTREAM_URL) $(OVMF_UPSTREAM_REVISION) ovmf-dir
> > =C2=A0	cp ovmf-makefile ovmf-dir/Makefile;
> > @@ -45,6 +48,16 @@ endif
> > =C2=A0install: all
> > =C2=A0	[ -d $(INST_DIR) ] || $(INSTALL_DIR) $(INST_DIR)
> > =C2=A0	[ ! -e $(TARGET) ] || $(INSTALL_DATA) $(TARGET)
> > $(INST_DIR)
> > +ifeq ($(CONFIG_SEABIOS),y)
> > +ifeq ($(SEABIOS_PATH),)
> But here you check them?
>=20
> Or should the setting of OVMF_ROM and SEABIOS_ROM be ?=3D=C2=A0
>=20
I don't speak too much Makefile, TBH (so apologies if I'm talking
nonsense), but it looks to me that what is set above and what is
checked here are indeed _not_the_same_ variables.. isn't that the case?

Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-E0X4sEOPK7/KzjcJv90b
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlbpH1QACgkQk4XaBE3IOsRd4wCeKe5QUBuaHG0dh+syorjMWzQ0
Gs8An1pv++zX+HTedOQIMFHZk+maIEJN
=dres
-----END PGP SIGNATURE-----

--=-E0X4sEOPK7/KzjcJv90b--


--===============0918283116469904119==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y
Zy94ZW4tZGV2ZWwK

--===============0918283116469904119==--