All of lore.kernel.org
 help / color / mirror / Atom feed
From: malattia@linux.it
To: Thomas Renninger <trenn@suse.com>
Cc: linux-pm@vger.kernel.org, Mattia Dongili <malattia@linux.it>
Subject: [PATCH 1/3] warning: comparison of constant ‘-1’ with boolean expression is always false
Date: Wed, 16 Mar 2016 07:13:06 -0700	[thread overview]
Message-ID: <1458137588-6126-2-git-send-email-malattia@linux.it> (raw)
In-Reply-To: <1458137588-6126-1-git-send-email-malattia@linux.it>

From: Mattia Dongili <malattia@linux.it>

Signed-off-by: Mattia Dongili <malattia@linux.it>
---
 tools/power/cpupower/utils/helpers/topology.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/power/cpupower/utils/helpers/topology.c b/tools/power/cpupower/utils/helpers/topology.c
index 9cbb7fd..771ec60 100644
--- a/tools/power/cpupower/utils/helpers/topology.c
+++ b/tools/power/cpupower/utils/helpers/topology.c
@@ -106,7 +106,7 @@ int get_cpu_topology(struct cpupower_topology *cpu_top)
 			cpu_top->pkgs++;
 		}
 	}
-	if (!cpu_top->core_info[0].pkg == -1)
+	if (cpu_top->core_info[0].pkg != -1)
 		cpu_top->pkgs++;
 
 	/* Intel's cores count is not consecutively numbered, there may
-- 
2.7.0


  reply	other threads:[~2016-03-16 14:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-16 14:13 [PATCH 0/3] Minor fixes for tools/cpupower malattia
2016-03-16 14:13 ` malattia [this message]
2016-03-16 14:13 ` [PATCH 2/3] Fix cpupower manpages "NAME" section malattia
2016-03-16 14:13 ` [PATCH 3/3] Honour user's LDFLAGS malattia
2016-03-16 15:17 ` [PATCH 0/3] Minor fixes for tools/cpupower Thomas Renninger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458137588-6126-2-git-send-email-malattia@linux.it \
    --to=malattia@linux.it \
    --cc=linux-pm@vger.kernel.org \
    --cc=trenn@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.