From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: [PATCH][meta-browser 2/2] cef3: comment out gtests completely
Date: Wed, 16 Mar 2016 16:47:42 +0100 [thread overview]
Message-ID: <1458143262-22936-2-git-send-email-Martin.Jansa@gmail.com> (raw)
In-Reply-To: <1458143262-22936-1-git-send-email-Martin.Jansa@gmail.com>
* the old fix wasn't enough and it was still failing with warnings
about unused variables in gtests
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
...-test.h-disable-warning-unused-definition.patch | 72 +++++++++++++++++++++-
1 file changed, 70 insertions(+), 2 deletions(-)
diff --git a/recipes-browser/chromium/cef3/0003-gtest-typed-test.h-disable-warning-unused-definition.patch b/recipes-browser/chromium/cef3/0003-gtest-typed-test.h-disable-warning-unused-definition.patch
index 97a6116..a53dbc5 100644
--- a/recipes-browser/chromium/cef3/0003-gtest-typed-test.h-disable-warning-unused-definition.patch
+++ b/recipes-browser/chromium/cef3/0003-gtest-typed-test.h-disable-warning-unused-definition.patch
@@ -38,6 +38,74 @@ index fe1e83b..5053bbe 100644
+#pragma GCC diagnostic pop
+
#endif // GTEST_INCLUDE_GTEST_GTEST_TYPED_TEST_H_
---
-1.8.4.5
+diff -uNr a/base/test/sequenced_task_runner_test_template.h b/base/test/sequenced_task_runner_test_template.h
+--- a/base/test/sequenced_task_runner_test_template.h 2014-10-28 02:07:09.000000000 -1000
++++ b/base/test/sequenced_task_runner_test_template.h 2016-03-10 09:38:16.987413000 -1000
+@@ -23,6 +23,9 @@
+ #include "base/time/time.h"
+ #include "testing/gtest/include/gtest/gtest.h"
+
++#pragma GCC diagnostic push
++#pragma GCC diagnostic warning "-Wunused"
++
+ namespace base {
+
+ namespace internal {
+@@ -326,6 +329,7 @@
+ // whether the implementation supports nested tasks.
+ //
+
++/*
+ REGISTER_TYPED_TEST_CASE_P(SequencedTaskRunnerTest,
+ SequentialNonNestable,
+ SequentialNestable,
+@@ -335,6 +339,8 @@
+ DelayedTasksSameDelay,
+ DelayedTaskAfterLongTask,
+ DelayedTaskAfterManyLongTasks);
++*/
++#pragma GCC diagnostic pop
+
+ } // namespace base
+
+diff -uNr a/base/test/task_runner_test_template.h b/base/test/task_runner_test_template.h
+--- a/base/test/task_runner_test_template.h 2014-10-28 02:07:09.000000000 -1000
++++ b/base/test/task_runner_test_template.h 2016-03-10 09:39:02.051413000 -1000
+@@ -207,8 +207,10 @@
+ this->task_tracker_->GetTaskRunCounts());
+ }
+
++/*
+ REGISTER_TYPED_TEST_CASE_P(
+ TaskRunnerTest, Basic, Delayed, RunsTasksOnCurrentThread);
++*/
+
+ } // namespace base
+
+diff -uNr a/testing/gtest/include/gtest/gtest-typed-test.h b/testing/gtest/include/gtest/gtest-typed-test.h
+--- a/testing/gtest/include/gtest/gtest-typed-test.h 2016-03-10 10:25:47.371413000 -1000
++++ b/testing/gtest/include/gtest/gtest-typed-test.h 2016-03-10 09:35:25.811413000 -1000
+@@ -34,6 +34,7 @@
+
+ #pragma GCC diagnostic push
+ #pragma GCC diagnostic warning "-Wunused"
++#pragma GCC diagnostic warning "-Wunused-variable"
+
+ // This header implements typed tests and type-parameterized tests.
+
+diff -uNr a/testing/gtest/include/gtest/gtest.h b/testing/gtest/include/gtest/gtest.h
+--- a/testing/gtest/include/gtest/gtest.h 2014-10-27 23:19:20.000000000 -1000
++++ b/testing/gtest/include/gtest/gtest.h 2016-03-10 09:36:13.607413000 -1000
+@@ -63,7 +63,11 @@
+ #include "gtest/gtest-printers.h"
+ #include "gtest/gtest_prod.h"
+ #include "gtest/gtest-test-part.h"
++#pragma GCC diagnostic push
++#pragma GCC diagnostic warning "-Wunused"
++#pragma GCC diagnostic warning "-Wunused-variable"
+ #include "gtest/gtest-typed-test.h"
++#pragma GCC diagnostic pop
+
+ // Depending on the platform, different string classes are available.
+ // On Linux, in addition to ::std::string, Google also makes use of
--
2.7.3
prev parent reply other threads:[~2016-03-16 15:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 15:47 [PATCH][meta-browser 1/2] cef3, chromium: fix build with gcc-5.3 Martin Jansa
2016-03-16 15:47 ` Martin Jansa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458143262-22936-2-git-send-email-Martin.Jansa@gmail.com \
--to=martin.jansa@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.