diff for duplicates of <1458169132.2878.25.camel@intel.com> diff --git a/a/1.txt b/N1/1.txt index 9e80f2a..3e9df95 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,8 +2,8 @@ On Mon, 2016-03-14 at 15:47 -0400, Sowmini Varadhan wrote: > > For LLC based protocols like lldp, stp etc., the ethernet header > is an 802.3 header with a h_proto that is not 0x800, 0x86dd, or -> even 0x806.? In this world, the skb_network_header() points at -> the DSAP/SSAP/..? and is not likely to be NET_IP_ALIGNed in +> even 0x806. In this world, the skb_network_header() points at +> the DSAP/SSAP/.. and is not likely to be NET_IP_ALIGNed in > ixgbe_atr(). > > With LLC, drivers are not likely to correctly find IPVERSION, @@ -18,52 +18,45 @@ On Mon, 2016-03-14 at 15:47 -0400, Sowmini Varadhan wrote: > Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com> > --- > v2: Alexander Duyck comments -> v3: filter out all ethertypes? except for Ethernet II and (IPv4 or +> v3: filter out all ethertypes except for Ethernet II and (IPv4 or > IPv6) > -> ?drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |??? 5 +++++ -> ?1 files changed, 5 insertions(+), 0 deletions(-) +> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 5 +++++ +> 1 files changed, 5 insertions(+), 0 deletions(-) -This does not apply since Alex Duyck beat you to the fix. ?Here is the -patch he submitted on 3/15 which corrects the issue. ?So I am dropping +This does not apply since Alex Duyck beat you to the fix. Here is the +patch he submitted on 3/15 which corrects the issue. So I am dropping your patch from the queue. commit 04b8b51c34837765cf6250f69d419c439dc393bf Author: Alexander Duyck <aduyck@mirantis.com> -Date:???Tue Mar 15 15:10:22 2016 -0700 +Date: Tue Mar 15 15:10:22 2016 -0700 -????ixgbe: Fix ATR so that it correctly handles IPv6 extension headers -???? -????The ATR code was assuming that it would be able to use tcp_hdr for -????every TCP frame that came through.??However this isn't the case as + ixgbe: Fix ATR so that it correctly handles IPv6 extension headers + + The ATR code was assuming that it would be able to use tcp_hdr for + every TCP frame that came through. However this isn't the case as it -????is possible for a frame to arrive that is TCP but sent through + is possible for a frame to arrive that is TCP but sent through something -????like a raw socket.??As a result the driver was setting up bad + like a raw socket. As a result the driver was setting up bad filters in -????which tcp_hdr was really pointing to the network header so the data + which tcp_hdr was really pointing to the network header so the data was -????all invalid. -???? -????In order to correct this I have added a bit of parsing logic that + all invalid. + + In order to correct this I have added a bit of parsing logic that will -????determine the TCP header location based off of the network header + determine the TCP header location based off of the network header and -????either the offset in the case of the IPv4 header, or a walk through + either the offset in the case of the IPv4 header, or a walk through the -????IPv6 extension headers until it encounters the header that + IPv6 extension headers until it encounters the header that indicates -????IPPROTO_TCP.??In addition I have added checks to verify that the + IPPROTO_TCP. In addition I have added checks to verify that the lowest -????protocol provided is recognized as IPv4 or IPv6 to help mitigate + protocol provided is recognized as IPv4 or IPv6 to help mitigate raw -????sockets using ETH_P_ALL from having ATR applied to them. -???? -????Signed-off-by: Alexander Duyck <aduyck@mirantis.com> --------------- next part -------------- -A non-text attachment was scrubbed... -Name: signature.asc -Type: application/pgp-signature -Size: 819 bytes -Desc: This is a digitally signed message part -URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20160316/05758d47/attachment.asc> + sockets using ETH_P_ALL from having ATR applied to them. + + Signed-off-by: Alexander Duyck <aduyck@mirantis.com> diff --git a/N1/2.bin b/N1/2.bin new file mode 100644 index 0000000..7eeff35 --- /dev/null +++ b/N1/2.bin @@ -0,0 +1,17 @@ +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v2 + +iQIcBAABCgAGBQJW6eUsAAoJEOVv75VaS+3OjNMP/3RTIUIRbxyb05lQpNvccY+v +CsBed46aSsxGybnNFJYwMNs15m7AQ1kuBvOUKysfIzDN+lIXOxkrEtu7ORdX66ba +wAMBhEr+A+GGCkb/no6p2O3Xm1nCTeFv54z+VnkXpEKa0DCpvBpsIavIo7FN+CIK +o5+Iz6o3IpEJ+XWvQkfYnKnUgsNHHuGdzH8dXdeG9vSw/sz9lw7DvKIr3EHQjkr8 +4kt3b1mqcCOuV5IeboWQdcFMroD98N18/pXb2WhC8+RuXd55Qmpse4fq1XCiugFc +/eiYzocKCOztA2xXj/BGXTvqE0iCMQDpPLp7zqj2y7b5sQ7Ju2Wv7BLLkJm0Skmv +dmwdSYkOuAC+jd3gaPCGh0qVBOpiJEZU0V47LgSAbnMtKULSdOsXJ1+1HFA8wFK7 +dCFCPXhj6c6JAbatxcda5eXLGysLibjdLbt5udme2g1bb9ZVfh5i5cTvBqaKCXNw +16FLbMScJ3LDc+MunD8An7I6NF+6oFs9+DUqAkR5bZZCnFD+KHCi5RVOI3Um76S0 +vyXzsghg8i6ZySw3e0BX4b6P0ca4Mo/P4B6W5Kf1OOJvXf9iqqORvXDRT0ONfpu9 +q6G9JxfEkP8ycWzTRfS7cYr6N7iQSCaVc/YXwId55KrIRHF21vxJ7+jqtWDqmUeB +c2VArBvYwS1nRROZmrZ/ +=ooDZ +-----END PGP SIGNATURE----- diff --git a/N1/2.hdr b/N1/2.hdr new file mode 100644 index 0000000..da6d245 --- /dev/null +++ b/N1/2.hdr @@ -0,0 +1,3 @@ +Content-Type: application/pgp-signature; name="signature.asc" +Content-Description: This is a digitally signed message part +Content-Transfer-Encoding: 7bit diff --git a/a/content_digest b/N1/content_digest index c4c8e50..83dbf74 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,16 +1,26 @@ "ref\020160314194716.GM5084@oracle.com\0" "From\0Jeff Kirsher <jeffrey.t.kirsher@intel.com>\0" - "Subject\0[Intel-wired-lan] [PATCH V3 net-next] ixgbe: Avoid unaligned access in ixgbe_atr() for LLC packets\0" + "Subject\0Re: [PATCH V3 net-next] ixgbe: Avoid unaligned access in ixgbe_atr() for LLC packets\0" "Date\0Wed, 16 Mar 2016 15:58:52 -0700\0" - "To\0intel-wired-lan@osuosl.org\0" - "\00:1\0" + "To\0Sowmini Varadhan <sowmini.varadhan@oracle.com>" + intel-wired-lan@lists.osuosl.org + netdev@vger.kernel.org + " alexander.duyck@gmail.com\0" + "Cc\0jesse.brandeburg@intel.com" + shannon.nelson@intel.com + carolyn.wyborny@intel.com + donald.c.skidmore@intel.com + bruce.w.allan@intel.com + john.ronciak@intel.com + " mitch.a.williams@intel.com\0" + "\01:1\0" "b\0" "On Mon, 2016-03-14 at 15:47 -0400, Sowmini Varadhan wrote:\n" "> \n" "> For LLC based protocols like lldp, stp etc., the ethernet header\n" "> is an 802.3 header with a h_proto that is not 0x800, 0x86dd, or\n" - "> even 0x806.? In this world, the skb_network_header() points at\n" - "> the DSAP/SSAP/..? and is not likely to be NET_IP_ALIGNed in\n" + "> even 0x806.\302\240 In this world, the skb_network_header() points at\n" + "> the DSAP/SSAP/..\302\240 and is not likely to be NET_IP_ALIGNed in\n" "> ixgbe_atr().\n" "> \n" "> With LLC, drivers are not likely to correctly find IPVERSION,\n" @@ -25,54 +35,68 @@ "> Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>\n" "> ---\n" "> v2: Alexander Duyck comments\n" - "> v3: filter out all ethertypes? except for Ethernet II and (IPv4 or\n" + "> v3: filter out all ethertypes\302\240 except for Ethernet II and (IPv4 or\n" "> IPv6)\n" "> \n" - "> ?drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |??? 5 +++++\n" - "> ?1 files changed, 5 insertions(+), 0 deletions(-)\n" + "> \302\240drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |\302\240\302\240\302\240 5 +++++\n" + "> \302\2401 files changed, 5 insertions(+), 0 deletions(-)\n" "\n" - "This does not apply since Alex Duyck beat you to the fix. ?Here is the\n" - "patch he submitted on 3/15 which corrects the issue. ?So I am dropping\n" + "This does not apply since Alex Duyck beat you to the fix. \302\240Here is the\n" + "patch he submitted on 3/15 which corrects the issue. \302\240So I am dropping\n" "your patch from the queue.\n" "\n" "commit 04b8b51c34837765cf6250f69d419c439dc393bf\n" "Author: Alexander Duyck <aduyck@mirantis.com>\n" - "Date:???Tue Mar 15 15:10:22 2016 -0700\n" + "Date:\302\240\302\240\302\240Tue Mar 15 15:10:22 2016 -0700\n" "\n" - "????ixgbe: Fix ATR so that it correctly handles IPv6 extension headers\n" - "????\n" - "????The ATR code was assuming that it would be able to use tcp_hdr for\n" - "????every TCP frame that came through.??However this isn't the case as\n" + "\302\240\302\240\302\240\302\240ixgbe: Fix ATR so that it correctly handles IPv6 extension headers\n" + "\302\240\302\240\302\240\302\240\n" + "\302\240\302\240\302\240\302\240The ATR code was assuming that it would be able to use tcp_hdr for\n" + "\302\240\302\240\302\240\302\240every TCP frame that came through.\302\240\302\240However this isn't the case as\n" "it\n" - "????is possible for a frame to arrive that is TCP but sent through\n" + "\302\240\302\240\302\240\302\240is possible for a frame to arrive that is TCP but sent through\n" "something\n" - "????like a raw socket.??As a result the driver was setting up bad\n" + "\302\240\302\240\302\240\302\240like a raw socket.\302\240\302\240As a result the driver was setting up bad\n" "filters in\n" - "????which tcp_hdr was really pointing to the network header so the data\n" + "\302\240\302\240\302\240\302\240which tcp_hdr was really pointing to the network header so the data\n" "was\n" - "????all invalid.\n" - "????\n" - "????In order to correct this I have added a bit of parsing logic that\n" + "\302\240\302\240\302\240\302\240all invalid.\n" + "\302\240\302\240\302\240\302\240\n" + "\302\240\302\240\302\240\302\240In order to correct this I have added a bit of parsing logic that\n" "will\n" - "????determine the TCP header location based off of the network header\n" + "\302\240\302\240\302\240\302\240determine the TCP header location based off of the network header\n" "and\n" - "????either the offset in the case of the IPv4 header, or a walk through\n" + "\302\240\302\240\302\240\302\240either the offset in the case of the IPv4 header, or a walk through\n" "the\n" - "????IPv6 extension headers until it encounters the header that\n" + "\302\240\302\240\302\240\302\240IPv6 extension headers until it encounters the header that\n" "indicates\n" - "????IPPROTO_TCP.??In addition I have added checks to verify that the\n" + "\302\240\302\240\302\240\302\240IPPROTO_TCP.\302\240\302\240In addition I have added checks to verify that the\n" "lowest\n" - "????protocol provided is recognized as IPv4 or IPv6 to help mitigate\n" + "\302\240\302\240\302\240\302\240protocol provided is recognized as IPv4 or IPv6 to help mitigate\n" "raw\n" - "????sockets using ETH_P_ALL from having ATR applied to them.\n" - "????\n" - "????Signed-off-by: Alexander Duyck <aduyck@mirantis.com>\n" - "-------------- next part --------------\n" - "A non-text attachment was scrubbed...\n" - "Name: signature.asc\n" - "Type: application/pgp-signature\n" - "Size: 819 bytes\n" - "Desc: This is a digitally signed message part\n" - URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20160316/05758d47/attachment.asc> + "\302\240\302\240\302\240\302\240sockets using ETH_P_ALL from having ATR applied to them.\n" + "\302\240\302\240\302\240\302\240\n" + "\302\240\302\240\302\240\302\240Signed-off-by: Alexander Duyck <aduyck@mirantis.com>" + "\01:2\0" + "fn\0signature.asc\0" + "d\0This is a digitally signed message part\0" + "b\0" + "-----BEGIN PGP SIGNATURE-----\n" + "Version: GnuPG v2\n" + "\n" + "iQIcBAABCgAGBQJW6eUsAAoJEOVv75VaS+3OjNMP/3RTIUIRbxyb05lQpNvccY+v\n" + "CsBed46aSsxGybnNFJYwMNs15m7AQ1kuBvOUKysfIzDN+lIXOxkrEtu7ORdX66ba\n" + "wAMBhEr+A+GGCkb/no6p2O3Xm1nCTeFv54z+VnkXpEKa0DCpvBpsIavIo7FN+CIK\n" + "o5+Iz6o3IpEJ+XWvQkfYnKnUgsNHHuGdzH8dXdeG9vSw/sz9lw7DvKIr3EHQjkr8\n" + "4kt3b1mqcCOuV5IeboWQdcFMroD98N18/pXb2WhC8+RuXd55Qmpse4fq1XCiugFc\n" + "/eiYzocKCOztA2xXj/BGXTvqE0iCMQDpPLp7zqj2y7b5sQ7Ju2Wv7BLLkJm0Skmv\n" + "dmwdSYkOuAC+jd3gaPCGh0qVBOpiJEZU0V47LgSAbnMtKULSdOsXJ1+1HFA8wFK7\n" + "dCFCPXhj6c6JAbatxcda5eXLGysLibjdLbt5udme2g1bb9ZVfh5i5cTvBqaKCXNw\n" + "16FLbMScJ3LDc+MunD8An7I6NF+6oFs9+DUqAkR5bZZCnFD+KHCi5RVOI3Um76S0\n" + "vyXzsghg8i6ZySw3e0BX4b6P0ca4Mo/P4B6W5Kf1OOJvXf9iqqORvXDRT0ONfpu9\n" + "q6G9JxfEkP8ycWzTRfS7cYr6N7iQSCaVc/YXwId55KrIRHF21vxJ7+jqtWDqmUeB\n" + "c2VArBvYwS1nRROZmrZ/\n" + "=ooDZ\n" + "-----END PGP SIGNATURE-----\n" -0dab39123eb67fde21e085a8016490a703ff2fbbbb8dc03775df126afeb16c65 +0b9f4b109bd7ee95fdd9115071dc7a548022d0b4485b2a76125c47df543d01e3
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.