From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay.hostedemail.com (smtprelay0039.hostedemail.com [216.40.44.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3qR0Mn4mTCzDq70 for ; Fri, 18 Mar 2016 07:29:57 +1100 (AEDT) Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave05.hostedemail.com (Postfix) with ESMTP id EC8DC184F16 for ; Thu, 17 Mar 2016 20:22:43 +0000 (UTC) Message-ID: <1458246150.9556.17.camel@perches.com> Subject: Re: [PATCH v9 2/3] kernel.h: add to_user_ptr() From: Joe Perches To: Gustavo Padovan , Gustavo Padovan , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, Daniel Stone , Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Maarten Lankhorst , akpm@linux-foundation.org, David Airlie , Daniel Vetter , linuxppc-dev Date: Thu, 17 Mar 2016 13:22:30 -0700 In-Reply-To: <20160317184318.GA2611@joana> References: <1458235817-28375-1-git-send-email-gustavo@padovan.org> <1458235817-28375-2-git-send-email-gustavo@padovan.org> <1458236486.9556.11.camel@perches.com> <20160317180523.GA2619@joana> <20160317184318.GA2611@joana> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2016-03-17 at 15:43 -0300, Gustavo Padovan wrote: > 2016-03-17 Gustavo Padovan : > > 2016-03-17 Joe Perches : > > > On Thu, 2016-03-17 at 14:30 -0300, Gustavo Padovan wrote: > > > > > > > > This function had copies in 3 different files. Unify them in > > > > kernel.h. > > > This is only used by gpu/drm. > > > > > > I think this is a poor name for a generic function > > > that would be in kernel.h. > > > > > > Isn't there an include file in linux/drm that's > > > appropriate for this.  Maybe drmP.h > > > > > > Maybe prefix this function name with drm_ too. > > No, the next patch adds a user to drivers/staging (which will be moved > > to drivers/dma-buf) soon. Maybe move to a different header in > > include/linux/? not sure which one. > > > > > > > > Also, there's this that might conflict: > > > > > > arch/powerpc/kernel/signal_32.c:#define to_user_ptr(p)          ptr_to_compat(p) > > > arch/powerpc/kernel/signal_32.c:#define to_user_ptr(p)          ((unsigned long)(p)) > > Right, I'll figure out how to replace these two too. > The powerpc to_user_ptr has a different meaning from the one I'm adding > in this patch. I propose we just rename powerpc's to_user_ptr to > __to_user_ptr and leave the rest as is. I think that's not a good idea, and you should really check this concept with the powerpc folk (added to to:s and cc:ed) If it were really added, then the function meaning is incorrect. This is taking a u64, casting that to (unsigned long/uint_ptr_t), then converting that to a user pointer. Does that naming and use make sense on x86-32 or arm32? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH v9 2/3] kernel.h: add to_user_ptr() Date: Thu, 17 Mar 2016 13:22:30 -0700 Message-ID: <1458246150.9556.17.camel@perches.com> References: <1458235817-28375-1-git-send-email-gustavo@padovan.org> <1458235817-28375-2-git-send-email-gustavo@padovan.org> <1458236486.9556.11.camel@perches.com> <20160317180523.GA2619@joana> <20160317184318.GA2611@joana> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtprelay.hostedemail.com (smtprelay0178.hostedemail.com [216.40.44.178]) by gabe.freedesktop.org (Postfix) with ESMTPS id 09E9C6E36C for ; Thu, 17 Mar 2016 20:22:38 +0000 (UTC) In-Reply-To: <20160317184318.GA2611@joana> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan , Gustavo Padovan , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman Cc: devel@driverdev.osuosl.org, Daniel Stone , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= , Daniel Vetter , Riley Andrews , Daniel Vetter , akpm@linux-foundation.org, linuxppc-dev , John Harrison List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAyMDE2LTAzLTE3IGF0IDE1OjQzIC0wMzAwLCBHdXN0YXZvIFBhZG92YW4gd3JvdGU6 Cj4gMjAxNi0wMy0xNyBHdXN0YXZvIFBhZG92YW4gPGd1c3Rhdm8ucGFkb3ZhbkBjb2xsYWJvcmEu Y28udWs+Ogo+ID4gMjAxNi0wMy0xNyBKb2UgUGVyY2hlcyA8am9lQHBlcmNoZXMuY29tPjoKPiA+ ID4gT24gVGh1LCAyMDE2LTAzLTE3IGF0IDE0OjMwIC0wMzAwLCBHdXN0YXZvIFBhZG92YW4gd3Jv dGU6Cj4gPiA+ID4gCj4gPiA+ID4gVGhpcyBmdW5jdGlvbiBoYWQgY29waWVzIGluIDMgZGlmZmVy ZW50IGZpbGVzLiBVbmlmeSB0aGVtIGluCj4gPiA+ID4ga2VybmVsLmguCj4gPiA+IFRoaXMgaXMg b25seSB1c2VkIGJ5IGdwdS9kcm0uCj4gPiA+IAo+ID4gPiBJIHRoaW5rIHRoaXMgaXMgYSBwb29y IG5hbWUgZm9yIGEgZ2VuZXJpYyBmdW5jdGlvbgo+ID4gPiB0aGF0IHdvdWxkIGJlIGluIGtlcm5l bC5oLgo+ID4gPiAKPiA+ID4gSXNuJ3QgdGhlcmUgYW4gaW5jbHVkZSBmaWxlIGluIGxpbnV4L2Ry bSB0aGF0J3MKPiA+ID4gYXBwcm9wcmlhdGUgZm9yIHRoaXMuIMKgTWF5YmUgZHJtUC5oCj4gPiA+ IAo+ID4gPiBNYXliZSBwcmVmaXggdGhpcyBmdW5jdGlvbiBuYW1lIHdpdGggZHJtXyB0b28uCj4g PiBObywgdGhlIG5leHQgcGF0Y2ggYWRkcyBhIHVzZXIgdG8gZHJpdmVycy9zdGFnaW5nICh3aGlj aCB3aWxsIGJlIG1vdmVkCj4gPiB0byBkcml2ZXJzL2RtYS1idWYpIHNvb24uIE1heWJlIG1vdmUg dG8gYSBkaWZmZXJlbnQgaGVhZGVyIGluCj4gPiBpbmNsdWRlL2xpbnV4Lz8gbm90IHN1cmUgd2hp Y2ggb25lLgo+ID4gCj4gPiA+IAo+ID4gPiBBbHNvLCB0aGVyZSdzIHRoaXMgdGhhdCBtaWdodCBj b25mbGljdDoKPiA+ID4gCj4gPiA+IGFyY2gvcG93ZXJwYy9rZXJuZWwvc2lnbmFsXzMyLmM6I2Rl ZmluZSB0b191c2VyX3B0cihwKcKgwqDCoMKgwqDCoMKgwqDCoMKgcHRyX3RvX2NvbXBhdChwKQo+ ID4gPiBhcmNoL3Bvd2VycGMva2VybmVsL3NpZ25hbF8zMi5jOiNkZWZpbmUgdG9fdXNlcl9wdHIo cCnCoMKgwqDCoMKgwqDCoMKgwqDCoCgodW5zaWduZWQgbG9uZykocCkpCj4gPiBSaWdodCwgSSds bCBmaWd1cmUgb3V0IGhvdyB0byByZXBsYWNlIHRoZXNlIHR3byB0b28uCj4gVGhlIHBvd2VycGMg dG9fdXNlcl9wdHIgaGFzIGEgZGlmZmVyZW50IG1lYW5pbmcgZnJvbSB0aGUgb25lIEknbSBhZGRp bmcKPiBpbiB0aGlzIHBhdGNoLiBJIHByb3Bvc2Ugd2UganVzdCByZW5hbWUgcG93ZXJwYydzIHRv X3VzZXJfcHRyIHRvCj4gX190b191c2VyX3B0ciBhbmQgbGVhdmUgdGhlIHJlc3QgYXMgaXMuCgpJ IHRoaW5rIHRoYXQncyBub3QgYSBnb29kIGlkZWEsIGFuZCB5b3Ugc2hvdWxkIHJlYWxseSBjaGVj awp0aGlzIGNvbmNlcHQgd2l0aCB0aGUgcG93ZXJwYyBmb2xrIChhZGRlZCB0byB0bzpzIGFuZCBj YzplZCkKCklmIGl0IHdlcmUgcmVhbGx5IGFkZGVkLCB0aGVuIHRoZSBmdW5jdGlvbiBtZWFuaW5n IGlzIGluY29ycmVjdC4KClRoaXMgaXMgdGFraW5nIGEgdTY0LCBjYXN0aW5nIHRoYXQgdG8gKHVu c2lnbmVkIGxvbmcvdWludF9wdHJfdCksCnRoZW4gY29udmVydGluZyB0aGF0IHRvIGEgdXNlciBw b2ludGVyLgoKRG9lcyB0aGF0IG5hbWluZyBhbmQgdXNlIG1ha2Ugc2Vuc2Ugb24geDg2LTMyIG9y IGFybTMyPwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==