diff for duplicates of <1458274308.6622.79.camel@neuling.org> diff --git a/a/1.txt b/N1/1.txt index 62a022d..34c204c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,7 +1,7 @@ On Fri, 2016-03-18 at 15:04 +1100, Michael Neuling wrote: > On Wed, 2016-02-03 at 01:11 +0530, Shilpasri G Bhat wrote: -> +>=20 > > cpu_to_chip_id() does a DT walk through to find out the chip id by > > taking a contended device tree lock. This adds an unnecessary @@ -11,29 +11,31 @@ On Fri, 2016-03-18 at 15:04 +1100, Michael Neuling wrote: > > the chip ids for all cores in the array 'core_to_chip_map' and use > > it > > in the hotpath. -> > +> >=20 > > Reported-by: Anton Blanchard <anton@samba.org> > > Signed-off-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> > > Reviewed-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com> > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > > --- > > No changes from v7. -> +>=20 > How about this instead? It removes the linear lookup and seems a lot > less complex. BTW we never init nr_chips before using it. We also need something like. -diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c +diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cp= +ufreq.c index d63d2cb..c819ed4 100644 --- a/drivers/cpufreq/powernv-cpufreq.c +++ b/drivers/cpufreq/powernv-cpufreq.c @@ -556,6 +556,8 @@ static int init_chip_info(void) unsigned int cpu, i; - unsigned int prev_chip_id = UINT_MAX; - -+ nr_chips = 0; + unsigned int prev_chip_id =3D UINT_MAX; +=20 ++ nr_chips =3D 0; + for_each_possible_cpu(cpu) { - unsigned int id = cpu_to_chip_id(cpu); + unsigned int id =3D cpu_to_chip_id(cpu); +=20 diff --git a/a/content_digest b/N1/content_digest index d374899..7ec1bf1 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -19,7 +19,7 @@ "On Fri, 2016-03-18 at 15:04 +1100, Michael Neuling wrote:\n" "\n" "> On Wed, 2016-02-03 at 01:11 +0530, Shilpasri G Bhat wrote:\n" - "> \n" + ">=20\n" "\n" "> > cpu_to_chip_id() does a DT walk through to find out the chip id by\n" "> > taking a contended device tree lock. This adds an unnecessary\n" @@ -29,31 +29,33 @@ "> > the chip ids for all cores in the array 'core_to_chip_map' and use\n" "> > it\n" "> > in the hotpath.\n" - "> > \n" + "> >=20\n" "> > Reported-by: Anton Blanchard <anton@samba.org>\n" "> > Signed-off-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>\n" "> > Reviewed-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>\n" "> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>\n" "> > ---\n" "> > No changes from v7.\n" - "> \n" + ">=20\n" "> How about this instead? It removes the linear lookup and seems a lot\n" "> less complex.\n" "\n" "BTW we never init nr_chips before using it. We also need something\n" "like.\n" "\n" - "diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c\n" + "diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cp=\n" + "ufreq.c\n" "index d63d2cb..c819ed4 100644\n" "--- a/drivers/cpufreq/powernv-cpufreq.c\n" "+++ b/drivers/cpufreq/powernv-cpufreq.c\n" "@@ -556,6 +556,8 @@ static int init_chip_info(void)\n" " \tunsigned int cpu, i;\n" - " \tunsigned int prev_chip_id = UINT_MAX;\n" - " \n" - "+\tnr_chips = 0;\n" + " \tunsigned int prev_chip_id =3D UINT_MAX;\n" + "=20\n" + "+\tnr_chips =3D 0;\n" "+\n" " \tfor_each_possible_cpu(cpu) {\n" - " \t\tunsigned int id = cpu_to_chip_id(cpu);" + " \t\tunsigned int id =3D cpu_to_chip_id(cpu);\n" + =20 -acd3fb02b0cbcc0bf21b885c8127e116f8ead1f5c761d933b7e230f1084dfe66 +8926986a67ace3ec9921a65953281d9ddb21f4503cb5ed50601c682090bbfd8d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.