From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH v10 2/3] kernel.h: add u64_to_user_ptr() Date: Fri, 18 Mar 2016 08:39:24 -0700 Message-ID: <1458315564.9556.56.camel@perches.com> References: <1458307660-31986-1-git-send-email-gustavo@padovan.org> <1458307660-31986-2-git-send-email-gustavo@padovan.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtprelay.hostedemail.com (smtprelay0075.hostedemail.com [216.40.44.75]) by gabe.freedesktop.org (Postfix) with ESMTPS id 40EDD6E3F9 for ; Fri, 18 Mar 2016 15:39:33 +0000 (UTC) In-Reply-To: <1458307660-31986-2-git-send-email-gustavo@padovan.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan , Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, Daniel Stone , Daniel Vetter , Riley Andrews , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= , Daniel Vetter , akpm@linux-foundation.org, Gustavo Padovan , John Harrison List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAyMDE2LTAzLTE4IGF0IDEwOjI3IC0wMzAwLCBHdXN0YXZvIFBhZG92YW4gd3JvdGU6 Cj4gRnJvbTogR3VzdGF2byBQYWRvdmFuIDxndXN0YXZvLnBhZG92YW5AY29sbGFib3JhLmNvLnVr Pgo+IAo+IFRoaXMgZnVuY3Rpb24gaGFkIGNvcGllcyBpbiAzIGRpZmZlcmVudCBmaWxlcy4gVW5p ZnkgdGhlbSBpbgo+IGtlcm5lbC5oLgoKVGhpcyBmdW5jdGlvbiBtaWdodCBiZSB1c2VkIG1vcmUg aW4gZHJtIGZpbGVzCmluIGEgc2VwYXJhdGUgcGF0Y2ggdG9vOgoKJCBnaXQgZ3JlcCAtbiAtRSAi X191c2VyLipcKFxzKnVpbnRwdHJfdFxzKlwpIiBkcml2ZXJzL2dwdS9kcm0KZHJpdmVycy9ncHUv ZHJtL2FybWFkYS9hcm1hZGFfZ2VtLmM6Mzg1OsKgwqDCoMKgwqDCoMKgwqBwdHIgPSAoY2hhciBf X3VzZXIgKikodWludHB0cl90KWFyZ3MtPnB0cjsKZHJpdmVycy9ncHUvZHJtL2V0bmF2aXYvZXRu YXZpdl9nZW1fc3VibWl0LmM6MzM6wqDCoMKgwqDCoMKgwqDCoHJldHVybiAodm9pZCBfX3VzZXIg KikodWludHB0cl90KWFkZHJlc3M7CmRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2Lmg6MzU4 MTrCoMKgwqByZXR1cm4gKHZvaWQgX191c2VyICopKHVpbnRwdHJfdClhZGRyZXNzOwpkcml2ZXJz L2dwdS9kcm0vbXNtL21zbV9nZW1fc3VibWl0LmM6MzM6wqDCoMKgwqDCoMKgwqDCoHJldHVybiAo dm9pZCBfX3VzZXIgKikodWludHB0cl90KWFkZHJlc3M7CmRyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1 L25vdXZlYXVfZ2VtLmM6NDcxOsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCh2b2lkIF9fZm9yY2UgX191c2VyICopKHVpbnRwdHJfdCl1 c2VyX3BiYm9fcHRyOwpkcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9ub3V2ZWF1X2dlbS5jOjU2ODrC oMKgwqDCoMKgwqB2b2lkIF9fdXNlciAqdXNlcnB0ciA9ICh2b2lkIF9fZm9yY2UgX191c2VyICop KHVpbnRwdHJfdCl1c2VyOwpkcml2ZXJzL2dwdS9kcm0vdGVncmEvZHJtLmM6MzMzOsKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgKHZvaWQgX191c2VyICopKHVpbnRwdHJfdClhcmdzLT5j bWRidWZzOwpkcml2ZXJzL2dwdS9kcm0vdGVncmEvZHJtLmM6MzM1OsKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgKHZvaWQgX191c2VyICopKHVpbnRwdHJfdClhcmdzLT5yZWxvY3M7CmRy aXZlcnMvZ3B1L2RybS90ZWdyYS9kcm0uYzozMzc6wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAodm9pZCBfX3VzZXIgKikodWludHB0cl90KWFyZ3MtPndhaXRjaGtzOwpkcml2ZXJzL2dw dS9kcm0vdGVncmEvZHJtLmM6MzkyOsKgwqDCoMKgwqDCoMKgwqBpZiAoY29weV9mcm9tX3VzZXIo JnN5bmNwdCwgKHZvaWQgX191c2VyICopKHVpbnRwdHJfdClhcmdzLT5zeW5jcHRzLApkcml2ZXJz L2dwdS9kcm0vdmM0L3ZjNF9iby5jOjUwMjrCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCh2b2lkIF9fdXNlciAqKSh1aW50cHRyX3QpYXJncy0+ ZGF0YSwKZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfZ2VtLmM6MTIzOsKgwqDCoMKgwqDCoGlmIChj b3B5X3RvX3VzZXIoKHZvaWQgX191c2VyICopKHVpbnRwdHJfdClnZXRfc3RhdGUtPmJvLApkcml2 ZXJzL2dwdS9kcm0vdmM0L3ZjNF9nZW0uYzo1NTM6wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgKHZvaWQgX191c2VyICopKHVpbnRwdHJfdClhcmdz LT5ib19oYW5kbGVzLApkcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9nZW0uYzo2Mjc6wqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAodm9pZCBfX3VzZXIgKiko dWludHB0cl90KWFyZ3MtPmJpbl9jbCwKZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfZ2VtLmM6NjM0 OsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgKHZvaWQg X191c2VyICopKHVpbnRwdHJfdClhcmdzLT5zaGFkZXJfcmVjLApkcml2ZXJzL2dwdS9kcm0vdmM0 L3ZjNF9nZW0uYzo2NDE6wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAodm9pZCBfX3VzZXIgKikodWludHB0cl90KWFyZ3MtPnVuaWZvcm1zLApkcml2ZXJz L2dwdS9kcm0vdmlydGlvL3ZpcnRncHVfaW9jdGwuYzoxMjY6wqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqB1c2VyX2JvX2hhbmRsZXMgPSAodm9pZCBfX3VzZXIgKikodWludHB0cl90KWV4YnVmLT5i b19oYW5kbGVzOwpkcml2ZXJzL2dwdS9kcm0vdmlydGlvL3ZpcnRncHVfaW9jdGwuYzoxNjE6wqDC oMKgwqDCoGlmIChjb3B5X2Zyb21fdXNlcihidWYsICh2b2lkIF9fdXNlciAqKSh1aW50cHRyX3Qp ZXhidWYtPmNvbW1hbmQsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757474AbcCRPjh (ORCPT ); Fri, 18 Mar 2016 11:39:37 -0400 Received: from smtprelay0091.hostedemail.com ([216.40.44.91]:51414 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752866AbcCRPjd (ORCPT ); Fri, 18 Mar 2016 11:39:33 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3870:3876:4321:5007:6119:6261:6742:7576:7903:10004:10400:10848:11026:11232:11658:11783:11889:11914:12043:12517:12519:12740:13439:13894:14659:14721:21080:30003:30051:30054:30064:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:5,LUA_SUMMARY:none X-HE-Tag: hole49_524551c01911c X-Filterd-Recvd-Size: 3626 Message-ID: <1458315564.9556.56.camel@perches.com> Subject: Re: [PATCH v10 2/3] kernel.h: add u64_to_user_ptr() From: Joe Perches To: Gustavo Padovan , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, Daniel Stone , Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Maarten Lankhorst , Gustavo Padovan , akpm@linux-foundation.org, David Airlie , Daniel Vetter Date: Fri, 18 Mar 2016 08:39:24 -0700 In-Reply-To: <1458307660-31986-2-git-send-email-gustavo@padovan.org> References: <1458307660-31986-1-git-send-email-gustavo@padovan.org> <1458307660-31986-2-git-send-email-gustavo@padovan.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-03-18 at 10:27 -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > This function had copies in 3 different files. Unify them in > kernel.h. This function might be used more in drm files in a separate patch too: $ git grep -n -E "__user.*\(\s*uintptr_t\s*\)" drivers/gpu/drm drivers/gpu/drm/armada/armada_gem.c:385:        ptr = (char __user *)(uintptr_t)args->ptr; drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:33:        return (void __user *)(uintptr_t)address; drivers/gpu/drm/i915/i915_drv.h:3581:   return (void __user *)(uintptr_t)address; drivers/gpu/drm/msm/msm_gem_submit.c:33:        return (void __user *)(uintptr_t)address; drivers/gpu/drm/nouveau/nouveau_gem.c:471:                              (void __force __user *)(uintptr_t)user_pbbo_ptr; drivers/gpu/drm/nouveau/nouveau_gem.c:568:      void __user *userptr = (void __force __user *)(uintptr_t)user; drivers/gpu/drm/tegra/drm.c:333:                (void __user *)(uintptr_t)args->cmdbufs; drivers/gpu/drm/tegra/drm.c:335:                (void __user *)(uintptr_t)args->relocs; drivers/gpu/drm/tegra/drm.c:337:                (void __user *)(uintptr_t)args->waitchks; drivers/gpu/drm/tegra/drm.c:392:        if (copy_from_user(&syncpt, (void __user *)(uintptr_t)args->syncpts, drivers/gpu/drm/vc4/vc4_bo.c:502:                            (void __user *)(uintptr_t)args->data, drivers/gpu/drm/vc4/vc4_gem.c:123:      if (copy_to_user((void __user *)(uintptr_t)get_state->bo, drivers/gpu/drm/vc4/vc4_gem.c:553:                           (void __user *)(uintptr_t)args->bo_handles, drivers/gpu/drm/vc4/vc4_gem.c:627:                         (void __user *)(uintptr_t)args->bin_cl, drivers/gpu/drm/vc4/vc4_gem.c:634:                         (void __user *)(uintptr_t)args->shader_rec, drivers/gpu/drm/vc4/vc4_gem.c:641:                         (void __user *)(uintptr_t)args->uniforms, drivers/gpu/drm/virtio/virtgpu_ioctl.c:126:             user_bo_handles = (void __user *)(uintptr_t)exbuf->bo_handles; drivers/gpu/drm/virtio/virtgpu_ioctl.c:161:     if (copy_from_user(buf, (void __user *)(uintptr_t)exbuf->command,