From: Oliver Neukum <oneukum@suse.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Woojung Huh <woojung.huh@microchip.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
"David S. Miller" <davem@davemloft.net>,
Guenter Roeck <linux@roeck-us.net>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM
Date: Mon, 21 Mar 2016 09:36:01 +0100 [thread overview]
Message-ID: <1458549361.2299.1.camel@suse.com> (raw)
In-Reply-To: <1458470636-18986-1-git-send-email-geert@linux-m68k.org>
On Sun, 2016-03-20 at 11:43 +0100, Geert Uytterhoeven wrote:
> If CONFIG_PM=n:
>
> drivers/net/usb/lan78xx.c: In function ‘lan78xx_get_stats64’:
> drivers/net/usb/lan78xx.c:3274: error: ‘struct dev_pm_info’ has no
> member named ‘runtime_auto’
>
> If PM is disabled, the runtime_auto flag is not available, but auto
> suspend is not enabled anyway. Hence protect the check for
> runtime_auto
> by #ifdef CONFIG_PM to fix this.
>
> Fixes: a59f8c5b048dc938 ("lan78xx: add ndo_get_stats64")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Alternatively, we can add a dev_pm_runtime_auto_is_enabled() wrapper
> to
> include/linux/pm.h, which always return false if CONFIG_PM is
> disabled.
That is what we do for almost everything else in include/pm_runtime.h
So it is the best solution to add the stub.
Regards
Oliver
next prev parent reply other threads:[~2016-03-21 8:36 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-20 10:43 [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM Geert Uytterhoeven
2016-03-20 16:35 ` Eric Dumazet
2016-03-20 20:52 ` David Miller
2016-03-20 22:59 ` Guenter Roeck
2016-03-21 14:59 ` Woojung.Huh
2016-03-21 14:59 ` Woojung.Huh
2016-03-21 8:36 ` Oliver Neukum [this message]
[not found] ` <1458549361.2299.1.camel-IBi9RG/b67k@public.gmane.org>
2016-03-21 14:41 ` Woojung.Huh-UWL1GkI3JZL3oGB3hsPCZA
2016-03-21 14:41 ` Woojung.Huh-UWL1GkI3JZL3oGB3hsPCZA
2016-03-21 14:41 ` Woojung.Huh
2016-03-21 14:57 ` Alan Stern
2016-03-21 14:57 ` Alan Stern
2016-03-21 17:34 ` Oliver Neukum
2016-03-21 18:24 ` Alan Stern
2016-03-21 18:24 ` Alan Stern
2016-03-21 18:42 ` Woojung.Huh
2016-03-21 18:42 ` Woojung.Huh
2016-03-21 19:27 ` Alan Stern
2016-03-21 19:27 ` Alan Stern
2016-03-21 20:09 ` Woojung.Huh
2016-03-21 20:09 ` Woojung.Huh
[not found] ` <9235D6609DB808459E95D78E17F2E43D404CC1EF-8fD0d2gESGrABDY0R+s2SH2Vsf1/G1/XQQ4Iyu8u01E@public.gmane.org>
2016-03-21 21:02 ` Alan Stern
2016-03-21 21:02 ` Alan Stern
2016-03-21 21:02 ` Alan Stern
2016-03-21 18:51 ` Oliver Neukum
2016-03-21 19:30 ` Alan Stern
2016-03-21 19:30 ` Alan Stern
2016-03-22 9:50 ` Oliver Neukum
[not found] ` <1458640209.1990.8.camel-IBi9RG/b67k@public.gmane.org>
2016-03-22 14:21 ` Alan Stern
2016-03-22 14:21 ` Alan Stern
2016-03-22 14:21 ` Alan Stern
2016-03-22 14:28 ` Oliver Neukum
2016-03-22 15:13 ` Alan Stern
2016-03-22 15:13 ` Alan Stern
2016-03-22 15:29 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458549361.2299.1.camel@suse.com \
--to=oneukum@suse.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.