From: "Randle, William C" <william.c.randle@intel.com>
To: "Burton, Ross" <ross.burton@intel.com>, "pb@pbcl.net" <pb@pbcl.net>
Cc: "openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] insane.bbclass: tighten lib_re and exec_re patterns to avoid false positive
Date: Wed, 23 Mar 2016 21:36:19 +0000 [thread overview]
Message-ID: <1458768980.2442.13.camel@intel.com> (raw)
In-Reply-To: <CAJTo0LZL6WKPv+UFNRP9hMO8Ui0F6mLvkKrcM0eBdFJ5bF-pSQ@mail.gmail.com>
On Wed, 2016-03-23 at 21:17 +0000, Burton, Ross wrote:
>
> On 23 March 2016 at 18:03, Phil Blundell <pb@pbcl.net> wrote:
> > Or alternatively, add an extra check so that when it thinks it's found a
> > misplaced library, it checks the ELF header to make sure that it really is
> > one and suppresses the diagnostic if not. If you only do this in cases
> > where it was about to print a warning anyway then the impact on performance
> > shouldn't be too bad.
> >
> Yeah, best of both worlds. A flexible regex to catch potential offenders, and
> then use oe.qa.ELFFile to verify it's actually a library. Can you update the
> patch Bill?
>
Yes, I'll update the patch and repost in a bit.
-Bill
prev parent reply other threads:[~2016-03-23 21:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 15:54 [PATCH] insane.bbclass: tighten lib_re and exec_re patterns to avoid false positive Bill Randle
2016-03-23 16:23 ` Burton, Ross
2016-03-23 16:40 ` Randle, William C
2016-03-23 17:56 ` Phil Blundell
2016-03-23 17:59 ` Burton, Ross
2016-03-23 18:03 ` Phil Blundell
2016-03-23 21:17 ` Burton, Ross
2016-03-23 21:36 ` Randle, William C [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458768980.2442.13.camel@intel.com \
--to=william.c.randle@intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=pb@pbcl.net \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.