From: "K. Y. Srinivasan" <kys@microsoft.com>
To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
vkuznets@redhat.com, jasowang@redhat.com
Cc: "K. Y. Srinivasan" <kys@microsoft.com>, stable@vger.kernel.org
Subject: [PATCH 3/7] Drivers: hv: vmbus: Fix a bug in hv_need_to_signal_on_read()
Date: Wed, 23 Mar 2016 17:53:53 -0700 [thread overview]
Message-ID: <1458780837-4367-3-git-send-email-kys@microsoft.com> (raw)
In-Reply-To: <1458780837-4367-1-git-send-email-kys@microsoft.com>
We need to issue a full memory barrier prior making a signalling decision.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Cc: stable@vger.kernel.org
---
drivers/hv/ring_buffer.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/hv/ring_buffer.c b/drivers/hv/ring_buffer.c
index 2919395..67dc245 100644
--- a/drivers/hv/ring_buffer.c
+++ b/drivers/hv/ring_buffer.c
@@ -104,6 +104,7 @@ static bool hv_need_to_signal_on_read(struct hv_ring_buffer_info *rbi)
u32 cur_write_sz;
u32 pending_sz;
+ mb();
pending_sz = READ_ONCE(rbi->ring_buffer->pending_send_sz);
/* If the other end is not blocked on write don't bother. */
if (pending_sz == 0)
--
1.7.4.1
next prev parent reply other threads:[~2016-03-23 23:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 0:53 [PATCH 0/7] Drivers: hv: vmbus: Cleanup the ring buffer code K. Y. Srinivasan
2016-03-24 0:53 ` [PATCH 1/7] Drivers: hv: vmbus: Introduce functions for estimating room in the ring buffer K. Y. Srinivasan
2016-03-24 0:53 ` [PATCH 2/7] Drivers: hv: vmbus: Use READ_ONCE() to read variables that are volatile K. Y. Srinivasan
2016-04-01 0:00 ` Greg KH
2016-04-01 22:02 ` KY Srinivasan
2016-03-24 0:53 ` K. Y. Srinivasan [this message]
2016-03-31 23:59 ` [PATCH 3/7] Drivers: hv: vmbus: Fix a bug in hv_need_to_signal_on_read() Greg KH
2016-04-01 21:03 ` KY Srinivasan
2016-04-01 0:00 ` Greg KH
2016-04-01 21:57 ` KY Srinivasan
2016-03-24 0:53 ` [PATCH 4/7] Drivers: hv: vmbus: Use the new virt_xx barrier code K. Y. Srinivasan
2016-03-24 0:53 ` [PATCH 5/7] Drivers: hv: vmbus: Export the vmbus_set_event() API K. Y. Srinivasan
2016-03-24 0:53 ` [PATCH 6/7] Drivers: hv: vmbus: Move some ring buffer functions to hyperv.h K. Y. Srinivasan
2016-03-24 0:53 ` [PATCH 7/7] Drivers: hv: vmbus: Implement APIs to support "in place" consumption of vmbus packets K. Y. Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458780837-4367-3-git-send-email-kys@microsoft.com \
--to=kys@microsoft.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=stable@vger.kernel.org \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.