From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com ([192.55.52.120]:28589 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750797AbcCYC7L (ORCPT ); Thu, 24 Mar 2016 22:59:11 -0400 From: Lu Baolu To: baolu.lu@linux.intel.com Cc: Oliver Neukum , stable@vger.kernel.org Subject: [PATCH 01/10] USB: usb_driver_claim_interface: add sanity checking Date: Fri, 25 Mar 2016 10:58:57 +0800 Message-Id: <1458874746-958-1-git-send-email-baolu.lu@linux.intel.com> Sender: stable-owner@vger.kernel.org List-ID: From: Oliver Neukum Attacks that trick drivers into passing a NULL pointer to usb_driver_claim_interface() using forged descriptors are known. This thwarts them by sanity checking. Signed-off-by: Oliver Neukum CC: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/core/driver.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c index 56593a9..2057d91 100644 --- a/drivers/usb/core/driver.c +++ b/drivers/usb/core/driver.c @@ -502,11 +502,15 @@ static int usb_unbind_interface(struct device *dev) int usb_driver_claim_interface(struct usb_driver *driver, struct usb_interface *iface, void *priv) { - struct device *dev = &iface->dev; + struct device *dev; struct usb_device *udev; int retval = 0; int lpm_disable_error; + if (!iface) + return -ENODEV; + + dev = &iface->dev; if (dev->driver) return -EBUSY; -- 2.1.4