From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga14.intel.com ([192.55.52.115]:3888 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754990AbcC1LkA (ORCPT ); Mon, 28 Mar 2016 07:40:00 -0400 From: "Grumbach, Emmanuel" To: linuxwifi , "colin.king@canonical.com" , "kvalo@codeaurora.org" , "Sharon, Sara" , "netdev@vger.kernel.org" , "Berg, Johannes" , "linux-wireless@vger.kernel.org" CC: "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] iwlwifi: pcie: remove duplicate assignment of variable isr_stats Date: Mon, 28 Mar 2016 11:39:14 +0000 Message-ID: <1459165154.9638.3.camel@intel.com> (sfid-20160328_134020_877060_C1A05AFF) References: <1459164824-6994-1-git-send-email-colin.king@canonical.com> In-Reply-To: <1459164824-6994-1-git-send-email-colin.king@canonical.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: T24gTW9uLCAyMDE2LTAzLTI4IGF0IDEyOjMzICswMTAwLCBDb2xpbiBLaW5nIHdyb3RlOg0KPiBG cm9tOiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPg0KPiANCj4gaXNy X3N0YXRzIGlzIHdyaXR0ZW4gdHdpY2Ugd2l0aCB0aGUgc2FtZSB2YWx1ZSwgcmVtb3ZlIG9uZSBv ZiB0aGUNCj4gcmVkdW5kYW50IGFzc2lnbm1lbnRzIHRvIGlzcl9zdGF0cy4NCj4gDQo+IFNpZ25l ZC1vZmYtYnk6IENvbGluIElhbiBLaW5nIDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+DQo+IC0t LQ0KDQoNCkFwcGxpZWQgLSB0aGFua3MuDQoNCj4gIGRyaXZlcnMvbmV0L3dpcmVsZXNzL2ludGVs L2l3bHdpZmkvcGNpZS9yeC5jIHwgMiArLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9u KCspLCAxIGRlbGV0aW9uKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvd2lyZWxl c3MvaW50ZWwvaXdsd2lmaS9wY2llL3J4LmMNCj4gYi9kcml2ZXJzL25ldC93aXJlbGVzcy9pbnRl bC9pd2x3aWZpL3BjaWUvcnguYw0KPiBpbmRleCA0YmUzYzM1Li4yNTNlNGYwIDEwMDY0NA0KPiAt LS0gYS9kcml2ZXJzL25ldC93aXJlbGVzcy9pbnRlbC9pd2x3aWZpL3BjaWUvcnguYw0KPiArKysg Yi9kcml2ZXJzL25ldC93aXJlbGVzcy9pbnRlbC9pd2x3aWZpL3BjaWUvcnguYw0KPiBAQCAtMTgw NSw3ICsxODA1LDcgQEAgaXJxcmV0dXJuX3QgaXdsX3BjaWVfaXJxX21zaXhfaGFuZGxlcihpbnQg aXJxLA0KPiB2b2lkICpkZXZfaWQpDQo+ICAJc3RydWN0IG1zaXhfZW50cnkgKmVudHJ5ID0gZGV2 X2lkOw0KPiAgCXN0cnVjdCBpd2xfdHJhbnNfcGNpZSAqdHJhbnNfcGNpZSA9DQo+IGl3bF9wY2ll X2dldF90cmFuc19wY2llKGVudHJ5KTsNCj4gIAlzdHJ1Y3QgaXdsX3RyYW5zICp0cmFucyA9IHRy YW5zX3BjaWUtPnRyYW5zOw0KPiAtCXN0cnVjdCBpc3Jfc3RhdGlzdGljcyAqaXNyX3N0YXRzID0g aXNyX3N0YXRzID0gJnRyYW5zX3BjaWUNCj4gLT5pc3Jfc3RhdHM7DQo+ICsJc3RydWN0IGlzcl9z dGF0aXN0aWNzICppc3Jfc3RhdHMgPSAmdHJhbnNfcGNpZS0+aXNyX3N0YXRzOw0KPiAgCXUzMiBp bnRhX2ZoLCBpbnRhX2h3Ow0KPiAgDQo+ICAJbG9ja19tYXBfYWNxdWlyZSgmdHJhbnMtPnN5bmNf Y21kX2xvY2tkZXBfbWFwKTs= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755127AbcC1LkD (ORCPT ); Mon, 28 Mar 2016 07:40:03 -0400 Received: from mga14.intel.com ([192.55.52.115]:3888 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754990AbcC1LkA (ORCPT ); Mon, 28 Mar 2016 07:40:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,406,1455004800"; d="scan'208";a="773046629" From: "Grumbach, Emmanuel" To: linuxwifi , "colin.king@canonical.com" , "kvalo@codeaurora.org" , "Sharon, Sara" , "netdev@vger.kernel.org" , "Berg, Johannes" , "linux-wireless@vger.kernel.org" CC: "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] iwlwifi: pcie: remove duplicate assignment of variable isr_stats Thread-Topic: [PATCH] iwlwifi: pcie: remove duplicate assignment of variable isr_stats Thread-Index: AQHRiOW3HEk+Hb1/lk6dpERZLLWpT59uiNEA Date: Mon, 28 Mar 2016 11:39:14 +0000 Message-ID: <1459165154.9638.3.camel@intel.com> References: <1459164824-6994-1-git-send-email-colin.king@canonical.com> In-Reply-To: <1459164824-6994-1-git-send-email-colin.king@canonical.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.12.124.189] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u2SBeAQb008617 On Mon, 2016-03-28 at 12:33 +0100, Colin King wrote: > From: Colin Ian King > > isr_stats is written twice with the same value, remove one of the > redundant assignments to isr_stats. > > Signed-off-by: Colin Ian King > --- Applied - thanks. > drivers/net/wireless/intel/iwlwifi/pcie/rx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c > b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c > index 4be3c35..253e4f0 100644 > --- a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c > +++ b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c > @@ -1805,7 +1805,7 @@ irqreturn_t iwl_pcie_irq_msix_handler(int irq, > void *dev_id) > struct msix_entry *entry = dev_id; > struct iwl_trans_pcie *trans_pcie = > iwl_pcie_get_trans_pcie(entry); > struct iwl_trans *trans = trans_pcie->trans; > - struct isr_statistics *isr_stats = isr_stats = &trans_pcie > ->isr_stats; > + struct isr_statistics *isr_stats = &trans_pcie->isr_stats; > u32 inta_fh, inta_hw; > > lock_map_acquire(&trans->sync_cmd_lockdep_map);