From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
To: "ynezz@true.cz" <ynezz@true.cz>, "khalasa@piap.pl" <khalasa@piap.pl>
Cc: "l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"stefan@agner.ch" <stefan@agner.ch>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"Richard.Zhu@freescale.com" <Richard.Zhu@freescale.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity
Date: Wed, 30 Mar 2016 14:38:08 +0000 [thread overview]
Message-ID: <1459348687.5073.53.camel@toradex.com> (raw)
In-Reply-To: <20160330120644.GM20367@ibawizard.net>
SGkgUGV0cg0KDQpPbiBXZWQsIDIwMTYtMDMtMzAgYXQgMTQ6MDYgKzAyMDAsIFBldHIgxaB0ZXRp
YXIgd3JvdGU6DQo+IEtyenlzenRvZiBIYcWCYXNhIDxraGFsYXNhQHBpYXAucGw+IFsyMDE2LTAz
LTI1IDE0OjMyOjM1XToNCj4gDQo+IEN6ZcWbxIcsDQo+IA0KPiA+IA0KPiA+IEkgd29uZGVyIGlm
IGFsbCBib2FyZHMgKGV4Y2VwdCBtYXliZSB0aGF0IFRvcmFkZXggc2V0KSB1c2UgYW4NCj4gPiBh
Y3RpdmUtbG93DQo+ID4gUENJZSByZXNldCBhbmQgYXJlIG5vdyBicm9rZW4uIFBlcmhhcHMgVG9y
YWRleCB1c2VzIGFjdGl2ZS1oaWdoIGFuZA0KPiA+IHRodXMNCj4gPiB3b3Jrcy4NCj4gSSdtIHJl
YWxseSBwdXp6bGVkIGJ5IHRoaXMgOi0pIFdpdGggeW91ciBwYXRjaCBhcHBsaWVkIEkgZ2V0DQo+
IGZvbGxvd2luZyBvbg0KPiBUb3JhZGV4IEFwYWxpcyBtb2R1bGVzOg0KPiANCj4gwqBEVFM6wqDC
oMKgwqDCoMKgwqDCoMKgcmVzZXQtZ3BpbyA9IDwmZ3BpbzEgMjggR1BJT19BQ1RJVkVfTE9XPjsN
Cj4gwqBkbWVzZzrCoMKgwqDCoMKgwqDCoGlteDZxLXBjaWUgMWZmYzAwMC5wY2llOiBwaHkgbGlu
ayBuZXZlciBjYW1lIHVwDQo+IMKgZ3BpbzrCoMKgwqDCoMKgwqDCoMKgZ3Bpby0yOMKgwqAowqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHxyZXNldMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoCkNCj4gb3V0IGhpDQo+IMKgcGluIHZvbHRhZ2U6IDBWDQo+IA0KPiDC
oERUUzrCoMKgwqDCoMKgwqDCoMKgwqByZXNldC1ncGlvID0gPCZncGlvMSAyOCBHUElPX0FDVElW
RV9ISUdIPjsNCj4gwqBkbWVzZzrCoMKgwqDCoMKgwqDCoGF0aDlrIDAwMDA6MDE6MDAuMDogZW5h
YmxpbmcgZGV2aWNlICgwMTQwIC0+IDAxNDIpDQo+IMKgZ3BpbzrCoMKgwqDCoMKgwqDCoMKgZ3Bp
by0yOMKgwqAowqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHxyZXNldMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCkNCj4gb3V0IGxvDQo+IMKgcGluIHZvbHRhZ2U6
IDNWMw0KPiANCj4gU28gVG9yYWRleCBBcGFsaXMgaXMgYWN0dWFsbHkgYWN0aXZlLWhpZ2g/DQoN
ClllcywgSSBhY3R1YWxseSBleHBsYWluZWQgdGhpcyBpbiBkZXRhaWwgaW4gbXkgY292ZXIgbGV0
dGVyOg0KDQpodHRwOi8vYXJ0aWNsZS5nbWFuZS5vcmcvZ21hbmUubGludXguZHJpdmVycy5kZXZp
Y2V0cmVlLzE1NDgyOQ0KDQo+ICBUaGFua3MuDQo+IA0KPiAtLSB5bmV6eg0KDQoNCkNoZWVycw0K
DQpNYXJjZWwNCg==
WARNING: multiple messages have this Message-ID (diff)
From: marcel.ziswiler@toradex.com (Marcel Ziswiler)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity
Date: Wed, 30 Mar 2016 14:38:08 +0000 [thread overview]
Message-ID: <1459348687.5073.53.camel@toradex.com> (raw)
In-Reply-To: <20160330120644.GM20367@ibawizard.net>
Hi Petr
On Wed, 2016-03-30 at 14:06 +0200, Petr ?tetiar wrote:
> Krzysztof Ha?asa <khalasa@piap.pl> [2016-03-25 14:32:35]:
>
> Cze??,
>
> >
> > I wonder if all boards (except maybe that Toradex set) use an
> > active-low
> > PCIe reset and are now broken. Perhaps Toradex uses active-high and
> > thus
> > works.
> I'm really puzzled by this :-) With your patch applied I get
> following on
> Toradex Apalis modules:
>
> ?DTS:?????????reset-gpio = <&gpio1 28 GPIO_ACTIVE_LOW>;
> ?dmesg:???????imx6q-pcie 1ffc000.pcie: phy link never came up
> ?gpio:????????gpio-28??(????????????????????|reset???????????????)
> out hi
> ?pin voltage: 0V
>
> ?DTS:?????????reset-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
> ?dmesg:???????ath9k 0000:01:00.0: enabling device (0140 -> 0142)
> ?gpio:????????gpio-28??(????????????????????|reset???????????????)
> out lo
> ?pin voltage: 3V3
>
> So Toradex Apalis is actually active-high?
Yes, I actually explained this in detail in my cover letter:
http://article.gmane.org/gmane.linux.drivers.devicetree/154829
> Thanks.
>
> -- ynezz
Cheers
Marcel
WARNING: multiple messages have this Message-ID (diff)
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
To: "ynezz@true.cz" <ynezz@true.cz>, "khalasa@piap.pl" <khalasa@piap.pl>
Cc: "l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"stefan@agner.ch" <stefan@agner.ch>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"Richard.Zhu@freescale.com" <Richard.Zhu@freescale.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity
Date: Wed, 30 Mar 2016 14:38:08 +0000 [thread overview]
Message-ID: <1459348687.5073.53.camel@toradex.com> (raw)
In-Reply-To: <20160330120644.GM20367@ibawizard.net>
Hi Petr
On Wed, 2016-03-30 at 14:06 +0200, Petr Štetiar wrote:
> Krzysztof Hałasa <khalasa@piap.pl> [2016-03-25 14:32:35]:
>
> Cześć,
>
> >
> > I wonder if all boards (except maybe that Toradex set) use an
> > active-low
> > PCIe reset and are now broken. Perhaps Toradex uses active-high and
> > thus
> > works.
> I'm really puzzled by this :-) With your patch applied I get
> following on
> Toradex Apalis modules:
>
> DTS: reset-gpio = <&gpio1 28 GPIO_ACTIVE_LOW>;
> dmesg: imx6q-pcie 1ffc000.pcie: phy link never came up
> gpio: gpio-28 ( |reset )
> out hi
> pin voltage: 0V
>
> DTS: reset-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
> dmesg: ath9k 0000:01:00.0: enabling device (0140 -> 0142)
> gpio: gpio-28 ( |reset )
> out lo
> pin voltage: 3V3
>
> So Toradex Apalis is actually active-high?
Yes, I actually explained this in detail in my cover letter:
http://article.gmane.org/gmane.linux.drivers.devicetree/154829
> Thanks.
>
> -- ynezz
Cheers
Marcel
next prev parent reply other threads:[~2016-03-30 16:10 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-25 13:32 [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Krzysztof Hałasa
2016-03-25 13:32 ` Krzysztof Hałasa
2016-03-27 14:44 ` Fabio Estevam
2016-03-27 14:44 ` Fabio Estevam
2016-03-28 0:26 ` Fabio Estevam
2016-03-28 0:26 ` Fabio Estevam
2016-03-28 19:59 ` Tim Harvey
2016-03-28 19:59 ` Tim Harvey
2016-03-28 20:13 ` Fabio Estevam
2016-03-28 20:13 ` Fabio Estevam
2016-03-28 20:42 ` Tim Harvey
2016-03-28 20:42 ` Tim Harvey
2016-03-28 21:30 ` Fabio Estevam
2016-03-28 21:30 ` Fabio Estevam
2016-03-28 22:06 ` Tim Harvey
2016-03-28 22:06 ` Tim Harvey
2016-03-28 22:13 ` Fabio Estevam
2016-03-28 22:13 ` Fabio Estevam
2016-03-29 5:40 ` Krzysztof Hałasa
2016-03-29 5:40 ` Krzysztof Hałasa
2016-03-29 5:43 ` Krzysztof Hałasa
2016-03-29 5:43 ` Krzysztof Hałasa
2016-03-29 5:29 ` Krzysztof Hałasa
2016-03-29 5:29 ` Krzysztof Hałasa
2016-03-29 8:55 ` Lucas Stach
2016-03-29 8:55 ` Lucas Stach
2016-03-29 10:39 ` Krzysztof Hałasa
2016-03-29 10:39 ` Krzysztof Hałasa
2016-03-29 10:55 ` Lucas Stach
2016-03-29 10:55 ` Lucas Stach
2016-03-29 13:12 ` Arnd Bergmann
2016-03-29 13:12 ` Arnd Bergmann
2016-03-29 13:32 ` Tim Harvey
2016-03-29 13:32 ` Tim Harvey
2016-03-29 13:52 ` Arnd Bergmann
2016-03-29 13:52 ` Arnd Bergmann
2016-03-29 14:29 ` Tim Harvey
2016-03-29 14:29 ` Tim Harvey
2016-03-29 14:50 ` Arnd Bergmann
2016-03-29 14:50 ` Arnd Bergmann
2016-03-29 15:10 ` Tim Harvey
2016-03-29 15:10 ` Tim Harvey
2016-03-29 15:24 ` Arnd Bergmann
2016-03-29 15:24 ` Arnd Bergmann
2016-03-29 17:38 ` Tim Harvey
2016-03-29 17:38 ` Tim Harvey
2016-03-29 19:39 ` Arnd Bergmann
2016-03-29 19:39 ` Arnd Bergmann
2016-03-29 17:56 ` Marc Zyngier
2016-03-29 17:56 ` Marc Zyngier
2016-03-29 16:13 ` Roberto Fichera
2016-03-29 16:13 ` Roberto Fichera
2016-03-29 16:40 ` Tim Harvey
2016-03-29 16:40 ` Tim Harvey
2016-03-29 16:44 ` Roberto Fichera
2016-03-29 16:44 ` Roberto Fichera
2016-03-29 17:31 ` Tim Harvey
2016-03-29 17:31 ` Tim Harvey
2016-03-30 8:00 ` Roberto Fichera
2016-03-30 8:00 ` Roberto Fichera
2016-03-30 10:10 ` Arnd Bergmann
2016-03-30 10:10 ` Arnd Bergmann
2016-03-30 12:50 ` Roberto Fichera
2016-03-30 12:50 ` Roberto Fichera
2016-03-30 13:38 ` Tim Harvey
2016-03-30 13:38 ` Tim Harvey
2016-03-30 15:20 ` Roberto Fichera
2016-03-30 15:20 ` Roberto Fichera
2016-03-30 8:10 ` Krzysztof Hałasa
2016-03-30 8:10 ` Krzysztof Hałasa
2016-03-31 16:19 ` Tim Harvey
2016-03-31 16:19 ` Tim Harvey
2016-04-04 10:37 ` Krzysztof Hałasa
2016-04-04 10:37 ` Krzysztof Hałasa
2016-03-29 14:14 ` Fabio Estevam
2016-03-29 14:14 ` Fabio Estevam
2016-03-29 5:21 ` Krzysztof Hałasa
2016-03-29 5:21 ` Krzysztof Hałasa
2016-03-30 12:06 ` Petr Štetiar
2016-03-30 12:06 ` Petr Štetiar
2016-03-30 12:45 ` Fabio Estevam
2016-03-30 12:45 ` Fabio Estevam
2016-03-30 14:38 ` Marcel Ziswiler [this message]
2016-03-30 14:38 ` Marcel Ziswiler
2016-03-30 14:38 ` Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459348687.5073.53.camel@toradex.com \
--to=marcel.ziswiler@toradex.com \
--cc=Richard.Zhu@freescale.com \
--cc=bhelgaas@google.com \
--cc=khalasa@piap.pl \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=stefan@agner.ch \
--cc=ynezz@true.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.