From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-db5eur01on0095.outbound.protection.outlook.com ([104.47.2.95]:42016 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752794AbcC3QKZ (ORCPT ); Wed, 30 Mar 2016 12:10:25 -0400 From: Marcel Ziswiler To: "ynezz@true.cz" , "khalasa@piap.pl" CC: "l.stach@pengutronix.de" , "linux-arm-kernel@lists.infradead.org" , "linux-pci@vger.kernel.org" , "stefan@agner.ch" , "bhelgaas@google.com" , "Richard.Zhu@freescale.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Date: Wed, 30 Mar 2016 14:38:08 +0000 Message-ID: <1459348687.5073.53.camel@toradex.com> References: <20160330120644.GM20367@ibawizard.net> In-Reply-To: <20160330120644.GM20367@ibawizard.net> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org List-ID: SGkgUGV0cg0KDQpPbiBXZWQsIDIwMTYtMDMtMzAgYXQgMTQ6MDYgKzAyMDAsIFBldHIgxaB0ZXRp YXIgd3JvdGU6DQo+IEtyenlzenRvZiBIYcWCYXNhIDxraGFsYXNhQHBpYXAucGw+IFsyMDE2LTAz LTI1IDE0OjMyOjM1XToNCj4gDQo+IEN6ZcWbxIcsDQo+IA0KPiA+IA0KPiA+IEkgd29uZGVyIGlm IGFsbCBib2FyZHMgKGV4Y2VwdCBtYXliZSB0aGF0IFRvcmFkZXggc2V0KSB1c2UgYW4NCj4gPiBh Y3RpdmUtbG93DQo+ID4gUENJZSByZXNldCBhbmQgYXJlIG5vdyBicm9rZW4uIFBlcmhhcHMgVG9y YWRleCB1c2VzIGFjdGl2ZS1oaWdoIGFuZA0KPiA+IHRodXMNCj4gPiB3b3Jrcy4NCj4gSSdtIHJl YWxseSBwdXp6bGVkIGJ5IHRoaXMgOi0pIFdpdGggeW91ciBwYXRjaCBhcHBsaWVkIEkgZ2V0DQo+ IGZvbGxvd2luZyBvbg0KPiBUb3JhZGV4IEFwYWxpcyBtb2R1bGVzOg0KPiANCj4gwqBEVFM6wqDC oMKgwqDCoMKgwqDCoMKgcmVzZXQtZ3BpbyA9IDwmZ3BpbzEgMjggR1BJT19BQ1RJVkVfTE9XPjsN Cj4gwqBkbWVzZzrCoMKgwqDCoMKgwqDCoGlteDZxLXBjaWUgMWZmYzAwMC5wY2llOiBwaHkgbGlu ayBuZXZlciBjYW1lIHVwDQo+IMKgZ3BpbzrCoMKgwqDCoMKgwqDCoMKgZ3Bpby0yOMKgwqAowqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHxyZXNldMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCkNCj4gb3V0IGhpDQo+IMKgcGluIHZvbHRhZ2U6IDBWDQo+IA0KPiDC oERUUzrCoMKgwqDCoMKgwqDCoMKgwqByZXNldC1ncGlvID0gPCZncGlvMSAyOCBHUElPX0FDVElW RV9ISUdIPjsNCj4gwqBkbWVzZzrCoMKgwqDCoMKgwqDCoGF0aDlrIDAwMDA6MDE6MDAuMDogZW5h YmxpbmcgZGV2aWNlICgwMTQwIC0+IDAxNDIpDQo+IMKgZ3BpbzrCoMKgwqDCoMKgwqDCoMKgZ3Bp by0yOMKgwqAowqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHxyZXNldMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCkNCj4gb3V0IGxvDQo+IMKgcGluIHZvbHRhZ2U6 IDNWMw0KPiANCj4gU28gVG9yYWRleCBBcGFsaXMgaXMgYWN0dWFsbHkgYWN0aXZlLWhpZ2g/DQoN ClllcywgSSBhY3R1YWxseSBleHBsYWluZWQgdGhpcyBpbiBkZXRhaWwgaW4gbXkgY292ZXIgbGV0 dGVyOg0KDQpodHRwOi8vYXJ0aWNsZS5nbWFuZS5vcmcvZ21hbmUubGludXguZHJpdmVycy5kZXZp Y2V0cmVlLzE1NDgyOQ0KDQo+ICBUaGFua3MuDQo+IA0KPiAtLSB5bmV6eg0KDQoNCkNoZWVycw0K DQpNYXJjZWwNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: marcel.ziswiler@toradex.com (Marcel Ziswiler) Date: Wed, 30 Mar 2016 14:38:08 +0000 Subject: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity In-Reply-To: <20160330120644.GM20367@ibawizard.net> References: <20160330120644.GM20367@ibawizard.net> Message-ID: <1459348687.5073.53.camel@toradex.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Petr On Wed, 2016-03-30 at 14:06 +0200, Petr ?tetiar wrote: > Krzysztof Ha?asa [2016-03-25 14:32:35]: > > Cze??, > > > > > I wonder if all boards (except maybe that Toradex set) use an > > active-low > > PCIe reset and are now broken. Perhaps Toradex uses active-high and > > thus > > works. > I'm really puzzled by this :-) With your patch applied I get > following on > Toradex Apalis modules: > > ?DTS:?????????reset-gpio = <&gpio1 28 GPIO_ACTIVE_LOW>; > ?dmesg:???????imx6q-pcie 1ffc000.pcie: phy link never came up > ?gpio:????????gpio-28??(????????????????????|reset???????????????) > out hi > ?pin voltage: 0V > > ?DTS:?????????reset-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>; > ?dmesg:???????ath9k 0000:01:00.0: enabling device (0140 -> 0142) > ?gpio:????????gpio-28??(????????????????????|reset???????????????) > out lo > ?pin voltage: 3V3 > > So Toradex Apalis is actually active-high? Yes, I actually explained this in detail in my cover letter: http://article.gmane.org/gmane.linux.drivers.devicetree/154829 > Thanks. > > -- ynezz Cheers Marcel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754277AbcC3QK1 (ORCPT ); Wed, 30 Mar 2016 12:10:27 -0400 Received: from mail-db5eur01on0095.outbound.protection.outlook.com ([104.47.2.95]:42016 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752794AbcC3QKZ (ORCPT ); Wed, 30 Mar 2016 12:10:25 -0400 X-Greylist: delayed 4643 seconds by postgrey-1.27 at vger.kernel.org; Wed, 30 Mar 2016 12:10:24 EDT From: Marcel Ziswiler To: "ynezz@true.cz" , "khalasa@piap.pl" CC: "l.stach@pengutronix.de" , "linux-arm-kernel@lists.infradead.org" , "linux-pci@vger.kernel.org" , "stefan@agner.ch" , "bhelgaas@google.com" , "Richard.Zhu@freescale.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Thread-Topic: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Thread-Index: AQHRipHHS4a8mRXTv0+mnzdnc4HLKA== Date: Wed, 30 Mar 2016 14:38:08 +0000 Message-ID: <1459348687.5073.53.camel@toradex.com> References: <20160330120644.GM20367@ibawizard.net> In-Reply-To: <20160330120644.GM20367@ibawizard.net> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: true.cz; dkim=none (message not signed) header.d=none;true.cz; dmarc=none action=none header.from=toradex.com; x-originating-ip: [46.140.72.82] x-ms-office365-filtering-correlation-id: 742a470b-12c7-4e15-cc9f-08d358a8ea05 x-microsoft-exchange-diagnostics: 1;HE1PR05MB1882;5:kY+iSDnhhA5i4nIJYxDdn8it+sCOwS0doSN+v5cIg6fY+OMouXb6HLblxK5ruDoQND9k6TqtajAiT1rntUQiB16piEJFs3Shk5JZrM7H7xpC4E0uisabvRm2twYvvM7Xbwi8xwaQ6hcY7XJrIRlmRA==;24:iuADDTB3j6nCNpSJ3UgO3UadEFUFVacQFhPI4fOF5ZcMbDm4bwYJmcPoLeynSSbaEM7Vhp2BLyo7bo4het4OY0VZZRJTKWw5eGzlBDcF/3I= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB1882; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:HE1PR05MB1882;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB1882; x-forefront-prvs: 08978A8F5C x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(54094003)(377424004)(24454002)(36756003)(103116003)(87936001)(81166005)(122556002)(3280700002)(4326007)(3660700001)(1096002)(2501003)(2906002)(1220700001)(5002640100001)(33646002)(189998001)(77096005)(102836003)(5001770100001)(6116002)(3846002)(586003)(11100500001)(5004730100002)(15975445007)(2950100001)(2900100001)(92566002)(86362001)(106116001)(54356999)(10400500002)(5008740100001)(76176999)(50986999)(19580405001)(66066001)(19580395003)(15760500001)(7059030);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR05MB1882;H:HE1PR05MB1882.eurprd05.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <1847B3F49C51FC4296F15641BEE67308@eurprd05.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: toradex.com X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2016 14:38:08.8370 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d9995866-0d9b-4251-8315-093f062abab4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB1882 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u2UGAWPd023621 Hi Petr On Wed, 2016-03-30 at 14:06 +0200, Petr Štetiar wrote: > Krzysztof Hałasa [2016-03-25 14:32:35]: > > Cześć, > > > > > I wonder if all boards (except maybe that Toradex set) use an > > active-low > > PCIe reset and are now broken. Perhaps Toradex uses active-high and > > thus > > works. > I'm really puzzled by this :-) With your patch applied I get > following on > Toradex Apalis modules: > >  DTS:         reset-gpio = <&gpio1 28 GPIO_ACTIVE_LOW>; >  dmesg:       imx6q-pcie 1ffc000.pcie: phy link never came up >  gpio:        gpio-28  (                    |reset               ) > out hi >  pin voltage: 0V > >  DTS:         reset-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>; >  dmesg:       ath9k 0000:01:00.0: enabling device (0140 -> 0142) >  gpio:        gpio-28  (                    |reset               ) > out lo >  pin voltage: 3V3 > > So Toradex Apalis is actually active-high? Yes, I actually explained this in detail in my cover letter: http://article.gmane.org/gmane.linux.drivers.devicetree/154829 > Thanks. > > -- ynezz Cheers Marcel