From: Johannes Berg <johannes@sipsolutions.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Ben Greear <greearb@candelatech.com>,
David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, tgraf@suug.ch
Subject: Re: Question on rhashtable in worst-case scenario.
Date: Thu, 31 Mar 2016 17:29:59 +0200 [thread overview]
Message-ID: <1459438199.4576.26.camel@sipsolutions.net> (raw)
In-Reply-To: <20160331075015.GA27716@gondor.apana.org.au>
On Thu, 2016-03-31 at 15:50 +0800, Herbert Xu wrote:
> On Thu, Mar 31, 2016 at 09:46:45AM +0200, Johannes Berg wrote:
> >
> >
> > In this case, I think perhaps you can just patch your local system
> > with
> > the many interfaces connecting to the same AP to add the parameter
> > Herbert suggested (.insecure_elasticity = true in sta_rht_params).
> > This
> > is, after all, very much a case that "normal" operation doesn't
> > even
> > get close to.
> I think you should just turn it on everywhere for mac80211. Chain
> length checks simply don't make sense when you allow duplicate
> keys in the hash table.
Yes, that's a good point, and we can - in certain corner cases - end up
with duplicate keys even in normal operation.
Does removing this completely disable the "-EEXIST" error? I can't say
I fully understand the elasticity stuff in __rhashtable_insert_fast().
johannes
next prev parent reply other threads:[~2016-03-31 15:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-28 20:29 Question on rhashtable in worst-case scenario Ben Greear
2016-03-29 16:16 ` Ben Greear
2016-03-30 9:14 ` Johannes Berg
2016-03-30 13:55 ` Herbert Xu
2016-03-30 13:55 ` Herbert Xu
2016-03-30 14:03 ` Johannes Berg
2016-03-30 14:09 ` Herbert Xu
2016-03-30 16:38 ` David Miller
2016-03-30 16:52 ` Ben Greear
2016-03-31 7:46 ` Johannes Berg
2016-03-31 7:50 ` Herbert Xu
2016-03-31 15:29 ` Johannes Berg [this message]
2016-04-01 0:46 ` Herbert Xu
2016-04-01 18:17 ` Ben Greear
2016-04-01 21:34 ` Johannes Berg
2016-04-02 1:46 ` Herbert Xu
2016-04-02 18:33 ` Johannes Berg
2016-03-31 15:13 ` Ben Greear
2016-03-31 15:22 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459438199.4576.26.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=greearb@candelatech.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.