From: "Jörg Krause" <joerg.krause@embedded.rocks>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] yajl: disable parallel build
Date: Fri, 01 Apr 2016 20:38:17 +0200 [thread overview]
Message-ID: <1459535897.5657.5.camel@embedded.rocks> (raw)
In-Reply-To: <20160331211446.4727873e@free-electrons.com>
Dear Thomas,
On Do, 2016-03-31 at 21:14 +0200, Thomas Petazzoni wrote:
> Hello,
>
> On Thu, 31 Mar 2016 21:01:01 +0200, J?rg Krause wrote:
> >
> > The yajl build system contains a race condition, which gets
> > triggered by
> > high BR2_JLEVEL settings - It tries to link the executable gen-
> > extra-close
> > against libyajl before it is created:
> >
> > [ 21%] Linking C executable gen-extra-close
> > [ 26%] Building C object src/CMakeFiles/yajl_s.dir/yajl_buf.c.o
> > /home/test/autobuild/instance-3/output/host/opt/ext-toolchain/bfin-
> > uclinux/bfin-uclinux/bin/ld.real: cannot find -lyajl
> >
> > Fix it by disabling parallel build.
> >
> > Fixes:
> > http://autobuild.buildroot.net/results/a9b/a9b5209377acb51e69f376e0
> > c008ee71fe00397a/
> > http://autobuild.buildroot.net/results/55f/55fe22463d49addb42b635d1
> > 0be5176522f4a561/
> > http://autobuild.buildroot.net/results/808/808acca0cfed93465845c2aa
> > 055a7a4fc56a8a17/
> > http://autobuild.buildroot.net/results/b92/b92a9c84b71a8a2d022d3072
> > 45ca6be36a000e6c/
> > http://autobuild.buildroot.net/results/55d/55df698ab53f7d94235166e8
> > 576eb681ed68668e/
> > .. and more.
> >
> > Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> yajl is using a reasonable build system, so there should be a
> reasonable way of getting parallel build to work.
>
> Can you try the following patch:
>
> diff --git a/test/api/CMakeLists.txt b/test/api/CMakeLists.txt
> index cd65a54..f7b6be1 100644
> --- a/test/api/CMakeLists.txt
> +++ b/test/api/CMakeLists.txt
> @@ -22,4 +22,5 @@ FOREACH (test ${TESTS})
> ???GET_FILENAME_COMPONENT(testProg ${test} NAME_WE)
> ???ADD_EXECUTABLE(${testProg} ${test})
> ???TARGET_LINK_LIBRARIES(${testProg} yajl)
> +??ADD_DEPENDENCIES(${testProg} yajl)
> ?ENDFOREACH()
>
> And see if it helps ?
>
> Note: this is only fixing the dependency of the gen-extra-close test
> program against the yajl library. Probably other ADD_DEPENDENCIES()
> invocations need to be added.
This was my first try and it did not work. However, after having a
closer look the dependency is yajl_s.
I'll sent a v2 for this. Many thanks for looking into this!
J?rg
prev parent reply other threads:[~2016-04-01 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 19:01 [Buildroot] [PATCH] yajl: disable parallel build Jörg Krause
2016-03-31 19:14 ` Thomas Petazzoni
2016-04-01 18:38 ` Jörg Krause [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459535897.5657.5.camel@embedded.rocks \
--to=joerg.krause@embedded.rocks \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.