From: Jason Gerecke <killertofu@gmail.com>
To: linux-input@vger.kernel.org
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Ping Cheng <pinglinux@gmail.com>, Jiri Kosina <jkosina@suse.cz>,
Jason Gerecke <killertofu@gmail.com>,
Jason Gerecke <jason.gerecke@wacom.com>
Subject: [PATCH v2 1/2] HID: wacom: Initialize hid_data.inputmode to -1
Date: Mon, 4 Apr 2016 11:26:51 -0700 [thread overview]
Message-ID: <1459794412-10306-1-git-send-email-killertofu@gmail.com> (raw)
In-Reply-To: <56FD84F4.6060707@gmail.com>
Commit 5ae6e89 introduced hid_data.inputmode with a comment that it
would have the value -1 if undefined, but then forgot to actually
perform the initialization. Although this doesn't appear to have
caused any problems in practice, it should still be remedied.
Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
---
Changes from v1:
* Introduce this patch
drivers/hid/wacom_sys.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
index 68a5609..b338bbf 100644
--- a/drivers/hid/wacom_sys.c
+++ b/drivers/hid/wacom_sys.c
@@ -1817,6 +1817,8 @@ static int wacom_probe(struct hid_device *hdev,
goto fail_type;
}
+ wacom_wac->hid_data.inputmode = -1;
+
wacom->usbdev = dev;
wacom->intf = intf;
mutex_init(&wacom->lock);
--
2.7.3
next prev parent reply other threads:[~2016-04-04 18:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-28 20:10 [PATCH] HID: wacom: Support switching from vendor-defined input format on G9 and G11 Jason Gerecke
2016-03-29 7:05 ` Benjamin Tissoires
2016-03-29 17:15 ` Jason Gerecke
2016-03-30 9:24 ` Benjamin Tissoires
2016-03-31 20:13 ` Jason Gerecke
2016-04-04 18:26 ` Jason Gerecke [this message]
2016-04-04 18:26 ` [PATCH v2 2/2] HID: wacom: Support switching from vendor-defined device mode " Jason Gerecke
2016-04-04 20:54 ` Benjamin Tissoires
2016-04-05 15:22 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459794412-10306-1-git-send-email-killertofu@gmail.com \
--to=killertofu@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jason.gerecke@wacom.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=pinglinux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.