From: Johannes Berg <johannes@sipsolutions.net>
To: Jeff Mahoney <jeffm@suse.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: fix "warning: ‘target_metric’ may be used uninitialized"
Date: Tue, 05 Apr 2016 15:40:19 +0200 [thread overview]
Message-ID: <1459863619.18188.50.camel@sipsolutions.net> (raw)
In-Reply-To: <5703BEA7.3040406@suse.com>
On Tue, 2016-04-05 at 09:33 -0400, Jeff Mahoney wrote:
> On 4/5/16 5:43 AM, Johannes Berg wrote:
> >
> > On Mon, 2016-04-04 at 14:15 -0400, Jeff Mahoney wrote:
> > >
> > > This fixes:
> > >
> > > net/mac80211/mesh_hwmp.c:603:26: warning: ‘target_metric’ may be
> > > used
> > > uninitialized in this function
> > >
> > > target_metric is only consumed when reply = true so no bug exists
> > > here,
> > > but gcc doesn't notice that. Initializing to 0 clears the
> > > warning.
> > >
> > What gcc version are you using? Mine doesn't seem to have a problem
> > following the logic here.
> gcc version 4.8.5 (SUSE Linux)
Ok, mine's significantly newer:
gcc (Debian 5.3.1-10) 5.3.1 20160224
I do wonder though if we really should do this? It might hide errors
later on?
johannes
next prev parent reply other threads:[~2016-04-05 13:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 18:15 [PATCH] mac80211: fix "warning: ‘target_metric’ may be used uninitialized" Jeff Mahoney
2016-04-05 9:43 ` Johannes Berg
2016-04-05 13:33 ` Jeff Mahoney
2016-04-05 13:40 ` Johannes Berg [this message]
2016-04-05 13:47 ` Jeff Mahoney
2016-04-06 13:14 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459863619.18188.50.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jeffm@suse.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.