From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Koul, Vinod" Subject: Re: [PATCH v2 2/2] conf: topology: Generate Private data binary blobs Date: Tue, 5 Apr 2016 16:08:55 +0000 Message-ID: <1459872533.3136.49.camel@intel.com> References: <1459833605-11223-1-git-send-email-vinod.koul@intel.com> <1459833605-11223-3-git-send-email-vinod.koul@intel.com> <1459867127.3136.39.camel@intel.com> <1459871538.3136.42.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by alsa0.perex.cz (Postfix) with ESMTP id AF34C2612CC for ; Tue, 5 Apr 2016 18:10:19 +0200 (CEST) In-Reply-To: Content-Language: en-US Content-ID: <5BD1CF15830A264FAA00BB0687E91287@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: "tiwai@suse.de" Cc: "liam.r.girdwood@linux.intel.com" , Patches Audio , "alsa-devel@alsa-project.org" , "broonie@kernel.org" , "Nc, Shreyas" List-Id: alsa-devel@alsa-project.org On Tue, 2016-04-05 at 18:05 +0200, Takashi Iwai wrote: > On Tue, 05 Apr 2016 17:52:19 +0200, > Koul, Vinod wrote: > > > > On Tue, 2016-04-05 at 16:45 +0200, Takashi Iwai wrote: > > > > There is no special dependency here, so we can just add > > > > > src/conf/toplogty/*/data/Makefile.am in the toplevel > > > > > configure.ac? > > > > > > > > Yes that seems better. Also please note if we do that alsa-lib > > > > can > > > > compile the data before it compiles skl topology so we can get > > > > rid > > > > of > > > > bnary blobs whcih are prebuilt and get them generated on alsa > > > > -lib > > > > compile. > > > > > > Yeah, that's nicer, too. > > > > One thing though we need to run the binary to generate blobs, am > > thinking of hooking that up with install step. > > Compiling something at installation is wrong in general. Nope that's not what I meant. We will compile the tool and create the binary at alsa-lib compile step. Then we need to run that to generate the binary blobs and that can be done at install step -- ~Vinod