From: Johannes Berg <johannes@sipsolutions.net>
To: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: linux-wireless@vger.kernel.org,
Andrei Otcheretianski <andrei.otcheretianski@intel.com>
Subject: Re: [PATCHv3 RESEND 03/11] cfg80211: add add_nan_func / rm_nan_func
Date: Wed, 06 Apr 2016 10:47:51 +0200 [thread overview]
Message-ID: <1459932471.17504.35.camel@sipsolutions.net> (raw)
In-Reply-To: <1459244109-16038-3-git-send-email-emmanuel.grumbach@intel.com>
> + NL80211_ATTR_NAN_FUNC_INST_ID,
I don't see why this has to be a top-level attribute.
> +enum nl80211_nan_func_attributes {
> + __NL80211_NAN_FUNC_INVALID,
> + NL80211_NAN_FUNC_TYPE,
You can easily move it into here, and
> + /* propagate the instance id and cookie to userspace */
> + if (WARN_ON(nla_put_u8(msg, NL80211_ATTR_NAN_FUNC_INST_ID,
> + func.instance_id) ||
> + nla_put_u64(msg, NL80211_ATTR_COOKIE,
> func.cookie))) {
use the appropriate nesting here.
johannes
next prev parent reply other threads:[~2016-04-06 8:47 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 9:34 [PATCHv3 RESEND 01/11] cfg80211: add start / stop NAN commands Emmanuel Grumbach
2016-03-29 9:35 ` [PATCHv3 RESEND 02/11] mac80211: add boilerplate code for start / stop NAN Emmanuel Grumbach
2016-04-06 8:27 ` Johannes Berg
2016-03-29 9:35 ` [PATCHv3 RESEND 03/11] cfg80211: add add_nan_func / rm_nan_func Emmanuel Grumbach
2016-04-06 8:40 ` Johannes Berg
2016-04-06 8:47 ` Johannes Berg [this message]
2016-03-29 9:35 ` [PATCHv3 RESEND 04/11] cfg80211: allow the user space to change current NAN configuration Emmanuel Grumbach
2016-04-06 8:44 ` Johannes Berg
2016-03-29 9:35 ` [PATCHv3 RESEND 05/11] cfg80211: provide a function to report a match for NAN Emmanuel Grumbach
2016-04-06 8:51 ` Johannes Berg
2016-04-06 9:38 ` Malinen, Jouni
2016-04-06 9:40 ` Johannes Berg
2016-03-29 9:35 ` [PATCHv3 RESEND 06/11] cfg80211: Provide an API to report NAN function termination Emmanuel Grumbach
2016-04-06 8:52 ` Johannes Berg
2016-04-06 9:40 ` Malinen, Jouni
2016-04-06 10:43 ` Otcheretianski, Andrei
2016-03-29 9:35 ` [PATCHv3 RESEND 07/11] cfg80211: add utility functions to clone and free nan_func Emmanuel Grumbach
2016-04-06 9:02 ` Johannes Berg
2016-03-29 9:35 ` [PATCHv3 RESEND 08/11] mac80211: implement nan_change_conf Emmanuel Grumbach
2016-04-06 9:07 ` Johannes Berg
2016-03-29 9:35 ` [PATCHv3 RESEND 09/11] mac80211: Implement add_nan_func and rm_nan_func Emmanuel Grumbach
2016-04-06 9:22 ` Johannes Berg
2016-03-29 9:35 ` [PATCHv3 RESEND 10/11] mac80211: Add API to report nan function match Emmanuel Grumbach
2016-04-06 9:24 ` Johannes Berg
2016-03-29 9:35 ` [PATCHv3 RESEND 11/11] cfg80211: allow to tie the NAN instance to the owner Emmanuel Grumbach
2016-04-06 8:24 ` [PATCHv3 RESEND 01/11] cfg80211: add start / stop NAN commands Johannes Berg
2016-04-06 9:34 ` Malinen, Jouni
2016-04-06 9:43 ` Johannes Berg
2016-04-06 9:44 ` Grumbach, Emmanuel
2016-04-06 10:14 ` Otcheretianski, Andrei
2016-04-06 9:55 ` Malinen, Jouni
2016-04-06 10:01 ` Grumbach, Emmanuel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459932471.17504.35.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=andrei.otcheretianski@intel.com \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.