All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Dobrowolski <robert.dobrowolski@linux.intel.com>
To: linux-usb@vger.kernel.org
Cc: robert.dobrowolski@linux.intel.com, rafal.f.redzimski@intel.com,
	stable@vger.kernel.org, oliver@neukum.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v1] net: cdc_ncm: update datagram size after changing mtu
Date: Wed,  6 Apr 2016 13:41:09 +0200	[thread overview]
Message-ID: <1459942869-13587-1-git-send-email-robert.dobrowolski@linux.intel.com> (raw)

From: Rafal Redzimski <rafal.f.redzimski@intel.com>

Current implementation updates the mtu size and notify cdc_ncm
device using USB_CDC_SET_MAX_DATAGRAM_SIZE request about datagram
size change instead of changing rx_urb_size.

Whenever mtu is being changed, datagram size should also be
updated.

Cc: <stable@vger.kernel.org>
Signed-off-by: Rafal Redzimski <rafal.f.redzimski@intel.com>
Signed-off-by: Robert Dobrowolski <robert.dobrowolski@linux.intel.com>
---
 drivers/net/usb/cdc_ncm.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index 2fb31ed..4a47656 100644
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -746,6 +746,8 @@ int cdc_ncm_change_mtu(struct net_device *net, int new_mtu)
 	if (new_mtu <= 0 || new_mtu > maxmtu)
 		return -EINVAL;
 	net->mtu = new_mtu;
+	cdc_ncm_set_dgram_size(dev, new_mtu);
+
 	return 0;
 }
 EXPORT_SYMBOL_GPL(cdc_ncm_change_mtu);
-- 
1.9.1

             reply	other threads:[~2016-04-06 11:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-06 11:41 Robert Dobrowolski [this message]
2016-04-06 14:36 ` [PATCH v1] net: cdc_ncm: update datagram size after changing mtu Bjørn Mork
2016-04-11 12:00   ` Robert Dobrowolski
2016-04-11 12:00     ` Robert Dobrowolski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459942869-13587-1-git-send-email-robert.dobrowolski@linux.intel.com \
    --to=robert.dobrowolski@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oliver@neukum.org \
    --cc=rafal.f.redzimski@intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.