All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Koul, Vinod" <vinod.koul@intel.com>
To: "broonie@kernel.org" <broonie@kernel.org>,
	"tiwai@suse.de" <tiwai@suse.de>
Cc: "liam.r.girdwood@linux.intel.com"
	<liam.r.girdwood@linux.intel.com>,
	Patches Audio <patches.audio@intel.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"Nc, Shreyas" <shreyas.nc@intel.com>
Subject: Re: [PATCH v2 2/2] conf: topology: Generate Private data binary blobs
Date: Wed, 6 Apr 2016 13:03:25 +0000	[thread overview]
Message-ID: <1459947792.3136.68.camel@intel.com> (raw)
In-Reply-To: <20160405212416.GL1924@sirena.org.uk>

On Tue, 2016-04-05 at 14:24 -0700, Mark Brown wrote:
> On Tue, Apr 05, 2016 at 10:10:48PM +0200, Takashi Iwai wrote:
> 
> > OK.  But now I noticed another pitfall.
> > The topology firmware is endian-sensitive, and the code to generate
> > is
> > so, too.  Thus it can't work for big-endian architectures.

This code is not intended to work on big-endian ones :). We will add
__lexx notations on these.

> The firmware side of this needs to be fixed at the ABI level I think,
> that's definitely an oversight - thanks for spotting it!  We have
> platforms which can switch at boot time between big and little endian 
> so an unfixed endinanness is not going to be usable there.

The topology ABI has been defined as little-endian. The driver needs to
do conversion to machine type and use data from topology.

-- 
~Vinod

      reply	other threads:[~2016-04-06 13:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-05  5:20 [PATCH v2 0/2] conf: topology: Add the conf for SKL-rt286 Vinod Koul
2016-04-05  5:20 ` [PATCH v2 2/2] conf: topology: Generate Private data binary blobs Vinod Koul
2016-04-05 12:00   ` Takashi Iwai
2016-04-05 14:38     ` Koul, Vinod
2016-04-05 14:45       ` Takashi Iwai
2016-04-05 15:52         ` Koul, Vinod
2016-04-05 16:05           ` Takashi Iwai
2016-04-05 16:08             ` Koul, Vinod
2016-04-05 20:10               ` Takashi Iwai
2016-04-05 21:24                 ` Mark Brown
2016-04-06 13:03                   ` Koul, Vinod [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459947792.3136.68.camel@intel.com \
    --to=vinod.koul@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=patches.audio@intel.com \
    --cc=shreyas.nc@intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.